[ty] Fix stale semantic tokens after opening the same document with new content#22414
Merged
MichaReiser merged 1 commit intomainfrom Jan 6, 2026
Merged
[ty] Fix stale semantic tokens after opening the same document with new content#22414MichaReiser merged 1 commit intomainfrom
MichaReiser merged 1 commit intomainfrom
Conversation
MichaReiser
added
bug
|
dhruvmanila
approved these changes
Jan 6, 2026
Member
dhruvmanila
left a comment
dhruvmanila
left a comment
There was a problem hiding this comment.
Thanks!
I tested out that this also fixes astral-sh/ty#2353.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes astral-sh/ty#2346
Fixes astral-sh/ty#2353
We never synced the
File::revisionafter closing a file, but we should to ensureFile::revisionreverts back to using the file's last modified timestamp.Test Plan
Added E2E test