Skip to content

Comments

Avoid flagging blind exceptions with valid logging#2232

Merged
charliermarsh merged 1 commit intomainfrom
charlie/type-checking
Jan 26, 2023
Merged

Avoid flagging blind exceptions with valid logging#2232
charliermarsh merged 1 commit intomainfrom
charlie/type-checking

Conversation

@charliermarsh
Copy link
Member

Closes #2212.

@charliermarsh charliermarsh merged commit b08367b into main Jan 26, 2023
@charliermarsh charliermarsh deleted the charlie/type-checking branch January 26, 2023 22:05
renovate bot referenced this pull request in ixm-one/pytest-cmake-presets Jan 27, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.235` ->
`^0.0.236` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.236/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.236/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.236/compatibility-slim/0.0.235)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.236/confidence-slim/0.0.235)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.236`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.236)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.235...v0.0.236)

#### What's Changed

##### Rules

- feat: implement `TRY002` and `TRY003` by
[@&#8203;karpa4o4](https://togithub.com/karpa4o4) in
[https://github.com/charliermarsh/ruff/pull/2135](https://togithub.com/charliermarsh/ruff/pull/2135)
- Implementing `TRY400` by
[@&#8203;Flowake](https://togithub.com/Flowake) in
[https://github.com/charliermarsh/ruff/pull/2115](https://togithub.com/charliermarsh/ruff/pull/2115)
- Implement some rules from `flake8-logging-format` (`G`) by
[@&#8203;edgarrmondragon](https://togithub.com/edgarrmondragon) in
[https://github.com/charliermarsh/ruff/pull/2150](https://togithub.com/charliermarsh/ruff/pull/2150)

##### Settings

- Add strictness setting for `flake8-typing-imports` by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/2221](https://togithub.com/charliermarsh/ruff/pull/2221)
- Implement `exempt-modules` setting from flake8-type-checking by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/2230](https://togithub.com/charliermarsh/ruff/pull/2230)

##### Bug fixes

- flake8\_executable: Only match shebang at beginning of line by
[@&#8203;andersk](https://togithub.com/andersk) in
[https://github.com/charliermarsh/ruff/pull/2183](https://togithub.com/charliermarsh/ruff/pull/2183)
- Don't flag B009/B010 if identifiers would be mangled by
[@&#8203;sciyoshi](https://togithub.com/sciyoshi) in
[https://github.com/charliermarsh/ruff/pull/2204](https://togithub.com/charliermarsh/ruff/pull/2204)
- fix: --explain reporting the wrong linter by
[@&#8203;not-my-profile](https://togithub.com/not-my-profile) in
[https://github.com/charliermarsh/ruff/pull/2215](https://togithub.com/charliermarsh/ruff/pull/2215)
- Preserve indentation when fixing via LibCST by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/2223](https://togithub.com/charliermarsh/ruff/pull/2223)
- Avoid erroneous class autofixes in indented blocks by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/2226](https://togithub.com/charliermarsh/ruff/pull/2226)
- Fix range for `try-consider-else` by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/2228](https://togithub.com/charliermarsh/ruff/pull/2228)
- Avoid flagging blind exceptions with valid logging by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/2232](https://togithub.com/charliermarsh/ruff/pull/2232)
- Avoid removing trailing comments on `pass` statements by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/2235](https://togithub.com/charliermarsh/ruff/pull/2235)
- Allow `pytest` in shebang by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/2237](https://togithub.com/charliermarsh/ruff/pull/2237)
- Wrap return-bool-condition-directly fixes in bool() by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/2240](https://togithub.com/charliermarsh/ruff/pull/2240)

#### New Contributors

- [@&#8203;Flowake](https://togithub.com/Flowake) made their first
contribution in
[https://github.com/charliermarsh/ruff/pull/2115](https://togithub.com/charliermarsh/ruff/pull/2115)
- [@&#8203;henryiii](https://togithub.com/henryiii) made their first
contribution in
[https://github.com/charliermarsh/ruff/pull/2200](https://togithub.com/charliermarsh/ruff/pull/2200)
- [@&#8203;sciyoshi](https://togithub.com/sciyoshi) made their first
contribution in
[https://github.com/charliermarsh/ruff/pull/2204](https://togithub.com/charliermarsh/ruff/pull/2204)

**Full Changelog**:
astral-sh/ruff@v0.0.235...v0.0.236

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTEuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExMS4xIn0=-->

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow BLE001 if traceback is generated?

1 participant