[ty] Support assignment to unions of TypedDicts#22294
Merged
ibraheemdev merged 2 commits intomainfrom Jan 12, 2026
Merged
Conversation
ibraheemdev
requested review from
AlexWaygood,
dcreager and
sharkdp
as code owners
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
ibraheemdev
force-pushed
the
ibraheem/type-dict-union
branch
from
0ff4fa8 to
d1d79d1
Compare
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-assignment |
0 | 48 | 0 |
invalid-argument-type |
2 | 39 | 1 |
invalid-return-type |
3 | 22 | 5 |
unused-ignore-comment |
0 | 2 | 0 |
| Total | 5 | 111 | 6 |
oconnor663
reviewed
Jan 12, 2026
| return ty; | ||
| } | ||
| } else if let Type::Union(tcx) = tcx { | ||
| // Otherwise, disable diagnostics as we attempt to narrow to specific elements of the union. |
| } | ||
|
|
||
| if !narrowed_typed_dicts.is_empty() { | ||
| // Now that we know which typed dict annotations are valid, re-infer with diagnostics enabled, |
Contributor
There was a problem hiding this comment.
Out of curiosity, what would go wrong if we skipped this step? (I.e. we restored the previous multi-inference state and then just returned the union, without actually re-inferring these expressions in the Intersect state.)
Contributor
There was a problem hiding this comment.
The LSP (and all its sub-expressions) would have no hover type in the LSP.
carljm
approved these changes
Jan 12, 2026
| } | ||
|
|
||
| if !narrowed_typed_dicts.is_empty() { | ||
| // Now that we know which typed dict annotations are valid, re-infer with diagnostics enabled, |
Contributor
There was a problem hiding this comment.
The LSP (and all its sub-expressions) would have no hover type in the LSP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves astral-sh/ty#2265.