[ty] Allow including files with no extension#22243
Merged
MichaReiser merged 2 commits intomainfrom Jan 7, 2026
Merged
Conversation
MichaReiser
added
configuration
MichaReiser
requested review from
carljm,
dcreager and
sharkdp
as code owners
MichaReiser
added
configuration
MichaReiser
changed the title
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
MichaReiser
requested review from
BurntSushi
and removed request for
carljm,
dcreager and
sharkdp
MichaReiser
commented
Dec 29, 2025
| glob_set: GlobSet, | ||
| original_patterns: Box<[String]>, | ||
| original_patterns: Box<[Box<str>]>, | ||
| literal_pattern_indices: Box<[usize]>, |
Member
Author
There was a problem hiding this comment.
It's a bit silly that we have to track this, given that globset has this information internally but there's no API for it.
Member
There was a problem hiding this comment.
Hah yeah, but I think globset only tracks this sort of thing for perf. And that approach could change. So probably not a candidate for a public API unfortunately.
MichaReiser
force-pushed
the
micha/include-files-without-extension
branch
from
7a40fc5 to
7833bfa
Compare
Gankra
approved these changes
Jan 5, 2026
Gankra
reviewed
Jan 5, 2026
Comment on lines
+223
to
+227
| let source_type = if literal_match == Some(true) || entry.depth() == 0 { | ||
| Some(PySourceType::Python) | ||
| } else { | ||
| entry.path().extension().and_then(PySourceType::try_from_extension).or_else(|| db.system().source_type(entry.path())) | ||
| }; |
Contributor
There was a problem hiding this comment.
Actually wait doesn't this imply include = ["a.ipynb", "b.pyi"] will both be forced to be interpretted as .py?
Member
Author
There was a problem hiding this comment.
The code here only filters out files that are known to be non-Python files. Resolving the source type "for real" happens in source_text.
Contributor
There was a problem hiding this comment.
Is entry.path().extension().and_then(PySourceType::try_from_extension) useless then?
Contributor
There was a problem hiding this comment.
Oh I think I understand what you mean -- these Option<PySourceType>'s are glorified booleans here.
Member
Author
There was a problem hiding this comment.
No, it is necessary to filter out files with e.g. a .txt extension when including an entire directory. db.system().source_type only returns Some for files where the source type is overriden.
BurntSushi
approved these changes
Jan 6, 2026
| .build()?; | ||
| self.original_pattern.push(input.relative().to_string()); | ||
|
|
||
| let is_literal_pattern = globset::escape(glob_pattern) == glob_pattern; |
| glob_set: GlobSet, | ||
| original_patterns: Box<[String]>, | ||
| original_patterns: Box<[Box<str>]>, | ||
| literal_pattern_indices: Box<[usize]>, |
Member
There was a problem hiding this comment.
Hah yeah, but I think globset only tracks this sort of thing for perf. And that approach could change. So probably not a candidate for a public API unfortunately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for including files that have no extension or use a non-standard extension.
Such files can be included by explicitly listing them in the
includeconfiguration. ty will assume that those files are Python filesCloses astral-sh/ty#2235
Test Plan
Added CLI test