[ty] Fix attribute lookup on `type[T]` where `T` has a union bound by charliermarsh · Pull Request #22116 · astral-sh/ruff

charliermarsh · 2025-12-20T18:47:36Z

Summary

For type[T] where T: Replace | Multiply, we now do the following:

try_from_instance(Replace | Multiply) becomes type[Replace] | type[Multiply]
to_meta_type(type[Replace] | type[Multiply]) becomes type[type] | type[type] which becomes type[type]

See: #22115 (comment)

astral-sh-bot · 2025-12-20T18:49:23Z

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

astral-sh-bot · 2025-12-20T18:50:33Z

`mypy_primer` results

Changes were detected when running on open source projects

tornado (https://github.com/tornadoweb/tornado)
- tornado/gen.py:255:62: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `None | Awaitable[Unknown] | list[Awaitable[Unknown]] | dict[Any, Awaitable[Unknown]] | Future[Unknown]`, found `_T@next | _VT@next | _T@next`
+ tornado/gen.py:255:62: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `None | Awaitable[Unknown] | list[Awaitable[Unknown]] | dict[Any, Awaitable[Unknown]] | Future[Unknown]`, found `_T@next | _T@next | _VT@next`

Tanjun (https://github.com/FasterSpeeding/Tanjun)
- tanjun/dependencies/data.py:347:12: error[invalid-return-type] Return type does not match returned value: expected `_T@cached_inject`, found `Coroutine[Any, Any, _T@cached_inject | Coroutine[Any, Any, _T@cached_inject]] | _T@cached_inject`
+ tanjun/dependencies/data.py:347:12: error[invalid-return-type] Return type does not match returned value: expected `_T@cached_inject`, found `_T@cached_inject | Coroutine[Any, Any, _T@cached_inject | Coroutine[Any, Any, _T@cached_inject]]`

meson (https://github.com/mesonbuild/meson)
- mesonbuild/interpreterbase/baseobjects.py:199:16: warning[possibly-missing-attribute] Attribute `__name__` may be missing on object of type `type[Unknown] | type[InterpreterObjectTypeVar@ObjectHolder]`
- mesonbuild/interpreterbase/baseobjects.py:216:51: warning[possibly-missing-attribute] Attribute `__name__` may be missing on object of type `type[Unknown] | type[InterpreterObjectTypeVar@ObjectHolder]`
- Found 1947 diagnostics
+ Found 1945 diagnostics

xarray (https://github.com/pydata/xarray)
- xarray/core/dataarray.py:5737:16: error[invalid-return-type] Return type does not match returned value: expected `T_Xarray@map_blocks`, found `T_Xarray@map_blocks | DataArray | Dataset`
+ xarray/core/dataarray.py:5737:16: error[invalid-return-type] Return type does not match returned value: expected `T_Xarray@map_blocks`, found `DataArray | Dataset`
- xarray/core/dataset.py:8866:16: error[invalid-return-type] Return type does not match returned value: expected `T_Xarray@map_blocks`, found `T_Xarray@map_blocks | DataArray | Dataset`
+ xarray/core/dataset.py:8866:16: error[invalid-return-type] Return type does not match returned value: expected `T_Xarray@map_blocks`, found `DataArray | Dataset`

scikit-build-core (https://github.com/scikit-build/scikit-build-core)
- src/scikit_build_core/build/wheel.py:98:20: error[no-matching-overload] No overload of bound method `__init__` matches arguments
- Found 43 diagnostics
+ Found 42 diagnostics

hydpy (https://github.com/hydpy-dev/hydpy)
- hydpy/auxs/calibtools.py:1814:34: error[unresolved-attribute] Object of type `type[TypeRule2@get_rule]` has no attribute `__name__`
- hydpy/auxs/calibtools.py:1979:62: error[unresolved-attribute] Object of type `type[TypeRule1@CalibrationInterface]` has no attribute `__name__`
- Found 680 diagnostics
+ Found 678 diagnostics

static-frame (https://github.com/static-frame/static-frame)
- static_frame/core/bus.py:671:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemLocReduces[Bus[Any], object_]`, found `InterGetItemLocReduces[Top[Index[Any]] | TypeBlocks | Top[Bus[Any]] | ... omitted 6 union elements, object_]`
+ static_frame/core/bus.py:675:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[Bus[Any], object_]`, found `InterGetItemILocReduces[Self@iloc | Bus[Any], object_ | Self@iloc]`
- static_frame/core/bus.py:675:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[Bus[Any], object_]`, found `InterGetItemILocReduces[Top[Index[Any]] | TypeBlocks | Top[Bus[Any]] | ... omitted 6 union elements, generic[object]]`
- static_frame/core/index.py:580:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemLocReduces[TVContainer_co@loc, TVDtype@Index]`, found `InterGetItemLocReduces[Any | Bottom[Series[Any, Any]], TVDtype@Index]`
+ static_frame/core/index.py:580:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemLocReduces[TVContainer_co@loc, TVDtype@Index]`, found `InterGetItemLocReduces[Top[Series[Any, Any]] | Any, TVDtype@Index]`
- static_frame/core/node_selector.py:526:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemLocReduces[TVContainer_co@InterfaceSelectQuartet, Any]`, found `InterGetItemLocReduces[Unknown | Bottom[Series[Any, Any]], Any]`
+ static_frame/core/node_selector.py:526:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemLocReduces[TVContainer_co@InterfaceSelectQuartet, Any]`, found `InterGetItemLocReduces[Top[Series[Any, Any]] | Unknown, Any]`
- static_frame/core/series.py:772:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[Series[Any, Any], TVDtype@Series]`, found `InterGetItemILocReduces[Series[Any, Any] | TypeBlocks | Batch | ... omitted 6 union elements, generic[object]]`
+ static_frame/core/series.py:772:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[Series[Any, Any], TVDtype@Series]`, found `InterGetItemILocReduces[TypeBlocks | Batch | SeriesAssign | ... omitted 6 union elements, generic[object]]`
- static_frame/core/series.py:4072:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[SeriesHE[Any, Any], TVDtype@SeriesHE]`, found `InterGetItemILocReduces[Bottom[Series[Any, Any]] | TypeBlocks | Batch | ... omitted 7 union elements, generic[object]]`
+ static_frame/core/series.py:4072:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[SeriesHE[Any, Any], TVDtype@SeriesHE]`, found `InterGetItemILocReduces[TypeBlocks | Batch | SeriesAssign | ... omitted 6 union elements, generic[object]]`
- static_frame/core/yarn.py:418:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[Yarn[Any], object_]`, found `InterGetItemILocReduces[Top[Yarn[Any]] | TypeBlocks | Batch | ... omitted 6 union elements, generic[object]]`
+ static_frame/core/yarn.py:418:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[Yarn[Any], object_]`, found `InterGetItemILocReduces[Top[Index[Any]] | Top[Series[Any, Any]] | Top[Yarn[Any]] | ... omitted 6 union elements, generic[object]]`
- Found 1844 diagnostics
+ Found 1843 diagnostics

No memory usage changes detected ✅

AlexWaygood

Haven't looked too closely yet but it surprises me a bit that we'd have to map over the bounds/constraints like this... would appreciate it if @ibraheemdev could take a look, since he originally implemented type[T] where T is a type variable

crates/ty_python_semantic/resources/mdtest/type_of/generics.md

AlexWaygood · 2025-12-20T21:31:27Z

Okay that looks a lot more like what I'd expect! 😃 but I'd still love it if @ibraheemdev could take a look

ibraheemdev

Looks good to me!

charliermarsh · 2025-12-20T21:55:43Z

Let’s go!

charliermarsh · 2025-12-20T22:04:06Z

(The test case here does depend on #22115 being merged though.)

charliermarsh added the ty Multi-file analysis & type inference label Dec 20, 2025

charliermarsh force-pushed the charlie/unions branch from 3bccb24 to f62be39 Compare December 20, 2025 18:55

charliermarsh force-pushed the charlie/met branch from 4549d81 to a9e126a Compare December 20, 2025 18:55

charliermarsh marked this pull request as ready for review December 20, 2025 18:57

charliermarsh requested review from AlexWaygood, carljm, dcreager and sharkdp as code owners December 20, 2025 18:57

AlexWaygood reviewed Dec 20, 2025

View reviewed changes

crates/ty_python_semantic/resources/mdtest/type_of/generics.md Outdated Show resolved Hide resolved

ibraheemdev approved these changes Dec 20, 2025

View reviewed changes

[ty] Fix attribute lookup on where T has a union bound

af1c0de

charliermarsh mentioned this pull request Dec 20, 2025

[ty] Distribute type[] over unions #22115

Merged

Use with_transposed_type_var

f68a261

charliermarsh force-pushed the charlie/met branch from 92459ec to f68a261 Compare December 20, 2025 22:04

charliermarsh merged commit e3c4362 into charlie/unions Dec 21, 2025
42 checks passed

charliermarsh deleted the charlie/met branch December 21, 2025 23:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ty] Fix attribute lookup on `type[T]` where `T` has a union bound#22116

[ty] Fix attribute lookup on `type[T]` where `T` has a union bound#22116
charliermarsh merged 2 commits intocharlie/unionsfrom
charlie/met

charliermarsh commented Dec 20, 2025 •

edited

Loading

Uh oh!

astral-sh-bot bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

astral-sh-bot bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

AlexWaygood left a comment •

edited

Loading

Uh oh!

Uh oh!

AlexWaygood commented Dec 20, 2025

Uh oh!

ibraheemdev left a comment

Uh oh!

charliermarsh commented Dec 20, 2025

Uh oh!

charliermarsh commented Dec 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

charliermarsh commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

astral-sh-bot bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diagnostic diff on typing conformance tests

Uh oh!

astral-sh-bot bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

AlexWaygood left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlexWaygood commented Dec 20, 2025

Uh oh!

ibraheemdev left a comment

Choose a reason for hiding this comment

Uh oh!

charliermarsh commented Dec 20, 2025

Uh oh!

charliermarsh commented Dec 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

charliermarsh commented Dec 20, 2025 •

edited

Loading

astral-sh-bot bot commented Dec 20, 2025 •

edited

Loading

astral-sh-bot bot commented Dec 20, 2025 •

edited

Loading

`mypy_primer` results

AlexWaygood left a comment •

edited

Loading