[ty] Store un-widened type in Place#22093
Merged
charliermarsh merged 2 commits intomainfrom Dec 24, 2025
Merged
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
charliermarsh
commented
Dec 19, 2025
| ) | ||
| } | ||
| Type::Union(union) => { | ||
| // TODO: This is a hack. The proper fix is to avoid unioning Unknown from |
charliermarsh
force-pushed
the
charlie/place
branch
from
29355b5 to
07ba2f4
Compare
AlexWaygood
changed the title
PlacePlace
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
MichaReiser
reviewed
Dec 19, 2025
| _, | ||
| _, | ||
| crate::place::Definedness::AlwaysDefined, | ||
| _, |
Member
There was a problem hiding this comment.
It might be time for named fields...
Member
Author
There was a problem hiding this comment.
Now THAT I am capable of doing.
Member
There was a problem hiding this comment.
But maybe wait for a review from someone more knowledgeable on the overall approach or doing it in a separate PR
carljm
approved these changes
Dec 24, 2025
Contributor
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
The approach looks good here in general! I do think we need a bit of attention to ergonomics. Probably that's just named fields? We could add method(s) to return narrower views on the struct if most matches don't need all the fields, not sure if that's worth it. We can also do any of that as a separate follow-up PR.
charliermarsh
force-pushed
the
charlie/place
branch
from
07ba2f4 to
bf7f52f
Compare
charliermarsh
added a commit
that referenced
this pull request
Jan 6, 2026
## Summary Mechanical refactor to migrate this enum to named fields. No functional changes. See: #22093 (comment). --------- Co-authored-by: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See: #22025 (comment)