[ty] Unwrap `enum.nonmember` values by charliermarsh · Pull Request #22025 · astral-sh/ruff

charliermarsh · 2025-12-17T13:48:10Z

Summary

This PR unwraps the enum.nonmember type to match runtime behavior.

Closes astral-sh/ty#1974.

astral-sh-bot · 2025-12-17T13:50:32Z

Diagnostic diff on typing conformance tests

Changes were detected when running ty on typing conformance tests

--- old-output.txt	2025-12-19 00:07:35.660229877 +0000
+++ new-output.txt	2025-12-19 00:07:37.828248076 +0000
@@ -420,7 +420,7 @@
 enums_members.py:84:35: error[invalid-type-form] Type arguments for `Literal` must be `None`, a literal value (int, bool, str, or bytes), or an enum member
 enums_members.py:85:1: error[type-assertion-failure] Type `Unknown` does not match asserted type `def speak(self) -> None`
 enums_members.py:85:33: error[invalid-type-form] Type arguments for `Literal` must be `None`, a literal value (int, bool, str, or bytes), or an enum member
-enums_members.py:116:1: error[type-assertion-failure] Type `Unknown` does not match asserted type `Unknown | nonmember[int]`
+enums_members.py:116:1: error[type-assertion-failure] Type `Unknown` does not match asserted type `int`
 enums_members.py:116:32: error[invalid-type-form] Type arguments for `Literal` must be `None`, a literal value (int, bool, str, or bytes), or an enum member
 enums_members.py:128:21: info[revealed-type] Revealed type: `Unknown | Literal[2]`
 enums_members.py:129:9: error[type-assertion-failure] Type `Unknown` does not match asserted type `Unknown | Literal[2]`

astral-sh-bot · 2025-12-17T13:52:26Z

`mypy_primer` results

Changes were detected when running on open source projects

xarray (https://github.com/pydata/xarray)
- xarray/core/dataarray.py:5737:16: error[invalid-return-type] Return type does not match returned value: expected `T_Xarray@map_blocks`, found `T_Xarray@map_blocks | DataArray | Dataset`
+ xarray/core/dataarray.py:5737:16: error[invalid-return-type] Return type does not match returned value: expected `T_Xarray@map_blocks`, found `DataArray | Dataset`
- xarray/core/dataset.py:8866:16: error[invalid-return-type] Return type does not match returned value: expected `T_Xarray@map_blocks`, found `T_Xarray@map_blocks | DataArray | Dataset`
+ xarray/core/dataset.py:8866:16: error[invalid-return-type] Return type does not match returned value: expected `T_Xarray@map_blocks`, found `DataArray | Dataset`

prefect (https://github.com/PrefectHQ/prefect)
- src/integrations/prefect-dbt/prefect_dbt/core/settings.py:94:28: error[invalid-assignment] Object of type `dict[str, Any] | T@resolve_block_document_references` is not assignable to `dict[str, Any]`
+ src/integrations/prefect-dbt/prefect_dbt/core/settings.py:94:28: error[invalid-assignment] Object of type `dict[str, Any] | T@resolve_block_document_references | str | ... omitted 4 union elements` is not assignable to `dict[str, Any]`
- src/integrations/prefect-dbt/prefect_dbt/core/settings.py:99:28: error[invalid-assignment] Object of type `dict[str, Any] | T@resolve_variables` is not assignable to `dict[str, Any]`
+ src/integrations/prefect-dbt/prefect_dbt/core/settings.py:99:28: error[invalid-assignment] Object of type `dict[str, Any] | T@resolve_variables | str | ... omitted 4 union elements` is not assignable to `dict[str, Any]`
- src/prefect/cli/deploy/_core.py:86:21: error[invalid-assignment] Object of type `T@resolve_block_document_references | dict[str, Any]` is not assignable to `dict[str, Any]`
+ src/prefect/cli/deploy/_core.py:86:21: error[invalid-assignment] Object of type `T@resolve_block_document_references | dict[str, Any] | str | ... omitted 4 union elements` is not assignable to `dict[str, Any]`
- src/prefect/cli/deploy/_core.py:87:21: error[invalid-assignment] Object of type `T@resolve_variables` is not assignable to `dict[str, Any]`
+ src/prefect/cli/deploy/_core.py:87:21: error[invalid-assignment] Object of type `T@resolve_variables | str | int | ... omitted 4 union elements` is not assignable to `dict[str, Any]`
- src/prefect/deployments/steps/core.py:137:38: error[invalid-argument-type] Argument is incorrect: Expected `T@resolve_variables`, found `T@resolve_block_document_references | dict[str, Any]`
+ src/prefect/deployments/steps/core.py:137:38: error[invalid-argument-type] Argument is incorrect: Expected `T@resolve_variables`, found `T@resolve_block_document_references | dict[str, Any] | str | ... omitted 4 union elements`
- src/prefect/utilities/templating.py:320:13: error[invalid-assignment] Invalid subscript assignment with key of type `object` and value of type `T@resolve_block_document_references | dict[str, Any]` on object of type `dict[str, Any]`
+ src/prefect/utilities/templating.py:320:13: error[invalid-assignment] Invalid subscript assignment with key of type `object` and value of type `T@resolve_block_document_references | dict[str, Any] | str | ... omitted 4 union elements` on object of type `dict[str, Any]`
- src/prefect/utilities/templating.py:323:16: error[invalid-return-type] Return type does not match returned value: expected `T@resolve_block_document_references | dict[str, Any]`, found `list[T@resolve_block_document_references | dict[str, Any] | Unknown]`
+ src/prefect/utilities/templating.py:323:16: error[invalid-return-type] Return type does not match returned value: expected `T@resolve_block_document_references | dict[str, Any]`, found `list[T@resolve_block_document_references | dict[str, Any] | str | ... omitted 5 union elements]`
- src/prefect/utilities/templating.py:437:16: error[invalid-return-type] Return type does not match returned value: expected `T@resolve_variables`, found `dict[object, T@resolve_variables | Unknown]`
+ src/prefect/utilities/templating.py:437:16: error[invalid-return-type] Return type does not match returned value: expected `T@resolve_variables`, found `dict[object, T@resolve_variables | str | int | ... omitted 5 union elements]`
- src/prefect/utilities/templating.py:442:16: error[invalid-return-type] Return type does not match returned value: expected `T@resolve_variables`, found `list[T@resolve_variables | Unknown]`
+ src/prefect/utilities/templating.py:442:16: error[invalid-return-type] Return type does not match returned value: expected `T@resolve_variables`, found `list[T@resolve_variables | str | int | ... omitted 5 union elements]`
- src/prefect/workers/base.py:228:13: error[invalid-argument-type] Argument is incorrect: Expected `T@resolve_variables`, found `T@resolve_block_document_references | dict[str, Any]`
+ src/prefect/workers/base.py:228:13: error[invalid-argument-type] Argument is incorrect: Expected `T@resolve_variables`, found `T@resolve_block_document_references | dict[str, Any] | str | ... omitted 4 union elements`
- src/prefect/workers/base.py:230:20: error[invalid-argument-type] Argument expression after ** must be a mapping type: Found `T@resolve_variables`
+ src/prefect/workers/base.py:230:20: error[invalid-argument-type] Argument expression after ** must be a mapping type: Found `T@resolve_variables | str | int | ... omitted 4 union elements`

scikit-build-core (https://github.com/scikit-build/scikit-build-core)
- src/scikit_build_core/build/wheel.py:98:20: error[no-matching-overload] No overload of bound method `__init__` matches arguments
- Found 44 diagnostics
+ Found 43 diagnostics

static-frame (https://github.com/static-frame/static-frame)
- static_frame/core/series.py:772:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[Series[Any, Any], TVDtype@Series]`, found `InterGetItemILocReduces[Series[Any, Any] | Top[Index[Any]] | TypeBlocks | ... omitted 6 union elements, generic[object]]`
+ static_frame/core/series.py:772:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[Series[Any, Any], TVDtype@Series]`, found `InterGetItemILocReduces[Series[Any, Any] | TypeBlocks | Batch | ... omitted 6 union elements, generic[object]]`
- static_frame/core/series.py:4072:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[SeriesHE[Any, Any], TVDtype@SeriesHE]`, found `InterGetItemILocReduces[SeriesHE[Any, Any] | Top[Index[Any]] | TypeBlocks | ... omitted 7 union elements, generic[object]]`
+ static_frame/core/series.py:4072:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[SeriesHE[Any, Any], TVDtype@SeriesHE]`, found `InterGetItemILocReduces[SeriesHE[Any, Any] | TypeBlocks | Batch | ... omitted 7 union elements, generic[object]]`
- static_frame/core/yarn.py:418:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[Yarn[Any], object_]`, found `InterGetItemILocReduces[Yarn[Any] | TypeBlocks | Batch | ... omitted 7 union elements, generic[object]]`
+ static_frame/core/yarn.py:418:16: error[invalid-return-type] Return type does not match returned value: expected `InterGetItemILocReduces[Yarn[Any], object_]`, found `InterGetItemILocReduces[Yarn[Any] | Top[Index[Any]] | TypeBlocks | ... omitted 7 union elements, generic[object]]`

pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
- pandas-stubs/_typing.pyi:1223:16: warning[unused-ignore-comment] Unused blanket `type: ignore` directive
- Found 5086 diagnostics
+ Found 5085 diagnostics

No memory usage changes detected ✅

codspeed-hq · 2025-12-17T14:05:26Z

CodSpeed Performance Report

Merging #22025 will not alter performance

_{Comparing charlie/non (ab51c81) with main (5a2d3cd)}

Summary

✅ 22 untouched
⏩ 30 skipped¹

30 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

crates/ty_python_semantic/src/types/class.rs

crates/ty_python_semantic/src/types.rs

crates/ty_python_semantic/src/types/class.rs

AlexWaygood · 2025-12-18T15:41:53Z

I'll leave this to @carljm (since he's already reviewed) and/or @sharkdp (who originally implemented enums and member/nonmember for us)

carljm

Looks good!

crates/ty_python_semantic/resources/mdtest/enums.md

crates/ty_python_semantic/src/types/enums.rs

This reverts commit 03f743d.

carljm

ship it

## Summary See: #22025 (comment)

charliermarsh force-pushed the charlie/non branch from db36555 to 8ddff63 Compare December 17, 2025 14:04

ntBre added the ty Multi-file analysis & type inference label Dec 17, 2025

charliermarsh changed the title ~~Unwrap enum.nonmember values~~ [ty] Unwrap enum.nonmember values Dec 17, 2025

charliermarsh marked this pull request as ready for review December 17, 2025 14:31

charliermarsh requested review from AlexWaygood, carljm, dcreager and sharkdp as code owners December 17, 2025 14:31

charliermarsh marked this pull request as draft December 17, 2025 14:45

charliermarsh marked this pull request as ready for review December 17, 2025 15:10

carljm reviewed Dec 17, 2025

View reviewed changes

charliermarsh force-pushed the charlie/non branch from 4e3d7e5 to e9ddec1 Compare December 18, 2025 00:58

charliermarsh requested a review from carljm December 18, 2025 00:59

AlexWaygood removed their request for review December 18, 2025 15:41

carljm reviewed Dec 18, 2025

View reviewed changes

crates/ty_python_semantic/resources/mdtest/enums.md Outdated Show resolved Hide resolved

crates/ty_python_semantic/src/types/enums.rs Show resolved Hide resolved

charliermarsh added 5 commits December 18, 2025 15:06

Unwrap enum.nonmember values

31fa9c4

Go through own_class_member

f62faeb

Avoid repeated calls

1c2461b

Review feedback

1358a62

Use place_from_bindings

03f743d

charliermarsh force-pushed the charlie/non branch from e9ddec1 to 03f743d Compare December 18, 2025 20:28

charliermarsh added 2 commits December 18, 2025 19:05

Revert "Use place_from_bindings"

9a7fa3d

This reverts commit 03f743d.

Format

ab51c81

charliermarsh requested a review from carljm December 19, 2025 00:21

carljm approved these changes Dec 19, 2025

View reviewed changes

charliermarsh merged commit 76854fd into main Dec 19, 2025
42 checks passed

charliermarsh deleted the charlie/non branch December 19, 2025 00:59

charliermarsh mentioned this pull request Dec 19, 2025

[ty] Store un-widened type in Place #22093

Merged

charliermarsh added a commit that referenced this pull request Dec 24, 2025

[ty] Store un-widened type in Place (#22093)

81f34fb

## Summary See: #22025 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[ty] Unwrap `enum.nonmember` values#22025

[ty] Unwrap `enum.nonmember` values#22025
charliermarsh merged 7 commits intomainfrom
charlie/non

charliermarsh commented Dec 17, 2025 •

edited

Loading

Uh oh!

astral-sh-bot bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

astral-sh-bot bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexWaygood commented Dec 18, 2025

Uh oh!

carljm left a comment

Uh oh!

Uh oh!

Uh oh!

carljm left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

charliermarsh commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

astral-sh-bot bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diagnostic diff on typing conformance tests

Uh oh!

astral-sh-bot bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

codspeed-hq bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #22025 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexWaygood commented Dec 18, 2025

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

charliermarsh commented Dec 17, 2025 •

edited

Loading

astral-sh-bot bot commented Dec 17, 2025 •

edited

Loading

astral-sh-bot bot commented Dec 17, 2025 •

edited

Loading

`mypy_primer` results

codspeed-hq bot commented Dec 17, 2025 •

edited

Loading