[ty] Cache KnownClass::to_class_literal#22000
Merged
MichaReiser merged 3 commits intomainfrom Dec 16, 2025
Merged
Conversation
MichaReiser
added
internal
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
CodSpeed Performance ReportMerging #22000 will improve performances by 17.44%Comparing Summary
Benchmarks breakdown
Footnotes
|
Member
Author
|
And I have to run all benchmarks one more time |
AlexWaygood
added
performance
This comment was marked as resolved.
This comment was marked as resolved.
MichaReiser
commented
Dec 16, 2025
MichaReiser
commented
Dec 16, 2025
| class | ||
| .try_to_class_literal_without_logging(db) | ||
| .or_else(|lookup_error| { | ||
| if matches!( |
Member
Author
There was a problem hiding this comment.
I don't think this will be a new issue but we might end up seeing this log message when we hit a salsa cycle because the cycle initial function returns None. I can't think of an easy way to avoid this AND keeping the log message.
Member
Author
|
The perf improvement is a wide range from 0-15% on ty benchmark |
MichaReiser
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
dcreager
added a commit
that referenced
this pull request
Dec 16, 2025
* main: [ty] Document `TY_CONFIG_FILE` (#22001) [ty] Cache `KnownClass::to_class_literal` (#22000) [ty] Fix benchmark assertion (#22003) Add uv and ty to the Ruff README (#21996) [ty] Infer precise types for `isinstance(…)` calls involving typevars (#21999) [ty] Use `FxHashMap` in `Signature::has_relation_to` (#21997) [ty] Avoid enforcing standalone expression for tests in f-strings (#21967) [ty] Use `title` for configuration code fences in ty reference documentation (#21992)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds salsa caching to
KnownClass::to_class_literal.I noticed that we spend about 4.5% of discord.py's entire check time in
KnownClass::to_class_literalwhich seemed high. That's why I added salsa caching to the lookup and the results are much better than I thought because:KnownClass::Module::to_class_literalends up in a cycle. Adding cycle handling toto_class_literalreduces the size of the cycle.imported_symbol(whichKnownClass::to_class_literaluses resolvesKnownClass::Module.to_instance). It might be worth trying if we can resolve this cycle somehowKnownClass::to_class_literalon the calling query, adding many dependencies to every query that uses aKnownClass. MakingKnownClass::to_class_literala query ensures that we store the dependencies only once, and dependent query only have to depend onKnownClass::to_class_literal. This helps reduce the memo metadata.