[ty] propagate classmethod-ness through decorators returning Callables#21958
Merged
[ty] propagate classmethod-ness through decorators returning Callables#21958
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
carljm
force-pushed
the
cjm/classmethod
branch
from
0a5ad34 to
71dc7f3
Compare
carljm
requested review from
AlexWaygood,
dcreager and
sharkdp
as code owners
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
missing-argument |
0 | 146 | 0 |
invalid-argument-type |
0 | 76 | 0 |
| Total | 0 | 222 | 0 |
carljm
force-pushed
the
cjm/classmethod
branch
from
71dc7f3 to
dac92e2
Compare
CodSpeed Performance ReportMerging #21958 will not alter performanceComparing Summary
|
|
dcreager
force-pushed
the
dcreager/callable-return
branch
from
874dc7e to
8871fdd
Compare
dhruvmanila
approved these changes
Dec 15, 2025
Member
dhruvmanila
left a comment
dhruvmanila
left a comment
There was a problem hiding this comment.
This sounds like a reasonable approach.
I was wondering about what Alex mentioned last Friday which is whether we could start modeling these decorators directly using the typeshed's definition. I think it might be possible for staticmethod but classmethod requires Concatenate support. But even after that I'm not sure how could we signal ty to pass the implicit cls argument to the callable.
Member
|
Yeah, I think Carl's analysis demonstrates that we will need some version of this even if we go with the approach I outlined on Friday (which may still be worth doing on its own merits after |
carljm
force-pushed
the
cjm/classmethod
branch
from
dac92e2 to
6756bac
Compare
carljm
force-pushed
the
cjm/classmethod
branch
from
6756bac to
88c12ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes astral-sh/ty#1787
Summary
Allow method decorators returning Callables to presumptively propagate "classmethod-ness" in the same way that they already presumptively propagate "function-like-ness". We can't actually be sure that this is the case, based on the decorator's annotations, but (along with other type checkers) we heuristically assume it to be the case for decorators applied via decorator syntax.
Test Plan
Added mdtest.