[ty] "Did you mean?" suggestions on typos for stdlib imports#21780
Closed
AlexWaygood wants to merge 1 commit intomainfrom
Closed
[ty] "Did you mean?" suggestions on typos for stdlib imports#21780AlexWaygood wants to merge 1 commit intomainfrom
AlexWaygood wants to merge 1 commit intomainfrom
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
Member
Author
|
Okay the failing snapshots in the ty crate (and the mypy_primer results) persuade me that this is a bad idea -- too many incorrect hits for these |
Member
Author
|
reviving in #23341 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An easy improvement opportunity I spotted while looking at this area of code for astral-sh/ty#1708