[ty] Emit a diagnostic for subclassing with order=True#21704
Open
charliermarsh wants to merge 1 commit intomainfrom
Open
[ty] Emit a diagnostic for subclassing with order=True#21704charliermarsh wants to merge 1 commit intomainfrom
order=True#21704charliermarsh wants to merge 1 commit intomainfrom
Conversation
order=Trueorder=True
Typing conformance resultsNo changes detected ✅ |
|
bc1c309 to
4e4b08c
Compare
Member
Author
|
I believe those changes on the conformance tests are "correct" in-so-far as those are instances of the case we want to catch here. |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-await |
40 | 0 | 0 |
subclass-of-dataclass-with-order |
5 | 0 | 0 |
invalid-argument-type |
0 | 1 | 0 |
invalid-return-type |
1 | 0 | 0 |
| Total | 46 | 1 | 0 |
AlexWaygood
reviewed
Dec 1, 2025
crates/ty_python_semantic/resources/mdtest/dataclasses/dataclasses.md
Outdated
Show resolved
Hide resolved
Member
|
@charliermarsh are you still interested in getting this over the line? |
Member
Author
|
Yes sir, sorry, lost track. |
24d480b to
634765c
Compare
Member
Author
|
I think the Expression diagnostic is correct: |
634765c to
521e4b4
Compare
Memory usage reportMemory usage unchanged ✅ |
521e4b4 to
19ee5a1
Compare
ef4cee5 to
151ce7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes astral-sh/ty#1681.