Dogfood ty on the scripts directory#21617
Merged
AlexWaygood merged 1 commit intomainfrom Nov 24, 2025
Merged
Conversation
AlexWaygood
added
ci
AlexWaygood
force-pushed
the
alex/dogfood-ty
branch
from
10527af to
c744825
Compare
|
AlexWaygood
commented
Nov 24, 2025
Comment on lines
45
to
48
| if number > 100000: | ||
| number = str(number) | ||
| number: str = str(number) | ||
| number = "_".join(number[i : i + 3] for i in range(0, len(number), 3)) | ||
| return f"{number}_u32" |
Member
Author
There was a problem hiding this comment.
a nice little use of our feature where we allow redeclarations :-)
AlexWaygood
requested review from
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
amyreese
approved these changes
Nov 24, 2025
carljm
approved these changes
Nov 24, 2025
carljm
added a commit
to mtshiba/ruff
that referenced
this pull request
Nov 25, 2025
* main: [ty] Extend Liskov checks to also cover classmethods and staticmethods (astral-sh#21598) Dogfood ty on the `scripts` directory (astral-sh#21617) [ty] support generic aliases in `type[...]`, like `type[C[int]]` (astral-sh#21552) [ty] Retain the function-like-ness of `Callable` types when binding `self` (astral-sh#21614) [ty] Distinguish "unconstrained" from "constrained to any type" (astral-sh#21539) Disable ty workspace diagnostics for VSCode users (astral-sh#21620) [ty] Double click to insert inlay hint (astral-sh#21600) [ty] Switch the error code from `unresolved-attribute` to `possibly-missing-attribute` for submodules that may not be available (astral-sh#21618) [ty] Substitute for `typing.Self` when checking protocol members (astral-sh#21569) [ty] Don't suggest things that aren't subclasses of `BaseException` after `raise` [ty] Add hint about resolved Python version when a user attempts to import a member added on a newer version (astral-sh#21615)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets up CI jobs to run ty from the
mainbranch on the files and subdirectories in ourscriptsdirectoryTest Plan
Both these commands pass for me locally:
uv run --project=./scripts cargo run -p ty check --project=./scriptsuv run --project=./scripts/ty_benchmark cargo run -p ty check --project=./scripts/ty_benchmark