Implement goto-definition and find-references for global/nonlocal statements#21616
Merged
Implement goto-definition and find-references for global/nonlocal statements#21616
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
Gankra
force-pushed
the
gankra/strattr
branch
from
0ab5389 to
108ab4b
Compare
MichaReiser
reviewed
Nov 25, 2025
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
Hmm, the changes in this PR seem to be primarily about string annotations and not nonlocal and global?
Contributor
Author
|
Yes it's based on top of my string attr PR which I have rebased without rebasing this one 😓 |
Gankra
force-pushed
the
gankra/non-exprs
branch
from
ffb93e4 to
370edef
Compare
Gankra
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
Contributor
Author
|
It is now rebased on main and ready to review. |
MichaReiser
added
server
MichaReiser
approved these changes
Nov 25, 2025
carljm
added a commit
to mtshiba/ruff
that referenced
this pull request
Nov 25, 2025
* main: [ty] Implement `typing.override` (astral-sh#21627) [ty] Avoid expression reinference for diagnostics (astral-sh#21267) [ty] Improve autocomplete suppressions of keywords in variable bindings [ty] Only suggest completions based on text before the cursor Implement goto-definition and find-references for global/nonlocal statements (astral-sh#21616) [ty] Inlay Hint edit follow up (astral-sh#21621) [ty] Implement lsp support for string annotations (astral-sh#21577) [ty] Add 'remove unused ignore comment' code action (astral-sh#21582) [ty] Refactor `CheckSuppressionContext` to use `DiagnosticGuard` (astral-sh#21587) [ty] Improve several "Did you mean?" suggestions (astral-sh#21597) [ty] Add more and update existing projects in `ty_benchmark` (astral-sh#21536) [ty] fix ty playground initialization and vite optimization issues (astral-sh#21471)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The implementation here is to just record the idents of these statements in
scopes_by_expression(which already supported idents but only ones that happened to appear in expressions), so thatdefinitions_for_nameJust Works.goto-type (and therefore hover) notably does not work on these statements because the typechecker does not record info for them. I am tempted to just introduce
type_for_namewhich runsdefinitions_for_nameto find other expressions and queries the inferred type... but that's a bit whack because it won't be the computed type at the right point in the code. It probably wouldn't be particularly expensive to just compute/record the type at those nodes, as if they were a load, because global/nonlocal is so scarce?Test Plan
Snapshot tests added/re-enabled.