[ty] Add 'remove unused ignore comment' code action#21582
Merged
Conversation
MichaReiser
added
server
MichaReiser
changed the title
MichaReiser
force-pushed
the
micha/add-ignore-action
branch
from
a40403a to
820ff0c
Compare
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
MichaReiser
force-pushed
the
micha/add-ignore-action
branch
from
820ff0c to
8850253
Compare
|
MichaReiser
changed the base branch from
main
to
micha/suppressions-diagnostic-guard
MichaReiser
force-pushed
the
micha/add-ignore-action
branch
2 times, most recently
from
ccfb4ef to
58b48c7
Compare
MichaReiser
commented
Nov 23, 2025
| [dependencies] | ||
| ruff_db = { workspace = true } | ||
| ruff_annotate_snippets = { workspace = true } | ||
| ruff_diagnostics = { workspace = true } |
Member
Author
There was a problem hiding this comment.
We should probably fold ruff_diagnostics into ruff_db. There's really not much in there but this seemed unrelated to this PR
Contributor
There was a problem hiding this comment.
I tried this and it ran into circular reference nastiness (stuff depends on ruff_diagnostics that ruff_db in turn depends on, I guess?). I opted to just pub use the relevant items in ruff_db.
MichaReiser
commented
Nov 23, 2025
Comment on lines
-637
to
-642
| let code = &self.source[*code_range]; | ||
| let range = if codes.len() == 1 { | ||
| comment.range | ||
| } else { | ||
| *code_range | ||
| }; |
Member
Author
There was a problem hiding this comment.
This is now handled by the unused suppression lint itself
MichaReiser
force-pushed
the
micha/add-ignore-action
branch
from
58b48c7 to
8c5b83e
Compare
MichaReiser
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
MichaReiser
force-pushed
the
micha/add-ignore-action
branch
from
8c5b83e to
88902c8
Compare
AlexWaygood
reviewed
Nov 23, 2025
crates/ty_python_semantic/resources/mdtest/suppressions/ty_ignore.md
Outdated
Show resolved
Hide resolved
AlexWaygood
reviewed
Nov 23, 2025
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Very excited to see this happen! A few nits from skimming
MichaReiser
force-pushed
the
micha/suppressions-diagnostic-guard
branch
from
b97e848 to
a67e6f2
Compare
MichaReiser
force-pushed
the
micha/add-ignore-action
branch
from
88902c8 to
5d5803c
Compare
MichaReiser
requested review from
Gankra
and removed request for
dcreager and
sharkdp
MichaReiser
force-pushed
the
micha/add-ignore-action
branch
from
b2cc26b to
7efe928
Compare
AlexWaygood
approved these changes
Nov 25, 2025
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
🚀
(Didn't review the ty_server code in depth)
Gankra
approved these changes
Nov 25, 2025
Contributor
Gankra
left a comment
Gankra
left a comment
There was a problem hiding this comment.
Rad, yeah this is exactly the minimal version that makes sense.
| [dependencies] | ||
| ruff_db = { workspace = true } | ||
| ruff_annotate_snippets = { workspace = true } | ||
| ruff_diagnostics = { workspace = true } |
Contributor
There was a problem hiding this comment.
I tried this and it ran into circular reference nastiness (stuff depends on ruff_diagnostics that ruff_db in turn depends on, I guess?). I opted to just pub use the relevant items in ruff_db.
carljm
added a commit
to mtshiba/ruff
that referenced
this pull request
Nov 25, 2025
* main: [ty] Implement `typing.override` (astral-sh#21627) [ty] Avoid expression reinference for diagnostics (astral-sh#21267) [ty] Improve autocomplete suppressions of keywords in variable bindings [ty] Only suggest completions based on text before the cursor Implement goto-definition and find-references for global/nonlocal statements (astral-sh#21616) [ty] Inlay Hint edit follow up (astral-sh#21621) [ty] Implement lsp support for string annotations (astral-sh#21577) [ty] Add 'remove unused ignore comment' code action (astral-sh#21582) [ty] Refactor `CheckSuppressionContext` to use `DiagnosticGuard` (astral-sh#21587) [ty] Improve several "Did you mean?" suggestions (astral-sh#21597) [ty] Add more and update existing projects in `ty_benchmark` (astral-sh#21536) [ty] fix ty playground initialization and vite optimization issues (astral-sh#21471)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a code action to remove unused ignore comments.
This PR also includes some infrastructure boilerplate to set up code actions in the editor:
snapshot-diagnosticsto render fixes--output-format=fullUnnecessarytag tounused-ignore-commentdiagnosticsThe same fix can be used on the CLI once we add
ty fixNote:
unused-ignore-commentis currently disabled by default.Screen.Recording.2025-11-22.at.22.36.26.mov