[ty] Add more random TypeDetails and tests by Gankra · Pull Request #21546 · astral-sh/ruff

Gankra · 2025-11-20T19:17:48Z

No description provided.

Gankra · 2025-11-20T19:19:27Z

crates/ty_python_semantic/src/types/display.rs

+                let mut f = f.with_detail(TypeDetail::Type(self.ty));
+                f.write_str("<class '")?;


This is theoretically useless because the span logic will prefer the inner class.display_with but this is effectively a fallback if it doesn't.

astral-sh-bot · 2025-11-20T19:19:50Z

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

Gankra · 2025-11-20T19:20:37Z

crates/ty_python_semantic/src/types/display.rs

+                SubclassOfInner::Dynamic(dynamic) => {
+                    f.with_detail(TypeDetail::Type(Type::SpecialForm(SpecialFormType::Type)))
+                        .write_str("type")?;
+                    f.write_char('[')?;
+                    write!(f, "{dynamic}")?;
+                    f.write_char(']')


Should this invoke the Any/Unknown special cases? (Should that logic be factored out?)

Should this invoke the Any/Unknown special cases?

I think so, yes!

Should that logic be factored out?

Sure!

in fact, maybe that logic should just be moved to Type::definition() in types.rs?

astral-sh-bot · 2025-11-20T19:21:18Z

`mypy_primer` results

Changes were detected when running on open source projects

scikit-build-core (https://github.com/scikit-build/scikit-build-core)
- src/scikit_build_core/build/wheel.py:98:20: error[no-matching-overload] No overload of bound method `__init__` matches arguments
- Found 44 diagnostics
+ Found 43 diagnostics

No memory usage changes detected ✅

AlexWaygood

Nice!

AlexWaygood · 2025-11-20T19:24:40Z

crates/ty_python_semantic/src/types/display.rs

+                    f.with_detail(TypeDetail::Type(Type::SpecialForm(SpecialFormType::Type)))
+                        .write_str("type")?;


I'm actually not totally sold that double-clicking on type in type[int] should take you anywhere, because type isn't a generic class in the same way as list[int] or dict[str, str]. Though it is true that all type[] types are instances of type

If we do want it to take you somewhere, though, it should take you to builtins.type rather than typing.Type, so that would be

Suggested change

f.with_detail(TypeDetail::Type(Type::SpecialForm(SpecialFormType::Type)))

.write_str("type")?;

f.with_detail(TypeDetail::Type(KnownClass::Type.to_class_literal(self.db)))

.write_str("type")?;

AlexWaygood · 2025-11-20T19:25:06Z

crates/ty_python_semantic/src/types/display.rs

                }
                SubclassOfInner::Class(ClassType::Generic(alias)) => {
-                    f.write_str("type[")?;
+                    f.with_detail(TypeDetail::Type(Type::SpecialForm(SpecialFormType::Type)))


same here

Suggested change

f.with_detail(TypeDetail::Type(Type::SpecialForm(SpecialFormType::Type)))

f.with_detail(TypeDetail::Type(KnownClass::Type.to_class_literal(self.db)))

AlexWaygood · 2025-11-20T19:25:33Z

crates/ty_python_semantic/src/types/display.rs

+                    f.write_char(']')
+                }
+                SubclassOfInner::Dynamic(dynamic) => {
+                    f.with_detail(TypeDetail::Type(Type::SpecialForm(SpecialFormType::Type)))


and here

Suggested change

f.with_detail(TypeDetail::Type(Type::SpecialForm(SpecialFormType::Type)))

f.with_detail(TypeDetail::Type(KnownClass::Type.to_class_literal(self.db)))

AlexWaygood · 2025-11-20T19:25:48Z

crates/ty_python_semantic/src/types/display.rs

+                SubclassOfInner::Dynamic(dynamic) => {
+                    f.with_detail(TypeDetail::Type(Type::SpecialForm(SpecialFormType::Type)))
+                        .write_str("type")?;
+                    f.write_char('[')?;
+                    write!(f, "{dynamic}")?;
+                    f.write_char(']')


Should this invoke the Any/Unknown special cases?

I think so, yes!

Should that logic be factored out?

Sure!

…d-typevar * origin/main: (24 commits) [ty] Remove brittle constraint set reveal tests (#21568) [`ruff`] Catch more dummy variable uses (`RUF052`) (#19799) [ty] Use the same snapshot handling as other tests (#21564) [ty] suppress autocomplete suggestions during variable binding (#21549) Set severity for non-rule diagnostics (#21559) [ty] Add `with_type` convenience to display code (#21563) [ty] Implement docstring rendering to markdown (#21550) [ty] Reduce indentation of `TypeInferenceBuilder::infer_attribute_load` (#21560) Bump 0.14.6 (#21558) [ty] Improve debug messages when imports fail (#21555) [ty] Add support for relative import completions [ty] Refactor detection of import statements for completions [ty] Use dedicated collector for completions [ty] Attach subdiagnostics to `unresolved-import` errors for relative imports as well as absolute imports (#21554) [ty] support PEP 613 type aliases (#21394) [ty] More low-hanging fruit for inlay hint goto-definition (#21548) [ty] implement `TypedDict` structural assignment (#21467) [ty] Add more random TypeDetails and tests (#21546) [ty] Add goto for `Unknown` when it appears in an inlay hint (#21545) [ty] Add type definitions for `Type::SpecialForm`s (#21544) ...

Add more random TypeDetails and tests

77c144a

Gankra requested review from AlexWaygood, MichaReiser, carljm, dcreager and sharkdp as code owners November 20, 2025 19:17

Gankra added server Related to the LSP server ty Multi-file analysis & type inference labels Nov 20, 2025

Gankra commented Nov 20, 2025

View reviewed changes

AlexWaygood approved these changes Nov 20, 2025

View reviewed changes

fixups

8c483a1

Gankra enabled auto-merge (squash) November 20, 2025 19:43

Gankra merged commit 1b28fc1 into main Nov 20, 2025
40 checks passed

Gankra deleted the gankra/more-click branch November 20, 2025 19:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[ty] Add more random TypeDetails and tests#21546

[ty] Add more random TypeDetails and tests#21546
Gankra merged 2 commits intomainfrom
gankra/more-click

Gankra commented Nov 20, 2025

Uh oh!

Gankra Nov 20, 2025

Uh oh!

astral-sh-bot bot commented Nov 20, 2025 •

edited

Loading

Uh oh!

Gankra Nov 20, 2025

Uh oh!

AlexWaygood Nov 20, 2025

Uh oh!

AlexWaygood Nov 20, 2025

Uh oh!

astral-sh-bot bot commented Nov 20, 2025 •

edited

Loading

Uh oh!

AlexWaygood left a comment

Uh oh!

AlexWaygood Nov 20, 2025

Uh oh!

AlexWaygood Nov 20, 2025

Uh oh!

AlexWaygood Nov 20, 2025

Uh oh!

AlexWaygood Nov 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		let mut f = f.with_detail(TypeDetail::Type(self.ty));
		f.write_str("<class '")?;

		f.with_detail(TypeDetail::Type(Type::SpecialForm(SpecialFormType::Type)))
		.write_str("type")?;

	f.with_detail(TypeDetail::Type(Type::SpecialForm(SpecialFormType::Type)))
	f.with_detail(TypeDetail::Type(KnownClass::Type.to_class_literal(self.db)))

Comments

Conversation

Gankra commented Nov 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

astral-sh-bot bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diagnostic diff on typing conformance tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

astral-sh-bot bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

astral-sh-bot bot commented Nov 20, 2025 •

edited

Loading

astral-sh-bot bot commented Nov 20, 2025 •

edited

Loading

`mypy_primer` results