[ty] Make special cases for UnionType slightly narrower#21276
Merged
AlexWaygood merged 1 commit intomainfrom Nov 6, 2025
Merged
[ty] Make special cases for UnionType slightly narrower#21276AlexWaygood merged 1 commit intomainfrom
UnionType slightly narrower#21276AlexWaygood merged 1 commit intomainfrom
Conversation
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Contributor
|
AlexWaygood
force-pushed
the
alex/fix-union-wildcards
branch
2 times, most recently
from
a1eaa77 to
91933c2
Compare
Contributor
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-type-form |
42 | 0 | 0 |
| Total | 42 | 0 | 0 |
Member
Author
|
Nearly all the new diagnostics are false positive due to things like |
AlexWaygood
requested review from
carljm,
dcreager and
sharkdp
as code owners
AlexWaygood
force-pushed
the
alex/fix-union-wildcards
branch
2 times, most recently
from
7e51bdf to
88344fb
Compare
AlexWaygood
force-pushed
the
alex/fix-union-wildcards
branch
from
88344fb to
8af56b7
Compare
sharkdp
approved these changes
Nov 6, 2025
Comment on lines
+8512
to
+8514
| Some(Type::KnownInstance(KnownInstanceType::UnionType( | ||
| UnionTypeInstance::new(self.db(), left_ty, right_ty), | ||
| ))) |
Contributor
There was a problem hiding this comment.
I'm slightly confused why we don't need the convert_none_type anymore?
carljm
added a commit
to MatthewMckee4/ruff
that referenced
this pull request
Nov 6, 2025
* main: (188 commits) [ty] Discover site-packages from the environment that ty is installed in (astral-sh#21286) [ty] Make special cases for `UnionType` slightly narrower (astral-sh#21276) Require ignore 0.4.24 in `Cargo.toml` (astral-sh#21292) [ty] Favour imported symbols over builtin symbols (astral-sh#21285) docs: revise Ruff setup instructions for Zed editor (astral-sh#20935) [ty] Update salsa (astral-sh#21281) [syntax-error]: no binding for nonlocal PLE0117 as a semantic syntax error (astral-sh#21032) [ty] Constraining a typevar with itself (possibly via union or intersection) (astral-sh#21273) [`ruff`] Fix false positives on starred arguments (`RUF057`) (astral-sh#21256) [ty] Simplify unions containing multiple type variables during inference (astral-sh#21275) [ty] Add `ty_server::Db` trait (astral-sh#21241) [ty] Refactor `Range` to/from `TextRange` conversion as prep for notebook support (astral-sh#21230) [ty] Fix playground crash when file name includes path separator (astral-sh#21151) [`refurb`] Fix false negative for underscores before sign in `Decimal` constructor (`FURB157`) (astral-sh#21190) [ty] Allow values of type `None` in type expressions (astral-sh#21263) Run codspeed benchmarks with `profiling` profile (astral-sh#21261) [ty] Update expected diagnostic count in benchmarks (astral-sh#21269) Avoid extra parentheses for long `match` patterns with `as` captures (astral-sh#21176) [ty] Update salsa (astral-sh#21265) [ty] `dict` is not assignable to `TypedDict` (astral-sh#21238) ...
dcreager
added a commit
that referenced
this pull request
Nov 7, 2025
* origin/main: Remove duplicate preview tests for `FURB101` and `FURB103` (#21303) [ty] Add support for `Literal`s in implicit type aliases (#21296) [ty] Add missing `heap_size` to `variance_of` queries (#21318) [`pyupgrade`] Fix false positive on relative imports from local `.builtins` module (`UP029`) (#21309) [ty] Make range/position conversions fallible (#21297) Bump 0.14.4 (#21306) Fix main by using `infer_expression` (#21299) [ty] Understand legacy and PEP 695 `ParamSpec` (#21139) [ty] Discover site-packages from the environment that ty is installed in (#21286) [ty] Make special cases for `UnionType` slightly narrower (#21276) Require ignore 0.4.24 in `Cargo.toml` (#21292) [ty] Favour imported symbols over builtin symbols (#21285) docs: revise Ruff setup instructions for Zed editor (#20935) [ty] Update salsa (#21281) [syntax-error]: no binding for nonlocal PLE0117 as a semantic syntax error (#21032)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes astral-sh/ty#1478