Skip to content

Comments

[ty] Avoid expression reinference for diagnostics#21267

Merged
carljm merged 1 commit intomainfrom
ibraheem/bidi-diagnostics
Nov 25, 2025
Merged

[ty] Avoid expression reinference for diagnostics#21267
carljm merged 1 commit intomainfrom
ibraheem/bidi-diagnostics

Conversation

@ibraheemdev
Copy link
Member

@ibraheemdev ibraheemdev commented Nov 3, 2025

Summary

We now use the type context for a lot of things, so re-inferring without type context actually makes diagnostics more confusing (in most cases).

@ibraheemdev ibraheemdev requested a review from carljm as a code owner November 3, 2025 21:40
@ibraheemdev ibraheemdev added the ty Multi-file analysis & type inference label Nov 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025 •
edited by astral-sh-bot bot
Loading

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025 •
edited by astral-sh-bot bot
Loading

mypy_primer results

Changes were detected when running on open source projects 
aioredis (https://github.com/aio-libs/aioredis)
- aioredis/client.py:3430:34: error[invalid-assignment] Object of type `tuple[KeysView[object], ValuesView[object]]` is not assignable to `Sequence[bytes | str | memoryview[int]] | AbstractSet[AnyKeyT@_zaggregate]`
+ aioredis/client.py:3430:34: error[invalid-assignment] Object of type `KeysView[object]` is not assignable to `Sequence[bytes | str | memoryview[int]] | AbstractSet[AnyKeyT@_zaggregate]`
- aioredis/client.py:3430:34: error[invalid-assignment] Object of type `tuple[KeysView[object], ValuesView[object]]` is not assignable to `ValuesView[int | float] | None`
+ aioredis/client.py:3430:34: error[invalid-assignment] Object of type `ValuesView[object]` is not assignable to `ValuesView[int | float] | None`
- aioredis/client.py:4114:55: error[invalid-assignment] Object of type `dict[Unknown, Any | None]` is not assignable to `dict[bytes | str | memoryview[int], (dict[str, str], /) -> Awaitable[None]]`
+ aioredis/client.py:4114:55: error[invalid-assignment] Object of type `dict[bytes | str | memoryview[int], Any | None]` is not assignable to `dict[bytes | str | memoryview[int], (dict[str, str], /) -> Awaitable[None]]`

pip (https://github.com/pypa/pip)
- src/pip/_vendor/pkg_resources/__init__.py:1120:33: error[invalid-argument-type] Argument to bound method `evaluate` is incorrect: Expected `dict[str, str] | None`, found `dict[Unknown | str, Unknown | str | None]`
+ src/pip/_vendor/pkg_resources/__init__.py:1120:33: error[invalid-argument-type] Argument to bound method `evaluate` is incorrect: Expected `dict[str, str] | None`, found `dict[str, str | None]`
- src/pip/_vendor/urllib3/util/ssl_.py:86:32: error[invalid-assignment] Object of type `tuple[Literal[16777216], Literal[33554432]]` is not assignable to `Literal[Options.OP_NO_SSLv2]`
+ src/pip/_vendor/urllib3/util/ssl_.py:86:32: error[invalid-assignment] Object of type `Literal[16777216]` is not assignable to `Literal[Options.OP_NO_SSLv2]`
- src/pip/_vendor/urllib3/util/ssl_.py:86:32: error[invalid-assignment] Object of type `tuple[Literal[16777216], Literal[33554432]]` is not assignable to `Literal[Options.OP_NO_SSLv3]`
+ src/pip/_vendor/urllib3/util/ssl_.py:86:32: error[invalid-assignment] Object of type `Literal[33554432]` is not assignable to `Literal[Options.OP_NO_SSLv3]`

spack (https://github.com/spack/spack)
- lib/spack/spack/bootstrap/core.py:233:25: error[invalid-assignment] Object of type `tuple[partial[Unknown], dict[Unknown, Unknown]]` is not assignable to `QueryInfo`
+ lib/spack/spack/bootstrap/core.py:233:25: error[invalid-assignment] Object of type `dict[Unknown, Unknown]` is not assignable to `QueryInfo`
- lib/spack/spack/bootstrap/core.py:246:25: error[invalid-assignment] Object of type `tuple[partial[Unknown], dict[Unknown, Unknown]]` is not assignable to `QueryInfo`
+ lib/spack/spack/bootstrap/core.py:246:25: error[invalid-assignment] Object of type `dict[Unknown, Unknown]` is not assignable to `QueryInfo`

aiortc (https://github.com/aiortc/aiortc)
- src/aiortc/contrib/signaling.py:44:19: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | str | None | int]` is not assignable to `dict[str, int | str]`
+ src/aiortc/contrib/signaling.py:44:19: error[invalid-assignment] Object of type `dict[str, int | str | None]` is not assignable to `dict[str, int | str]`

graphql-core (https://github.com/graphql-python/graphql-core)
- src/graphql/utilities/build_client_schema.py:262:81: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | ((scalar_introspection: IntrospectionScalarType) -> GraphQLScalarType) | ((object_introspection: IntrospectionObjectType) -> GraphQLObjectType) | ... omitted 4 union elements]` is not assignable to `dict[str, (IntrospectionScalarType | IntrospectionObjectType | IntrospectionInterfaceType | ... omitted 3 union elements, /) -> GraphQLNamedType]`
+ src/graphql/utilities/build_client_schema.py:262:81: error[invalid-assignment] Object of type `dict[str, ((IntrospectionScalarType | IntrospectionObjectType | IntrospectionInterfaceType | ... omitted 3 union elements, /) -> GraphQLNamedType) | ((scalar_introspection: IntrospectionScalarType) -> GraphQLScalarType) | ((object_introspection: IntrospectionObjectType) -> GraphQLObjectType) | ... omitted 4 union elements]` is not assignable to `dict[str, (IntrospectionScalarType | IntrospectionObjectType | IntrospectionInterfaceType | ... omitted 3 union elements, /) -> GraphQLNamedType]`
- tests/pyutils/test_boxed_awaitabe_or_value.py:29:45: error[invalid-assignment] Object of type `BoxedAwaitableOrValue[Future[Unknown]]` is not assignable to `BoxedAwaitableOrValue[int]`
+ tests/pyutils/test_boxed_awaitabe_or_value.py:29:45: error[invalid-assignment] Object of type `BoxedAwaitableOrValue[int | Future[Unknown]]` is not assignable to `BoxedAwaitableOrValue[int]`
- tests/pyutils/test_boxed_awaitabe_or_value.py:36:45: error[invalid-assignment] Object of type `BoxedAwaitableOrValue[CoroutineType[Any, Any, int]]` is not assignable to `BoxedAwaitableOrValue[int]`
+ tests/pyutils/test_boxed_awaitabe_or_value.py:36:45: error[invalid-assignment] Object of type `BoxedAwaitableOrValue[int | CoroutineType[Any, Any, int]]` is not assignable to `BoxedAwaitableOrValue[int]`
- tests/pyutils/test_boxed_awaitabe_or_value.py:41:51: error[invalid-assignment] Object of type `BoxedAwaitableOrValue[Future[Unknown]]` is not assignable to `BoxedAwaitableOrValue[list[int]]`
+ tests/pyutils/test_boxed_awaitabe_or_value.py:41:51: error[invalid-assignment] Object of type `BoxedAwaitableOrValue[list[int] | Future[Unknown]]` is not assignable to `BoxedAwaitableOrValue[list[int]]`
- tests/pyutils/test_boxed_awaitabe_or_value.py:56:45: error[invalid-assignment] Object of type `BoxedAwaitableOrValue[CoroutineType[Any, Any, int]]` is not assignable to `BoxedAwaitableOrValue[int]`
+ tests/pyutils/test_boxed_awaitabe_or_value.py:56:45: error[invalid-assignment] Object of type `BoxedAwaitableOrValue[int | CoroutineType[Any, Any, int]]` is not assignable to `BoxedAwaitableOrValue[int]`
- tests/type/test_definition.py:163:72: error[invalid-argument-type] Argument to function `parse_literal` is incorrect: Expected `ValueNode`, found `dict[Unknown | str, Unknown | str]`
+ tests/type/test_definition.py:163:72: error[invalid-argument-type] Argument to function `parse_literal` is incorrect: Expected `ValueNode`, found `dict[str, Any] & dict[Unknown | str, Unknown | str]`

paasta (https://github.com/yelp/paasta)
- paasta_tools/utils.py:595:45: error[invalid-assignment] Object of type `list[Unknown | dict[Unknown | str, Unknown | str]]` is not assignable to `list[DockerParameter]`
+ paasta_tools/utils.py:595:45: error[invalid-assignment] Object of type `list[DockerParameter | dict[Unknown | str, Unknown | str]]` is not assignable to `list[DockerParameter]`

pylint (https://github.com/pycqa/pylint)
- pylint/checkers/classes/class_checker.py:493:43: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | tuple[str, str, str] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]]]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
+ pylint/checkers/classes/class_checker.py:493:43: error[invalid-assignment] Object of type `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]]]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
- pylint/checkers/deprecated.py:37:71: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | tuple[str, str, str, dict[Unknown | str, Unknown | bool]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
- pylint/checkers/deprecated.py:46:68: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]] | bool]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
- pylint/checkers/deprecated.py:55:68: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]] | bool]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
- pylint/checkers/deprecated.py:64:70: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]] | bool]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
- pylint/checkers/deprecated.py:73:67: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]] | bool]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
- pylint/checkers/deprecated.py:82:71: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]] | bool]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
+ pylint/checkers/deprecated.py:37:71: error[invalid-assignment] Object of type `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | bool]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
+ pylint/checkers/deprecated.py:46:68: error[invalid-assignment] Object of type `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]] | bool]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
+ pylint/checkers/deprecated.py:55:68: error[invalid-assignment] Object of type `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]] | bool]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
+ pylint/checkers/deprecated.py:64:70: error[invalid-assignment] Object of type `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]] | bool]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
+ pylint/checkers/deprecated.py:73:67: error[invalid-assignment] Object of type `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]] | bool]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
+ pylint/checkers/deprecated.py:82:71: error[invalid-assignment] Object of type `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]] | bool]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
- pylint/checkers/exceptions.py:62:43: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | tuple[str, str, str] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]]]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
+ pylint/checkers/exceptions.py:62:43: error[invalid-assignment] Object of type `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]]]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
- pylint/checkers/format.py:54:43: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | tuple[str, str, str] | tuple[str, str, str, dict[Unknown | str, Unknown | str]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
+ pylint/checkers/format.py:54:43: error[invalid-assignment] Object of type `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | str]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
- pylint/checkers/imports.py:227:43: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]]]] | tuple[str, str, str]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
+ pylint/checkers/imports.py:227:43: error[invalid-assignment] Object of type `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]]]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
- pylint/checkers/stdlib.py:488:47: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | tuple[int, int]]] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]]]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
+ pylint/checkers/stdlib.py:488:47: error[invalid-assignment] Object of type `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | tuple[int, int]]] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]]]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
- pylint/checkers/typecheck.py:220:43: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]]]] | tuple[str, str, str]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
+ pylint/checkers/typecheck.py:220:43: error[invalid-assignment] Object of type `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]]]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
- pylint/checkers/variables.py:351:43: error[invalid-assignment] Object of type `dict[Unknown | str, Unknown | tuple[str, str, str] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]]]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`
+ pylint/checkers/variables.py:351:43: error[invalid-assignment] Object of type `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions] | tuple[str, str, str, dict[Unknown | str, Unknown | list[Unknown | tuple[str, str]]]]]` is not assignable to `dict[str, tuple[str, str, str] | tuple[str, str, str, ExtraMessageOptions]]`

alerta (https://github.com/alerta/alerta)
- alerta/auth/basic.py:31:48: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[Unknown | str | None]`
+ alerta/auth/basic.py:31:48: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[str | None]`
- alerta/auth/basic.py:85:48: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[Unknown | str | None]`
+ alerta/auth/basic.py:85:48: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[str | None]`
- alerta/auth/decorators.py:142:60: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[Unknown | str | None]`
+ alerta/auth/decorators.py:142:60: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[str | None]`
- alerta/auth/decorators.py:147:57: error[invalid-argument-type] Argument to function `get_customers` is incorrect: Expected `list[str]`, found `list[Unknown | str | None]`
+ alerta/auth/decorators.py:147:57: error[invalid-argument-type] Argument to function `get_customers` is incorrect: Expected `list[str]`, found `list[str | None]`
- alerta/auth/github.py:85:115: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[Unknown | str | None]`
+ alerta/auth/github.py:85:115: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[str | None]`
- alerta/auth/oidc.py:192:95: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[Unknown | str | None]`
+ alerta/auth/oidc.py:192:95: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[str | None]`
- alerta/auth/saml.py:100:98: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[Unknown | str | None]`
+ alerta/auth/saml.py:100:98: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[str | None]`
- alerta/views/users.py:33:48: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[Unknown | str | None]`
+ alerta/views/users.py:33:48: error[invalid-argument-type] Argument to function `not_authorized` is incorrect: Expected `list[str]`, found `list[str | None]`
- tests/test_scopes.py:81:71: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:81:71: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:82:71: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:82:71: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:83:71: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:83:71: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:85:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:85:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:86:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:86:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:87:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:87:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:89:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:89:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:90:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:90:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:92:59: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:92:59: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:93:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:93:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:94:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:94:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:95:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:95:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:96:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:96:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:97:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:97:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:99:62: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:99:62: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:100:62: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:100:62: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`
- tests/test_scopes.py:101:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[Unknown | str]`
+ tests/test_scopes.py:101:72: error[invalid-argument-type] Argument to bound method `is_in_scope` is incorrect: Expected `list[Scope]`, found `list[str | Unknown]`

scrapy (https://github.com/scrapy/scrapy)
- tests/test_downloadermiddleware_cookies.py:363:46: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `dict[str, str] | list[VerboseCookie] | None`, found `dict[Unknown | str, Unknown | bytes]`
+ tests/test_downloadermiddleware_cookies.py:363:46: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `dict[str, str] | list[VerboseCookie] | None`, found `dict[str, str | bytes] & dict[Unknown | str, Unknown | bytes]`
- tests/test_downloadermiddleware_cookies.py:368:46: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `dict[str, str] | list[VerboseCookie] | None`, found `dict[Unknown | str, Unknown | bytes]`
+ tests/test_downloadermiddleware_cookies.py:368:46: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `dict[str, str] | list[VerboseCookie] | None`, found `dict[str, str | bytes] & dict[Unknown | str, Unknown | bytes]`
- tests/test_downloadermiddleware_cookies.py:438:46: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `dict[str, str] | list[VerboseCookie] | None`, found `dict[Unknown | str, Unknown | bool]`
+ tests/test_downloadermiddleware_cookies.py:438:46: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `dict[str, str] | list[VerboseCookie] | None`, found `dict[str, str | bool] & dict[Unknown | str, Unknown | bool]`
- tests/test_downloadermiddleware_cookies.py:443:46: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `dict[str, str] | list[VerboseCookie] | None`, found `dict[Unknown | str, Unknown | float]`
+ tests/test_downloadermiddleware_cookies.py:443:46: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `dict[str, str] | list[VerboseCookie] | None`, found `dict[str, str | float] & dict[Unknown | str, Unknown | float]`
- tests/test_downloadermiddleware_cookies.py:448:46: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `dict[str, str] | list[VerboseCookie] | None`, found `dict[Unknown | str, Unknown | int]`
+ tests/test_downloadermiddleware_cookies.py:448:46: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `dict[str, str] | list[VerboseCookie] | None`, found `dict[str, str | int] & dict[Unknown | str, Unknown | int]`
- tests/test_http_request.py:667:58: error[invalid-argument-type] Argument to bound method `from_response` is incorrect: Expected `dict[str, Iterable[str]] | list[tuple[str, Iterable[str]]] | None`, found `dict[Unknown | str, Unknown | None]`
+ tests/test_http_request.py:667:58: error[invalid-argument-type] Argument to bound method `from_response` is incorrect: Expected `dict[str, Iterable[str]] | list[tuple[str, Iterable[str]]] | None`, found `dict[str, Iterable[str] | None] & dict[Unknown | str, Unknown | None]`
- tests/test_pipeline_files.py:368:28: error[invalid-assignment] Object of type `<class 'list'>` is not assignable to `list[str]`
+ tests/test_pipeline_files.py:368:28: error[invalid-assignment] Object of type `dataclasses.Field[list[str] | <class 'list'>]` is not assignable to `list[str]`
- tests/test_pipeline_files.py:369:35: error[invalid-assignment] Object of type `<class 'list'>` is not assignable to `list[dict[str, str]]`
+ tests/test_pipeline_files.py:369:35: error[invalid-assignment] Object of type `dataclasses.Field[list[dict[str, str]] | <class 'list'>]` is not assignable to `list[dict[str, str]]`
- tests/test_pipeline_files.py:371:35: error[invalid-assignment] Object of type `<class 'list'>` is not assignable to `list[str]`
+ tests/test_pipeline_files.py:371:35: error[invalid-assignment] Object of type `dataclasses.Field[list[str] | <class 'list'>]` is not assignable to `list[str]`
- tests/test_pipeline_files.py:372:42: error[invalid-assignment] Object of type `<class 'list'>` is not assignable to `list[dict[str, str]]`
+ tests/test_pipeline_files.py:372:42: error[invalid-assignment] Object of type `dataclasses.Field[list[dict[str, str]] | <class 'list'>]` is not assignable to `list[dict[str, str]]`
- tests/test_pipeline_images.py:332:29: error[invalid-assignment] Object of type `<class 'list'>` is not assignable to `list[str]`
+ tests/test_pipeline_images.py:332:29: error[invalid-assignment] Object of type `dataclasses.Field[list[str] | <class 'list'>]` is not assignable to `list[str]`
- tests/test_pipeline_images.py:333:36: error[invalid-assignment] Object of type `<class 'list'>` is not assignable to `list[dict[str, str]]`
+ tests/test_pipeline_images.py:333:36: error[invalid-assignment] Object of type `dataclasses.Field[list[dict[str, str]] | <class 'list'>]` is not assignable to `list[dict[str, str]]`
- tests/test_pipeline_images.py:335:36: error[invalid-assignment] Object of type `<class 'list'>` is not assignable to `list[str]`
+ tests/test_pipeline_images.py:335:36: error[invalid-assignment] Object of type `dataclasses.Field[list[str] | <class 'list'>]` is not assignable to `list[str]`
- tests/test_pipeline_images.py:336:43: error[invalid-assignment] Object of type `<class 'list'>` is not assignable to `list[dict[str, str]]`
+ tests/test_pipeline_images.py:336:43: error[invalid-assignment] Object of type `dataclasses.Field[list[dict[str, str]] | <class 'list'>]` is not assignable to `list[dict[str, str]]`
- tests/test_utils_request.py:377:13: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `dict[str, str] | list[VerboseCookie] | None`, found `list[Unknown | dict[Unknown | str, Unknown | str]]`
+ tests/test_utils_request.py:377:13: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `dict[str, str] | list[VerboseCookie] | None`, found `list[VerboseCookie | dict[Unknown | str, Unknown | str]] & list[Unknown | dict[Unknown | str, Unknown | str]]`

sockeye (https://github.com/awslabs/sockeye)
- test/unit/test_output_handler.py:46:43: error[invalid-argument-type] Argument is incorrect: Expected `list[list[int | float]] | None`, found `list[Unknown | float]`
+ test/unit/test_output_handler.py:46:43: error[invalid-argument-type] Argument is incorrect: Expected `list[list[int | float]] | None`, found `list[list[int | float] | float]`

ignite (https://github.com/pytorch/ignite)
- tests/ignite/handlers/test_base_logger.py:265:5: error[invalid-assignment] Object of type `list[CallableEventWithFilter | Literal["unknown"]]` is not assignable to attribute `_events` of type `list[CallableEventWithFilter]`
+ tests/ignite/handlers/test_base_logger.py:265:5: error[invalid-assignment] Object of type `list[CallableEventWithFilter | str]` is not assignable to attribute `_events` of type `list[CallableEventWithFilter]`
- tests/ignite/handlers/test_param_scheduler.py:349:25: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[ParamScheduler]`, found `list[Unknown | LinearCyclicalScheduler | int]`
+ tests/ignite/handlers/test_param_scheduler.py:349:25: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[ParamScheduler]`, found `list[ParamScheduler | int]`
- tests/ignite/handlers/test_param_scheduler.py:355:77: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[int]`, found `list[Unknown | int | float]`
+ tests/ignite/handlers/test_param_scheduler.py:355:77: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[int]`, found `list[int | float]`
- tests/ignite/handlers/test_param_scheduler.py:367:84: error[invalid-argument-type] Argument to bound method `simulate_values` is incorrect: Expected `list[str] | tuple[str] | None`, found `list[Unknown | int]`
+ tests/ignite/handlers/test_param_scheduler.py:367:84: error[invalid-argument-type] Argument to bound method `simulate_values` is incorrect: Expected `list[str] | tuple[str] | None`, found `list[str | int]`
- tests/ignite/handlers/test_param_scheduler.py:768:42: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[tuple[int, int | float]]`, found `list[Unknown | tuple[float]]`
+ tests/ignite/handlers/test_param_scheduler.py:768:42: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[tuple[int, int | float]]`, found `list[tuple[int, int | float] | tuple[float]]`
- tests/ignite/handlers/test_param_scheduler.py:771:42: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[tuple[int, int | float]]`, found `list[Unknown | tuple[int, float] | tuple[float]]`
+ tests/ignite/handlers/test_param_scheduler.py:771:42: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[tuple[int, int | float]]`, found `list[tuple[int, int | float] | tuple[float]]`
- tests/ignite/handlers/test_param_scheduler.py:777:42: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[tuple[int, int | float]]`, found `list[Unknown | tuple[float, int]]`
+ tests/ignite/handlers/test_param_scheduler.py:777:42: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[tuple[int, int | float]]`, found `list[tuple[int, int | float] | tuple[float, int]]`
- tests/ignite/handlers/test_param_scheduler.py:1171:29: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[ParamScheduler]`, found `list[Unknown | int]`
+ tests/ignite/handlers/test_param_scheduler.py:1171:29: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[ParamScheduler]`, found `list[ParamScheduler | int]`
- tests/ignite/handlers/test_param_scheduler.py:1174:29: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[ParamScheduler]`, found `list[Unknown | LinearCyclicalScheduler | str]`
+ tests/ignite/handlers/test_param_scheduler.py:1174:29: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[ParamScheduler]`, found `list[ParamScheduler | str]`
- tests/ignite/handlers/test_param_scheduler.py:1180:72: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[str] | None`, found `list[Unknown | int]`
+ tests/ignite/handlers/test_param_scheduler.py:1180:72: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[str] | None`, found `list[str | int]`
- tests/ignite/handlers/test_state_param_scheduler.py:151:76: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[tuple[int, int | float]]`, found `list[Unknown | tuple[float]]`
+ tests/ignite/handlers/test_state_param_scheduler.py:151:76: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[tuple[int, int | float]]`, found `list[tuple[int, int | float] | tuple[float]]`
- tests/ignite/handlers/test_state_param_scheduler.py:154:76: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[tuple[int, int | float]]`, found `list[Unknown | tuple[int, float] | tuple[float]]`
+ tests/ignite/handlers/test_state_param_scheduler.py:154:76: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[tuple[int, int | float]]`, found `list[tuple[int, int | float] | tuple[float]]`
- tests/ignite/handlers/test_state_param_scheduler.py:160:76: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[tuple[int, int | float]]`, found `list[Unknown | tuple[float, int]]`
+ tests/ignite/handlers/test_state_param_scheduler.py:160:76: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `list[tuple[int, int | float]]`, found `list[tuple[int, int | float] | tuple[float, int]]`

mkosi (https://github.com/systemd/mkosi)
- mkosi/qemu.py:343:33: error[invalid-assignment] Object of type `list[Unknown | Path | None | str]` is not assignable to `list[Path | str]`
+ mkosi/qemu.py:343:33: error[invalid-assignment] Object of type `list[Path | str | None]` is not assignable to `list[Path | str]`
- mkosi/sysupdate.py:70:33: error[invalid-assignment] Object of type `list[Unknown | Path | None | str]` is not assignable to `list[Path | str]`
+ mkosi/sysupdate.py:70:33: error[invalid-assignment] Object of type `list[Path | str | None]` is not assignable to `list[Path | str]`

mitmproxy (https://github.com/mitmproxy/mitmproxy)
- test/mitmproxy/addons/test_next_layer.py:492:13: error[invalid-argument-type] Argument is incorrect: Expected `list[type[Layer]]`, found `list[Unknown | <class 'HttpProxy'> | <class 'ClientTLSLayer'> | partial[Unknown]]`
+ test/mitmproxy/addons/test_next_layer.py:492:13: error[invalid-argument-type] Argument is incorrect: Expected `list[type[Layer]]`, found `list[type[Layer] | partial[Unknown]]`
- test/mitmproxy/addons/test_next_layer.py:524:13: error[invalid-argument-type] Argument is incorrect: Expected `list[type[Layer]]`, found `list[Unknown | <class 'HttpProxy'> | partial[Unknown]]`
+ test/mitmproxy/addons/test_next_layer.py:524:13: error[invalid-argument-type] Argument is incorrect: Expected `list[type[Layer]]`, found `list[type[Layer] | partial[Unknown]]`
- test/mitmproxy/addons/test_next_layer.py:536:13: error[invalid-argument-type] Argument is incorrect: Expected `list[type[Layer]]`, found `list[Unknown | <class 'HttpProxy'> | partial[Unknown]]`
+ test/mitmproxy/addons/test_next_layer.py:536:13: error[invalid-argument-type] Argument is incorrect: Expected `list[type[Layer]]`, found `list[type[Layer] | partial[Unknown]]`
- test/mitmproxy/addons/test_next_layer.py:554:13: error[invalid-argument-type] Argument is incorrect: Expected `list[type[Layer]]`, found `list[Unknown | <class 'HttpProxy'> | partial[Unknown] | <class 'ServerTLSLayer'> | <class 'ClientTLSLayer'>]`
+ test/mitmproxy/addons/test_next_layer.py:554:13: error[invalid-argument-type] Argument is incorrect: Expected `list[type[Layer]]`, found `list[type[Layer] | partial[Unknown]]`
- test/mitmproxy/addons/test_next_layer.py:575:13: error[invalid-argument-type] Argument is incorrect: Expected `list[type[Layer]]`, found `list[Unknown | <class 'HttpProxy'> | partial[Unknown]]`
+ test/mitmproxy/addons/test_next_layer.py:575:13: error[invalid-argument-type] Argument is incorrect: Expected `list[type[Layer]]`, found `list[type[Layer] | partial[Unknown]]`
- test/mitmproxy/addons/test_tlsconfig.py:476:13: error[invalid-assignment] Object of type `list[Layer | Literal[123]]` is not assignable to attribute `layers` of type `list[Layer]`
+ test/mitmproxy/addons/test_tlsconfig.py:476:13: error[invalid-assignment] Object of type `list[Layer | int]` is not assignable to attribute `layers` of type `list[Layer]`
- test/mitmproxy/proxy/layers/http/test_http.py:84:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:84:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `(HTTPFlow & Unknown) | (_Placeholder[HTTPFlow] & Unknown) | (HTTPFlow & _Placeholder[Unknown]) | (_Placeholder[HTTPFlow] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:92:35: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:92:35: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `(HTTPFlow & Unknown) | (_Placeholder[HTTPFlow] & Unknown) | (HTTPFlow & _Placeholder[Unknown]) | (_Placeholder[HTTPFlow] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:98:32: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:98:32: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `(NextLayer & Unknown) | (_Placeholder[NextLayer] & Unknown) | (NextLayer & _Placeholder[Unknown]) | (_Placeholder[NextLayer] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:150:33: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `Connection`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:150:33: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `Connection`, found `Connection | _Placeholder[Connection]`
- test/mitmproxy/proxy/layers/http/test_http.py:154:34: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:154:34: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `(NextLayer & Unknown) | (_Placeholder[NextLayer] & Unknown) | (NextLayer & _Placeholder[Unknown]) | (_Placeholder[NextLayer] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:198:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:198:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `(HTTPFlow & Unknown) | (_Placeholder[HTTPFlow] & Unknown) | (HTTPFlow & _Placeholder[Unknown]) | (_Placeholder[HTTPFlow] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:212:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:212:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `(HTTPFlow & Unknown) | (_Placeholder[HTTPFlow] & Unknown) | (HTTPFlow & _Placeholder[Unknown]) | (_Placeholder[HTTPFlow] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:272:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:272:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `(HTTPFlow & Unknown) | (_Placeholder[HTTPFlow] & Unknown) | (HTTPFlow & _Placeholder[Unknown]) | (_Placeholder[HTTPFlow] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:314:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:314:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `(HTTPFlow & Unknown) | (_Placeholder[HTTPFlow] & Unknown) | (HTTPFlow & _Placeholder[Unknown]) | (_Placeholder[HTTPFlow] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:318:35: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:318:35: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `(HTTPFlow & Unknown) | (_Placeholder[HTTPFlow] & Unknown) | (HTTPFlow & _Placeholder[Unknown]) | (_Placeholder[HTTPFlow] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:322:32: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:322:32: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `(NextLayer & Unknown) | (_Placeholder[NextLayer] & Unknown) | (NextLayer & _Placeholder[Unknown]) | (_Placeholder[NextLayer] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:846:36: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:846:36: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `(NextLayer & Unknown) | (_Placeholder[NextLayer] & Unknown) | (NextLayer & _Placeholder[Unknown]) | (_Placeholder[NextLayer] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:965:32: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:965:32: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `(NextLayer & Unknown) | (_Placeholder[NextLayer] & Unknown) | (NextLayer & _Placeholder[Unknown]) | (_Placeholder[NextLayer] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:1029:37: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:1029:37: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `(NextLayer & Unknown) | (_Placeholder[NextLayer] & Unknown) | (NextLayer & _Placeholder[Unknown]) | (_Placeholder[NextLayer] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:1296:32: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:1296:32: error[invalid-argument-type] Argument is incorrect: Expected `NextLayer`, found `(NextLayer & Unknown) | (_Placeholder[NextLayer] & Unknown) | (NextLayer & _Placeholder[Unknown]) | (_Placeholder[NextLayer] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:1454:41: error[invalid-argument-type] Argument is incorrect: Expected `TCPFlow`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:1454:41: error[invalid-argument-type] Argument is incorrect: Expected `TCPFlow`, found `(TCPFlow & Unknown) | (_Placeholder[TCPFlow] & Unknown) | (TCPFlow & _Placeholder[Unknown]) | (_Placeholder[TCPFlow] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:1641:27: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `Connection`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:1641:27: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `Connection`, found `Connection | _Placeholder[Connection]`
- test/mitmproxy/proxy/layers/http/test_http.py:1749:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:1749:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `(HTTPFlow & Unknown) | (_Placeholder[HTTPFlow] & Unknown) | (HTTPFlow & _Placeholder[Unknown]) | (_Placeholder[HTTPFlow] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:1753:35: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:1753:35: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `(HTTPFlow & Unknown) | (_Placeholder[HTTPFlow] & Unknown) | (HTTPFlow & _Placeholder[Unknown]) | (_Placeholder[HTTPFlow] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:1794:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:1794:33: error[invalid-argument-type] Argument is incorrect: Expected `HTTPFlow`, found `(HTTPFlow & Unknown) | (_Placeholder[HTTPFlow] & Unknown) | (HTTPFlow & _Placeholder[Unknown]) | (_Placeholder[HTTPFlow] & _Placeholder[Unknown])`
- test/mitmproxy/proxy/layers/http/test_http.py:1796:27: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `Connection`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:1796:27: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `Connection`, found `Connection | _Placeholder[Connection]`
- test/mitmproxy/proxy/layers/http/test_http.py:1838:27: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `Connection`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http.py:1838:27: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `Connection`, found `Connection | _Placeholder[Connection]`
- test/mitmproxy/proxy/layers/http/test_http1.py:59:28: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `HttpEvent`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http1.py:59:28: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `HttpEvent`, found `HttpEvent | _Placeholder[HttpEvent]`
- test/mitmproxy/proxy/layers/http/test_http1.py:81:28: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `HttpEvent`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http1.py:81:28: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `HttpEvent`, found `HttpEvent | _Placeholder[HttpEvent]`
- test/mitmproxy/proxy/layers/http/test_http1.py:104:28: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `HttpEvent`, found `Unknown | _Placeholder[Unknown]`
+ test/mitmproxy/proxy/layers/http/test_http1.py:104:28: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `HttpEvent`, found `HttpEvent | _Placeholder[HttpEvent]`
- test/mitmproxy/proxy/layers/http/test_http1.py:110:28: error[invalid-argument-type] Argument to bound method `__init__` is incorrect: Expected `HttpEvent`, found `Unknown | _P

... (truncated 560 lines) ...

No memory usage changes detected ✅

@ibraheemdev
Copy link
Member Author

ibraheemdev commented Nov 3, 2025

I may have underestimated the size of those intersection types...

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

ecosystem-analyzer results

Lint rule Added Removed Changed
invalid-argument-type 0 0 211
invalid-assignment 0 0 37
Total 0 0 248

Full report with detailed diff (timing results)

@ibraheemdev ibraheemdev mentioned this pull request Nov 6, 2025
Merged
@MichaReiser
Copy link
Member

MichaReiser commented Nov 10, 2025

Can you take a look at the failing mdtest

@ibraheemdev ibraheemdev mentioned this pull request Nov 21, 2025
Closed
@carljm
Copy link
Contributor

carljm commented Nov 21, 2025

@ibraheemdev Not sure how much work is required to get this ready -- it has some failing mdtests (and now some conflicts), but if it's not a lot, it would make sense to get it landed for the beta

@ibraheemdev
Copy link
Member Author

ibraheemdev commented Nov 21, 2025

CI was failing spuriously because of an apparent non-determinism in intersection type ordering. I suspect that was because of the ad-hoc TypedDict assignability special cases, which should be resolved now after a rebase.

@carljm
Copy link
Contributor

carljm commented Nov 22, 2025

which should be resolved now after a rebase

Not sure if you did a rebase, but doesn't look like it was pushed?

@ibraheemdev ibraheemdev force-pushed the ibraheem/bidi-diagnostics branch from 9fe1f3c to beeb48b Compare November 22, 2025 01:44
@ibraheemdev
Copy link
Member Author

ibraheemdev commented Nov 22, 2025 •
edited
Loading

Hmm, looks like the problem is still there. It seems perhaps to not me non-deterministic but just platform specific? The tests pass locally on my machine.

@carljm
Copy link
Contributor

carljm commented Nov 24, 2025

Hmm, that's unfortunate! I'm assuming this is in your court to look further into the cause of those platform-specific failures, when you have a chance, but ping if you could use another pair of eyes on it

@ibraheemdev ibraheemdev force-pushed the ibraheem/bidi-diagnostics branch from beeb48b to 87bb2f3 Compare November 25, 2025 02:32
@ibraheemdev
Copy link
Member Author

ibraheemdev commented Nov 25, 2025 •
edited
Loading

I rebased again as well as updated my local rustc version, and the test results have changed locally (not sure which of those caused it), so hopefully the issue is resolved.

The diagnostics in cases where we perform multi-inference are not great -- the intersected types can be quite large, despite most of the elements typically being irrelevant. However, our current solution of reinference can lead to an assignable type being outputted as part of an invalid-assignment error, so I think we should still merge this and work on improving those diagnostics over time.

@ibraheemdev ibraheemdev force-pushed the ibraheem/bidi-diagnostics branch from 87bb2f3 to d209542 Compare November 25, 2025 02:40
@carljm
Copy link
Contributor

carljm commented Nov 25, 2025

Yes, the test failures repro for me:


failures:

---- mdtest__bidirectional stdout ----

bidirectional.md - Bidirectional type i… - Class constructor pa… (f53c702724d63166)

  crates/ty_python_semantic/resources/mdtest/bidirectional.md:273 unmatched assertion: error: [invalid-argument-type] "Argument to function `__new__` is incorrect: Expected `list[int | str]`, found `list[int | str | list[Unknown]] & list[int | None | list[Unknown]] & list[list[Unknown]]`"
  crates/ty_python_semantic/resources/mdtest/bidirectional.md:273 unmatched assertion: error: [invalid-argument-type] "Argument to bound method `__init__` is incorrect: Expected `list[int | None]`, found `list[int | str | list[Unknown]] & list[int | None | list[Unknown]] & list[list[Unknown]]`"
  crates/ty_python_semantic/resources/mdtest/bidirectional.md:273 unexpected error: 3 [invalid-argument-type] "Argument to function `__new__` is incorrect: Expected `list[int | str]`, found `list[int | None | list[Unknown]] & list[int | str | list[Unknown]] & list[list[Unknown]]`"
  crates/ty_python_semantic/resources/mdtest/bidirectional.md:273 unexpected error: 3 [invalid-argument-type] "Argument to bound method `__init__` is incorrect: Expected `list[int | None]`, found `list[int | None | list[Unknown]] & list[int | str | list[Unknown]] & list[list[Unknown]]`"

To rerun this specific test, set the environment variable: MDTEST_TEST_FILTER='bidirectional.md - Bidirectional type i… - Class constructor pa… (f53c702724d63166)'
MDTEST_TEST_FILTER='bidirectional.md - Bidirectional type i… - Class constructor pa… (f53c702724d63166)' cargo test -p ty_python_semantic --test mdtest -- mdtest__bidirectional

@ibraheemdev
Copy link
Member Author

ibraheemdev commented Nov 25, 2025

Sorry, I had forgotten to commit the changes after the last rebase. CI should be passing now.

carljm
carljm approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Spot-checked the ecosystem and I agree, in the vast majority of cases this gives a better diagnostic. Thank you!

@carljm carljm merged commit 294f863 into main Nov 25, 2025
41 checks passed
@carljm carljm deleted the ibraheem/bidi-diagnostics branch November 25, 2025 17:24
carljm added a commit to mtshiba/ruff that referenced this pull request Nov 25, 2025
@carljm
Merge branch 'main' into recursive-inference
cbdc04f 
* main:
  [ty] Implement `typing.override` (astral-sh#21627)
  [ty] Avoid expression reinference for diagnostics (astral-sh#21267)
  [ty] Improve autocomplete suppressions of keywords in variable bindings
  [ty] Only suggest completions based on text before the cursor
  Implement goto-definition and find-references for global/nonlocal statements (astral-sh#21616)
  [ty] Inlay Hint edit follow up (astral-sh#21621)
  [ty] Implement lsp support for string annotations (astral-sh#21577)
  [ty] Add 'remove unused ignore comment' code action (astral-sh#21582)
  [ty] Refactor `CheckSuppressionContext` to use `DiagnosticGuard` (astral-sh#21587)
  [ty] Improve several "Did you mean?" suggestions (astral-sh#21597)
  [ty] Add more and update existing projects in `ty_benchmark` (astral-sh#21536)
  [ty] fix ty playground initialization and vite optimization issues (astral-sh#21471)
@AlexWaygood AlexWaygood mentioned this pull request Nov 26, 2025
Merged
@electronick1 electronick1 mentioned this pull request Jan 17, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp is a code owner

@dcreager dcreager Awaiting requested review from dcreager dcreager is a code owner

Assignees

No one assigned

Labels

ecosystem-analyzer ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ibraheemdev @MichaReiser @carljm @AlexWaygood