[ty] Rename inner query for better debugging experience#21106
Merged
MichaReiser merged 1 commit intomainfrom Oct 28, 2025
Merged
[ty] Rename inner query for better debugging experience#21106MichaReiser merged 1 commit intomainfrom
inner query for better debugging experience#21106MichaReiser merged 1 commit intomainfrom
Conversation
MichaReiser
requested review from
AlexWaygood,
dcreager and
sharkdp
as code owners
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Contributor
|
dcreager
added a commit
that referenced
this pull request
Oct 28, 2025
…l-constraint-sets
* dcreager/refactor-constraint-mdtests: (60 commits)
add static_asserts
move all reveal diagnostics to separate line
add more gradual tests
better comment
restructure a bit
better names/comments
simplify before implication
two typevars!
mdformat
rename mdtest
move is_subtype_of_given into ConstraintSet
move where we grab these
add ConstraintSet.{always,never}
move range_constraint into ConstraintSet class
[ty] Rename `inner` query for better debugging experience (#21106)
[ty] Add new "constraint implication" typing relation (#21010)
[semantic error tests]: refactor semantic error tests to separate files (#20926)
Respect `--output-format` with `--watch` (#21097)
[`pyflakes`] Revert to stable behavior if imports for module lie in alternate branches for `F401` (#20878)
Fix finding keyword range for clause header after statement ending with semicolon (#21067)
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Using an unspecific name like
innermakes it difficult to find the problematic query if Salsa panics because the cycle head iterated too many times, or if any other invariant isn't true.This specific instance came up on #20566 where the Salsa panic only referred to
inner.This PR renames the
innerfunction to use a longer name so that the query's debug name is more self explanatory ;)Test Plan
The panic message now renders as
Cycle recovery function for infer_definition_types(Id(a42f)) introduced a cycle, depending on is_equivalent_to_object_inner(Id(8007)). This is not allowed.whichis more actionable.