[ty] Avoid duplicate diagnostics during multi-inference of standalone expressions#21056
Merged
ibraheemdev merged 1 commit intomainfrom Oct 24, 2025
Merged
[ty] Avoid duplicate diagnostics during multi-inference of standalone expressions#21056ibraheemdev merged 1 commit intomainfrom
ibraheemdev merged 1 commit intomainfrom
Conversation
ibraheemdev
requested review from
AlexWaygood,
carljm and
sharkdp
as code owners
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Contributor
|
ibraheemdev
force-pushed
the
ibraheem/duplicate-diagnostics
branch
from
c985989 to
c4bc093
Compare
Contributor
|
MichaReiser
approved these changes
Oct 24, 2025
MichaReiser
reviewed
Oct 24, 2025
|
|
||
| pub(crate) fn extend(&mut self, other: &TypeCheckDiagnostics) { | ||
| self.diagnostics.get_mut().extend(other); | ||
| if !self.is_in_multi_inference() { |
Member
There was a problem hiding this comment.
Should it be the other way where we don't extend self if other is a multi inference context?
Member
There was a problem hiding this comment.
Okay, I think I figured it out. other is guaranteed to be empty if it is a multi_inference region. That's why we only have to check self
Member
Author
There was a problem hiding this comment.
Right, the issue is that if other was created using a different context (e.g. because it was executed as a salsa query), we still want to respect to context of self.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves astral-sh/ty#1428.