[syntax-error]: no binding for nonlocal PLE0117 as a semantic syntax error by 11happy · Pull Request #21032 · astral-sh/ruff

11happy · 2025-10-22T17:10:45Z

Summary

This PR ports PLE0117 as a semantic syntax error.

Test Plan

Tests previously written

Signed-off-by: 11happy <[email protected]>

github-actions · 2025-11-02T03:17:32Z

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

github-actions · 2025-11-02T03:18:31Z

`mypy_primer` results

No ecosystem changes detected ✅
No memory usage changes detected ✅

Signed-off-by: 11happy <[email protected]>

11happy · 2025-11-02T04:02:48Z

@ntBre its ready for review : )

github-actions · 2025-11-02T04:03:42Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

ntBre

Thanks! This looks good overall, I just had a few small suggestions.

crates/ruff_python_parser/src/semantic_errors.rs

ntBre · 2025-11-03T20:07:49Z

crates/ruff_python_parser/src/semantic_errors.rs

+
+                // test_ok nonlocal_declaration_at_module_level
+                // def _():
+                //     nonlocal x


I'd probably revert this change since it just moves the test down, right?

crates/ruff_python_parser/src/parser/statement.rs

crates/ruff_linter/src/checkers/ast/mod.rs

Co-authored-by: Brent Westbrook <[email protected]>

Signed-off-by: 11happy <[email protected]>

crates/ty_python_semantic/src/semantic_index/builder.rs

ntBre

Thanks! I just pushed a couple of commits removing the unrelated snapshot removal and updating the helper method's docstring. I also added a comment to the ty version of has_nonlocal_binding since we already check for this syntax error in ty here:

ruff/crates/ty_python_semantic/src/types/infer/builder.rs

Lines 5395 to 5404 in ca7ca34

    
           // There's no matching binding in an enclosing scope. This `nonlocal` statement is 
        
           // invalid. 
        
           if let Some(builder) = self 
        
               .context 
        
               .report_diagnostic(DiagnosticId::InvalidSyntax, Severity::Error) 
        
           { 
        
               builder 
        
                   .into_diagnostic(format_args!("no binding for nonlocal `{name}` found")) 
        
                   .annotate(Annotation::primary(self.context.span(*range))); 
        
           }

Thanks @AlexWaygood for pointing that out!

(Ideally we'd use the SemanticSyntaxErrorKind here too, but I didn't see a great way to do that immediately. We'd need another helper like InferContext::report_diagnostic)

Co-authored-by: Alex Waygood <[email protected]>

* main: (188 commits) [ty] Discover site-packages from the environment that ty is installed in (astral-sh#21286) [ty] Make special cases for `UnionType` slightly narrower (astral-sh#21276) Require ignore 0.4.24 in `Cargo.toml` (astral-sh#21292) [ty] Favour imported symbols over builtin symbols (astral-sh#21285) docs: revise Ruff setup instructions for Zed editor (astral-sh#20935) [ty] Update salsa (astral-sh#21281) [syntax-error]: no binding for nonlocal PLE0117 as a semantic syntax error (astral-sh#21032) [ty] Constraining a typevar with itself (possibly via union or intersection) (astral-sh#21273) [`ruff`] Fix false positives on starred arguments (`RUF057`) (astral-sh#21256) [ty] Simplify unions containing multiple type variables during inference (astral-sh#21275) [ty] Add `ty_server::Db` trait (astral-sh#21241) [ty] Refactor `Range` to/from `TextRange` conversion as prep for notebook support (astral-sh#21230) [ty] Fix playground crash when file name includes path separator (astral-sh#21151) [`refurb`] Fix false negative for underscores before sign in `Decimal` constructor (`FURB157`) (astral-sh#21190) [ty] Allow values of type `None` in type expressions (astral-sh#21263) Run codspeed benchmarks with `profiling` profile (astral-sh#21261) [ty] Update expected diagnostic count in benchmarks (astral-sh#21269) Avoid extra parentheses for long `match` patterns with `as` captures (astral-sh#21176) [ty] Update salsa (astral-sh#21265) [ty] `dict` is not assignable to `TypedDict` (astral-sh#21238) ...

* origin/main: Remove duplicate preview tests for `FURB101` and `FURB103` (#21303) [ty] Add support for `Literal`s in implicit type aliases (#21296) [ty] Add missing `heap_size` to `variance_of` queries (#21318) [`pyupgrade`] Fix false positive on relative imports from local `.builtins` module (`UP029`) (#21309) [ty] Make range/position conversions fallible (#21297) Bump 0.14.4 (#21306) Fix main by using `infer_expression` (#21299) [ty] Understand legacy and PEP 695 `ParamSpec` (#21139) [ty] Discover site-packages from the environment that ty is installed in (#21286) [ty] Make special cases for `UnionType` slightly narrower (#21276) Require ignore 0.4.24 in `Cargo.toml` (#21292) [ty] Favour imported symbols over builtin symbols (#21285) docs: revise Ruff setup instructions for Zed editor (#20935) [ty] Update salsa (#21281) [syntax-error]: no binding for nonlocal PLE0117 as a semantic syntax error (#21032)

feat: port PLE0117 as a semantic syntax error

5a2828c

Signed-off-by: 11happy <[email protected]>

11happy mentioned this pull request Oct 22, 2025

[syntax-errors] Remaining syntax errors raised by the compiler #17412

Open

14 tasks

chore: fix build errors

716550f

Signed-off-by: 11happy <[email protected]>

11happy marked this pull request as ready for review November 2, 2025 03:15

11happy requested review from AlexWaygood, MichaReiser, carljm, dcreager, dhruvmanila and sharkdp as code owners November 2, 2025 03:15

11happy added 2 commits November 2, 2025 08:56

chore: intitialise with dummy range for nonlocal

fa639a4

Signed-off-by: 11happy <[email protected]>

test: fix build error

43aba71

Signed-off-by: 11happy <[email protected]>

MichaReiser removed request for AlexWaygood, carljm, dcreager, dhruvmanila and sharkdp November 3, 2025 14:46

ntBre reviewed Nov 3, 2025

View reviewed changes

ntBre added the internal An internal refactor or improvement label Nov 3, 2025

11happy and others added 7 commits November 5, 2025 17:18

Update crates/ruff_python_parser/src/semantic_errors.rs

f3de238

Co-authored-by: Brent Westbrook <[email protected]>

refactor: convert function signature to bool

106a35e

Signed-off-by: 11happy <[email protected]>

chore: add whitespace & remove unreferenced snapshots

2d96fc2

Signed-off-by: 11happy <[email protected]>

remove snap

8622706

Signed-off-by: 11happy <[email protected]>

revert snapshot removal

bc215ed

update docs

d233d8c

group has_nonlocal_binding with global and add a comment

ca7ca34

AlexWaygood reviewed Nov 5, 2025

View reviewed changes

crates/ty_python_semantic/src/semantic_index/builder.rs Outdated Show resolved Hide resolved

ntBre approved these changes Nov 5, 2025

View reviewed changes

Update crates/ty_python_semantic/src/semantic_index/builder.rs

4a7c4d0

Co-authored-by: Alex Waygood <[email protected]>

ntBre enabled auto-merge (squash) November 5, 2025 19:09

ntBre merged commit cddc0fe into astral-sh:main Nov 5, 2025
40 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[syntax-error]: no binding for nonlocal PLE0117 as a semantic syntax error#21032

[syntax-error]: no binding for nonlocal PLE0117 as a semantic syntax error#21032
ntBre merged 12 commits intoastral-sh:mainfrom
11happy:PLE0117

11happy commented Oct 22, 2025

Uh oh!

github-actions bot commented Nov 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 2, 2025 •

edited

Loading

Uh oh!

11happy commented Nov 2, 2025

Uh oh!

github-actions bot commented Nov 2, 2025 •

edited

Loading

Uh oh!

ntBre left a comment

Uh oh!

Uh oh!

ntBre Nov 3, 2025

Uh oh!

11happy Nov 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ntBre left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// There's no matching binding in an enclosing scope. This `nonlocal` statement is
	// invalid.
	if let Some(builder) = self
	.context
	.report_diagnostic(DiagnosticId::InvalidSyntax, Severity::Error)
	{
	builder
	.into_diagnostic(format_args!("no binding for nonlocal `{name}` found"))
	.annotate(Annotation::primary(self.context.span(*range)));
	}

Comments

Conversation

11happy commented Oct 22, 2025

Summary

Test Plan

Uh oh!

github-actions bot commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diagnostic diff on typing conformance tests

Uh oh!

github-actions bot commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

11happy commented Nov 2, 2025

Uh oh!

github-actions bot commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Formatter (stable)

Formatter (preview)

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ntBre Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

11happy Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Nov 2, 2025 •

edited

Loading

github-actions bot commented Nov 2, 2025 •

edited

Loading

`mypy_primer` results

github-actions bot commented Nov 2, 2025 •

edited

Loading

`ruff-ecosystem` results