[ty] Add capabilities check for clear_diagnostics#20989
Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom Oct 20, 2025
Merged
[ty] Add capabilities check for clear_diagnostics#20989MichaReiser merged 1 commit intoastral-sh:mainfrom
ty] Add capabilities check for clear_diagnostics#20989MichaReiser merged 1 commit intoastral-sh:mainfrom
Conversation
TaKO8Ki
requested review from
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
TaKO8Ki
commented
Oct 20, 2025
Comment on lines
+124
to
+126
| if session.client_capabilities().supports_pull_diagnostics() { | ||
| return; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The same handling as:
ruff/crates/ty_server/src/server/api/diagnostics.rs
Lines 147 to 149 in de9ecd9
MichaReiser
added
server
Member
|
Would you mind testing this change with VS code? Specifically, that the diagnostics "disappear" after closing the corresponding file. |
TaKO8Ki
force-pushed
the
capabilities-check-for-clear_diagnostics
branch
from
de9ecd9 to
f0f51e7
Compare
Contributor
Author
|
@MichaReiser I have confirmed it and uploaded a GIF. |
Contributor
Author
|
Are the self hosted runners unstable now? |
Member
|
Yeah, they're affected by the AWS outage https://status.depot.dev/ |
auto-merge was automatically disabled
October 20, 2025 17:20
Head branch was pushed to by a user without write access
TaKO8Ki
force-pushed
the
capabilities-check-for-clear_diagnostics
branch
from
f0f51e7 to
7ac999a
Compare
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20784
Test Plan
I have tested it with VSCode.