[ty] Treat functions, methods, and dynamic types as function-like `Callable`s by sharkdp · Pull Request #20842 · astral-sh/ruff

sharkdp · 2025-10-13T12:21:17Z

Summary

Treat functions, methods, and dynamic types as function-like Callables

closes astral-sh/ty#1342
closes astral-sh/ty#1344

Ecosystem analysis

All removed diagnostics look like cases of astral-sh/ty#1344

Test Plan

Added regression test

github-actions · 2025-10-13T12:23:23Z

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

github-actions · 2025-10-13T12:24:17Z

`mypy_primer` results

Changes were detected when running on open source projects

attrs (https://github.com/python-attrs/attrs)
- src/attr/validators.py:175:31: error[unresolved-attribute] Type `(Overload[(pattern: str | Pattern[str], string: str, flags: Unknown = int) -> Match[str] | None, (pattern: bytes | Pattern[bytes], string: @Todo, flags: Unknown = int) -> Match[bytes] | None]) & ~AlwaysFalsy` has no attribute `__name__`
- tests/test_validators.py:870:13: warning[possibly-missing-attribute] Attribute `__name__` on type `Unknown | ((val: _T@lt) -> @Todo) | ((val: _T@le) -> @Todo) | ((val: _T@ge) -> @Todo) | ((val: _T@gt) -> @Todo)` may be missing
- Found 561 diagnostics
+ Found 559 diagnostics

spack (https://github.com/spack/spack)
- lib/spack/spack/vendor/attr/validators.py:186:31: error[unresolved-attribute] Type `(Overload[(pattern: str | Pattern[str], string: str, flags: Unknown = int) -> Match[str] | None, (pattern: bytes | Pattern[bytes], string: @Todo, flags: Unknown = int) -> Match[bytes] | None]) & ~AlwaysFalsy` has no attribute `__name__`
- Found 7521 diagnostics
+ Found 7520 diagnostics

mitmproxy (https://github.com/mitmproxy/mitmproxy)
- examples/contrib/block_dns_over_https.py:357:19: warning[possibly-missing-attribute] Attribute `__name__` on type `Unknown | ((flow) -> Unknown)` may be missing
- Found 1843 diagnostics
+ Found 1842 diagnostics

vision (https://github.com/pytorch/vision)
- test/test_transforms_v2.py:6756:40: warning[possibly-missing-attribute] Attribute `__name__` on type `Unknown | ((inpt: Unknown) -> Unknown) | ((inpt: Unknown) -> int) | ((pic, mode=None) -> Unknown) | ((inpt: Unknown, displacement: Unknown, interpolation: InterpolationMode | int = InterpolationMode, fill: @Todo = None) -> Unknown)` may be missing
- Found 1482 diagnostics
+ Found 1481 diagnostics

openlibrary (https://github.com/internetarchive/openlibrary)
- openlibrary/records/driver.py:61:36: warning[possibly-missing-attribute] Attribute `__name__` on type `Unknown | ((params) -> Unknown)` may be missing
- Found 849 diagnostics
+ Found 848 diagnostics

jax (https://github.com/google/jax)
- jax/experimental/jax2tf/tests/primitives_test.py:146:30: warning[possibly-missing-attribute] Attribute `__name__` on type `Unknown | ((x: @Todo, y: @Todo, /) -> Array)` may be missing
- Found 2427 diagnostics
+ Found 2426 diagnostics

sympy (https://github.com/sympy/sympy)
- sympy/benchmarks/bench_symbench.py:134:31: warning[possibly-missing-attribute] Attribute `__name__` on type `Unknown | (() -> Unknown)` may be missing
- Found 14028 diagnostics
+ Found 14027 diagnostics

materialize (https://github.com/MaterializeInc/materialize)
- test/aws/mzcompose.py:109:34: warning[possibly-missing-attribute] Attribute `__name__` on type `Unknown | ((c: Unknown, ctx: TestContext) -> Unknown)` may be missing
- Found 3387 diagnostics
+ Found 3386 diagnostics

scipy (https://github.com/scipy/scipy)
- scipy/optimize/tests/test_zeros.py:539:43: warning[possibly-missing-attribute] Attribute `__name__` on type `Unknown | ((f, a, b, args=tuple[()], xtol=float, rtol=Unknown, maxiter=int, full_output=bool, disp=bool) -> Unknown)` may be missing
- scipy/signal/tests/test_filter_design.py:4131:16: warning[possibly-missing-attribute] Attribute `__name__` on type `Unknown | ((N, Wn, btype=str, analog=bool, output=str, norm=str, fs=None) -> Unknown) | ((N, Wn, btype=str, analog=bool, output=str, fs=None) -> Unknown) | ... omitted 3 union elements` may be missing
- scipy/signal/tests/test_windows.py:798:25: warning[possibly-missing-attribute] Attribute `__name__` on type `Unknown | ((M, *, sym=bool, xp=None, device=None) -> Unknown) | ((M, at, sym=bool, *, xp=None, device=None) -> Unknown) | ... omitted 6 union elements` may be missing
- scipy/sparse/_base.py:676:55: warning[possibly-missing-attribute] Attribute `__name__` on type `Unknown | ((a: @Todo, b: @Todo, /) -> Any)` may be missing
- scipy/special/_precompute/gammainc_data.py:117:36: warning[possibly-missing-attribute] Attribute `__name__` on type `Unknown | ((a, x, dps=int, maxterms=int) -> Unknown)` may be missing
- Found 6861 diagnostics
+ Found 6856 diagnostics

No memory usage changes detected ✅

github-actions · 2025-10-13T12:31:33Z

`ecosystem-analyzer` results

Lint rule	Added	Removed	Changed
`possibly-missing-attribute`	0	12	0
`unresolved-attribute`	0	2	0
Total	0	14	0

Full report with detailed diff (timing results)

…lables

AlexWaygood · 2025-10-13T13:00:35Z

crates/ty_python_semantic/resources/mdtest/type_properties/is_assignable_to.md

do we really not already have tests like these somewhere...?

🤷‍♂️

crates/ty_python_semantic/resources/mdtest/type_properties/is_equivalent_to.md

AlexWaygood · 2025-10-13T13:02:29Z

crates/ty_python_semantic/resources/mdtest/type_properties/is_equivalent_to.md

+Note that `variadic_without_annotation` and `variadic_with_annotation` are *not* considered
+gradually equivalent to `Callable[..., Any]`, because the latter is not a function-like callable
+type:
+
+```py
+static_assert(not is_equivalent_to(CallableTypeOf[variadic_without_annotation], Callable[..., Any]))
+static_assert(not is_equivalent_to(CallableTypeOf[variadic_with_annotation], Callable[..., Any]))
+```
+
+A function with either `*args` or `**kwargs` (and not both) is is not equivalent to a callable with
+`...` as the parameter type.


AlexWaygood · 2025-10-13T13:05:49Z

crates/ty_python_semantic/src/types.rs

                    .map(|signature| signature.bind_self(db, Some(self_instance))),
            ),
-            false,
+            true,


strictly speaking, if we're doing it this way rather than with intersections, I suppose we should also have a method_like: bool flag for BoundMethodTypes -- methods not only have all the attributes that functions have, but they also have attributes such as __closure__ that functions do not have

(Not blocking for this PR, though, of course)

I very much like the Callable[…] & FunctionType / Callable[…] & BoundMethodType approach, but I'd like to move on with this for now, to get to what I'm actually trying to achieve 😄

yeah ikik, that's why I said this is non-blocking 😄

crates/ty_python_semantic/src/types.rs

…tity * origin/main: (24 commits) Update Python compatibility from 3.13 to 3.14 in README.md (#20852) [syntax-errors]: break outside loop F701 (#20556) [ty] Treat `Callable`s as bound-method descriptors in special cases (#20802) [ty] Do not bind self to non-positional parameters (#20850) Fix syntax error false positives on parenthesized context managers (#20846) [ty] Remove 'pre-release software' warning (#20817) Render unsupported syntax errors in formatter tests (#20777) [ty] Treat functions, methods, and dynamic types as function-like `Callable`s (#20842) [ty] Move logic for `super()` inference to a new `types::bound_super` submodule (#20840) [ty] Fix false-positive diagnostics on `super()` calls (#20814) [ty] Move `class_member` to `member` module (#20837) [`ruff`] Use DiagnosticTag for more flake8 and numpy rules (#20758) [ty] Prefer declared base class attribute over inferred attribute on subclass (#20764) [ty] Log files that are slow to type check (#20836) Update cargo-bins/cargo-binstall action to v1.15.7 (#20827) Update CodSpeedHQ/action action to v4.1.1 (#20828) Update Rust crate pyproject-toml to v0.13.7 (#20835) Update Rust crate anstream to v0.6.21 (#20829) Update Rust crate libc to v0.2.177 (#20832) Update Rust crate memchr to v2.7.6 (#20834) ...

* main: (25 commits) [ty] Diagnostic for generic classes that reference typevars in enclosing scope (#20822) Update Python compatibility from 3.13 to 3.14 in README.md (#20852) [syntax-errors]: break outside loop F701 (#20556) [ty] Treat `Callable`s as bound-method descriptors in special cases (#20802) [ty] Do not bind self to non-positional parameters (#20850) Fix syntax error false positives on parenthesized context managers (#20846) [ty] Remove 'pre-release software' warning (#20817) Render unsupported syntax errors in formatter tests (#20777) [ty] Treat functions, methods, and dynamic types as function-like `Callable`s (#20842) [ty] Move logic for `super()` inference to a new `types::bound_super` submodule (#20840) [ty] Fix false-positive diagnostics on `super()` calls (#20814) [ty] Move `class_member` to `member` module (#20837) [`ruff`] Use DiagnosticTag for more flake8 and numpy rules (#20758) [ty] Prefer declared base class attribute over inferred attribute on subclass (#20764) [ty] Log files that are slow to type check (#20836) Update cargo-bins/cargo-binstall action to v1.15.7 (#20827) Update CodSpeedHQ/action action to v4.1.1 (#20828) Update Rust crate pyproject-toml to v0.13.7 (#20835) Update Rust crate anstream to v0.6.21 (#20829) Update Rust crate libc to v0.2.177 (#20832) ...

…rable * origin/main: (26 commits) [ty] Add separate type for typevar "identity" (#20813) [ty] Diagnostic for generic classes that reference typevars in enclosing scope (#20822) Update Python compatibility from 3.13 to 3.14 in README.md (#20852) [syntax-errors]: break outside loop F701 (#20556) [ty] Treat `Callable`s as bound-method descriptors in special cases (#20802) [ty] Do not bind self to non-positional parameters (#20850) Fix syntax error false positives on parenthesized context managers (#20846) [ty] Remove 'pre-release software' warning (#20817) Render unsupported syntax errors in formatter tests (#20777) [ty] Treat functions, methods, and dynamic types as function-like `Callable`s (#20842) [ty] Move logic for `super()` inference to a new `types::bound_super` submodule (#20840) [ty] Fix false-positive diagnostics on `super()` calls (#20814) [ty] Move `class_member` to `member` module (#20837) [`ruff`] Use DiagnosticTag for more flake8 and numpy rules (#20758) [ty] Prefer declared base class attribute over inferred attribute on subclass (#20764) [ty] Log files that are slow to type check (#20836) Update cargo-bins/cargo-binstall action to v1.15.7 (#20827) Update CodSpeedHQ/action action to v4.1.1 (#20828) Update Rust crate pyproject-toml to v0.13.7 (#20835) Update Rust crate anstream to v0.6.21 (#20829) ...

sharkdp added the ty Multi-file analysis & type inference label Oct 13, 2025

sharkdp changed the title ~~[ty] Treat functions, methods, and dynamic types as function-like Cal…~~ [ty] Treat functions, methods, and dynamic types as function-like Callables Oct 13, 2025

sharkdp added the ecosystem-analyzer label Oct 13, 2025

sharkdp force-pushed the david/fix-1342-attempt-2 branch from b1ea6cb to 964d912 Compare October 13, 2025 12:36

[ty] Treat functions, methods, and dynamic types as function-like Cal…

b221247

…lables

sharkdp force-pushed the david/fix-1342-attempt-2 branch from 964d912 to b221247 Compare October 13, 2025 12:47

sharkdp marked this pull request as ready for review October 13, 2025 12:57

sharkdp requested review from AlexWaygood, carljm and dcreager as code owners October 13, 2025 12:57

AlexWaygood approved these changes Oct 13, 2025

View reviewed changes

Review findings

ec5b88e

sharkdp merged commit 195e8f0 into main Oct 13, 2025
40 checks passed

sharkdp deleted the david/fix-1342-attempt-2 branch October 13, 2025 13:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[ty] Treat functions, methods, and dynamic types as function-like `Callable`s#20842

[ty] Treat functions, methods, and dynamic types as function-like `Callable`s#20842
sharkdp merged 2 commits intomainfrom
david/fix-1342-attempt-2

sharkdp commented Oct 13, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 13, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 13, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

AlexWaygood Oct 13, 2025

Uh oh!

sharkdp Oct 13, 2025

Uh oh!

Uh oh!

AlexWaygood Oct 13, 2025

Uh oh!

AlexWaygood Oct 13, 2025

Uh oh!

sharkdp Oct 13, 2025

Uh oh!

AlexWaygood Oct 13, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

sharkdp commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Ecosystem analysis

Test Plan

Uh oh!

github-actions bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diagnostic diff on typing conformance tests

Uh oh!

github-actions bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

github-actions bot commented Oct 13, 2025

ecosystem-analyzer results

Uh oh!

AlexWaygood Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

sharkdp Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlexWaygood Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

AlexWaygood Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

sharkdp Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

AlexWaygood Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sharkdp commented Oct 13, 2025 •

edited

Loading

github-actions bot commented Oct 13, 2025 •

edited

Loading

github-actions bot commented Oct 13, 2025 •

edited

Loading

`mypy_primer` results

`ecosystem-analyzer` results