I'm not sure I understand this line. Which of the deductions in inner is incorrect for string, ascii, or repr conversion flags?

When an f-string interpolation has a conversion flag like !s, !a, or !r, Python's str(), ascii(), and repr() functions always produce a non-empty string representation of the object.

This means that all the complex expressions in the inner function (like BoolOp, BinOp, Call, Attribute, etc.) that normally return false because we can't determine if they're empty become guaranteed to be non-empty when conversion flags are applied.

The conversion flags essentially override the uncertainty by ensuring the result is always a meaningful string representation, which is why the condition correctly returns true whenever any conversion flag is present.

All three conversions can produce empty strings.

$ cat >counterexamples.py <<'# EOF'
from configparser import Error
error = Error()
print(len(f"{error!s}"))
print(len(f"{error!a}"))
print(len(f"{error!r}"))
# EOF

$ python counterexamples.py
0
0
0

Thanks for this; I was wrong about that then. In that case, we should have the condition removed.

I don't think those counterexamples are relevant here, as far as I can tell. The function in question returns true when we can be certain that the f-string is nonempty, and false otherwise. It already returns false for Name expressions, so it would already be okay for counterexamples.py with or without worrying about conversion flags.

My claim is that the expressions for which we return true would be unaffected by the presence of these flags (insofar as their boolean value).