[ty] Explicitly test assignability/subtyping between unions of nominal types and protocols with method members#20557
Merged
AlexWaygood merged 1 commit intomainfrom Sep 25, 2025
Merged
Conversation
AlexWaygood
requested review from
carljm,
dcreager and
sharkdp
as code owners
AlexWaygood
added
testing
Base automatically changed from
alex/proto-classmethod-staticmethod-tests
to
main
September 25, 2025 09:14
…l types and protocols with method members
AlexWaygood
force-pushed
the
alex/proto-union-tests
branch
from
e02e3dc to
105fe50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Stacked on top of #20555; review that PR first!)
Summary
@sharkdp very reasonably asked in #20165 (comment) whether the
invoke_descriptor_protocolcall here would produce the right result when testing assignability between a union of nominal types and a protocol with a method member:ruff/crates/ty_python_semantic/src/types/protocol_class.rs
Lines 559 to 570 in 83f80ef
This wasn't something we had explicit tests for, so this PR adds some tests for it!