Skip to content

Comments

[ty] move primer projects to good.txt#20444

Merged
sharkdp merged 1 commit intomainfrom
cjm/good
Sep 17, 2025
Merged

[ty] move primer projects to good.txt#20444
sharkdp merged 1 commit intomainfrom
cjm/good

Conversation

@carljm
Copy link
Contributor

@carljm carljm commented Sep 17, 2025

Summary

After #20359 we can move all but three remaining projects over to good.txt.

Test Plan

CI

@carljm carljm added internal An internal refactor or improvement ty Multi-file analysis & type inference labels Sep 17, 2025
@github-actions
Copy link
Contributor

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

@github-actions
Copy link
Contributor

mypy_primer results

No ecosystem changes detected ✅
No memory usage changes detected ✅

@carljm carljm marked this pull request as ready for review September 17, 2025 00:19
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work!

@github-actions
Copy link
Contributor

ecosystem-analyzer results

Lint rule Added Removed Changed
unresolved-import 7,869 0 0
unresolved-reference 2,488 0 0
unused-ignore-comment 2,486 0 0
unresolved-attribute 1,590 0 0
too-many-positional-arguments 1,408 0 0
possibly-unresolved-reference 997 0 0
invalid-argument-type 958 0 0
possibly-unbound-attribute 809 0 0
invalid-overload 747 0 0
invalid-return-type 467 0 0
invalid-type-form 406 0 0
unsupported-operator 307 0 0
invalid-assignment 219 0 0
non-subscriptable 130 0 0
invalid-context-manager 129 0 0
invalid-parameter-default 104 0 0
call-non-callable 100 0 0
missing-argument 98 0 0
possibly-unbound-import 96 0 0
no-matching-overload 63 0 0
deprecated 51 0 0
unknown-argument 48 0 0
invalid-base 44 0 0
type-assertion-failure 43 0 0
not-iterable 27 0 0
unsupported-base 14 0 0
instance-layout-conflict 12 0 0
parameter-already-assigned 10 0 0
division-by-zero 9 0 0
conflicting-metaclass 7 0 0
redundant-cast 7 0 0
inconsistent-mro 6 0 0
unresolved-global 6 0 0
conflicting-declarations 4 0 0
invalid-ignore-comment 4 0 0
escape-character-in-forward-annotation 3 0 0
invalid-exception-caught 3 0 0
invalid-legacy-type-variable 3 0 0
invalid-type-checking-constant 3 0 0
invalid-key 2 0 0
invalid-super-argument 2 0 0
invalid-syntax 2 0 0
possibly-unbound-implicit-call 2 0 0
subclass-of-final-class 2 0 0
index-out-of-bounds 1 0 0
invalid-attribute-access 1 0 0
Total 21,787 0 0

Full report with detailed diff

Copy link
Contributor

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@sharkdp sharkdp merged commit 681ad2f into main Sep 17, 2025
41 checks passed
@sharkdp sharkdp deleted the cjm/good branch September 17, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ecosystem-analyzer internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants