Stabilize long-sleep-not-forever (ASYNC116)#20244
Merged
ntBre merged 1 commit intobrent/0.13.0from Sep 4, 2025
Merged
Conversation
Tests and docs look good
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF100 | 4 | 0 | 4 | 0 | 0 |
Linter (preview)
✅ ecosystem check detected no linter changes.
Contributor
Author
|
The ecosystem changes are previously-unused noqa codes for ASYNC116 that are now used on stable. I took a look at these to see where a real project needed to use a noqa for this rule, but it was just trio intentionally testing long sleeps, with comments to support that: # ignore ASYNC116, not sleep_forever, trying to test a large but finite sleep
await sleep(100000) # noqa: ASYNC116 |
dylwil3
approved these changes
Sep 4, 2025
ntBre
added a commit
that referenced
this pull request
Sep 8, 2025
ntBre
added a commit
that referenced
this pull request
Sep 10, 2025
ntBre
added a commit
that referenced
this pull request
Sep 10, 2025
ntBre
added a commit
that referenced
this pull request
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests and docs look good