[syntax-errors]: multiple-starred-expressions (F622)#20243
[syntax-errors]: multiple-starred-expressions (F622)#20243ntBre merged 5 commits intoastral-sh:mainfrom
Conversation
11happy
changed the title
|
Hii @ntBre , would love your feedback on this when you get a chance. |
|
|
Thanks for the pings. Your PRs are in my inbox, but we've been focused on the minor release. I'll get to them soon. |
|
Sure, No worries at all, I completely understand. Thank you for your time : ) |
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks for your work here! I think we need to fix a false positive in the ecosystem check, avoid duplicate diagnostics, and add a bit of documentation.
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks! I think the tests look good now, just a couple of simplification suggestions.
Signed-off-by: 11happy <[email protected]>
Signed-off-by: 11happy <[email protected]>
Signed-off-by: 11happy <[email protected]>
Signed-off-by: 11happy <[email protected]>
|
The Thank you |
|
Please let me know if there's any more changes required for this PR. Thank you : ) |
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thank you! I just had one tiny spacing nit that I'll apply and merge.
2 participants
Summary
This PR implements https://docs.astral.sh/ruff/rules/multiple-starred-expressions/ as a semantic syntax error
Test Plan
I have added inline tests as directed in #17412