[ty] Support single-starred argument for overload call by dhruvmanila · Pull Request #20223 · astral-sh/ruff

dhruvmanila · 2025-09-04T08:08:54Z

Summary

This PR adds support for variadic arguments to overload call evaluation.

This basically boils down to making sure that the overloads are not filtered out incorrectly during the step 5 in the overload call evaluation algorithm. For context, the step 5 tries to filter out the remaining overloads after finding an overload where the materialization of argument types are assignable to the parameter types.

The issue with the previous implementation was that it wouldn't unpack the variadic argument and wouldn't consider the many-to-one (multiple arguments mapping to a single variadic parameter) correctly. This PR fixes that.

Test Plan

Update existing test cases and resolve the TODOs.

github-actions · 2025-09-04T08:10:54Z

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

github-actions · 2025-09-04T08:13:54Z

`mypy_primer` results

Changes were detected when running on open source projects

attrs (https://github.com/python-attrs/attrs)
- tests/test_dunders.py:677:15: error[too-many-positional-arguments] Too many positional arguments to bound method `__init__`: expected 1, got 2
+ tests/test_dunders.py:677:15: error[too-many-positional-arguments] Too many positional arguments: expected 0, got 1
- tests/test_make.py:2169:15: error[too-many-positional-arguments] Too many positional arguments to bound method `__init__`: expected 1, got 2
+ tests/test_make.py:2169:15: error[too-many-positional-arguments] Too many positional arguments: expected 0, got 1
- tests/test_make.py:2191:22: error[too-many-positional-arguments] Too many positional arguments to bound method `__init__`: expected 1, got 2
+ tests/test_make.py:2191:22: error[too-many-positional-arguments] Too many positional arguments: expected 0, got 1
- tests/test_make.py:2192:30: error[too-many-positional-arguments] Too many positional arguments to bound method `__init__`: expected 1, got 2
+ tests/test_make.py:2192:30: error[too-many-positional-arguments] Too many positional arguments: expected 0, got 1

porcupine (https://github.com/Akuli/porcupine)
- porcupine/plugins/git_right_click.py:56:22: error[unresolved-attribute] Type `str` has no attribute `decode`
- porcupine/plugins/git_right_click.py:57:24: error[unresolved-attribute] Type `str` has no attribute `decode`
- Found 26 diagnostics
+ Found 24 diagnostics

pwndbg (https://github.com/pwndbg/pwndbg)
+ pwndbg/dbg/gdb/__init__.py:1750:9: error[invalid-assignment] Object of type `str` is not assignable to `Literal["att", "intel"]`
- Found 2571 diagnostics
+ Found 2572 diagnostics

scikit-build-core (https://github.com/scikit-build/scikit-build-core)
+ src/scikit_build_core/build/_wheelfile.py:51:22: error[no-matching-overload] No overload of function `field` matches arguments
- Found 52 diagnostics
+ Found 53 diagnostics

prefect (https://github.com/PrefectHQ/prefect)
+ src/integrations/prefect-kubernetes/prefect_kubernetes/worker.py:627:5: error[invalid-assignment] Object of type `Literal[KubernetesImagePullPolicy.IF_NOT_PRESENT]` is not assignable to `Literal["IfNotPresent", "Always", "Never"]`
+ src/integrations/prefect-snowflake/prefect_snowflake/experimental/workers/spcs.py:109:5: error[invalid-assignment] Object of type `None` is not assignable to `str`
+ src/integrations/prefect-snowflake/prefect_snowflake/experimental/workers/spcs.py:141:5: error[invalid-assignment] Object of type `None` is not assignable to `str`
+ src/integrations/prefect-snowflake/prefect_snowflake/experimental/workers/spcs.py:156:5: error[invalid-assignment] Object of type `None` is not assignable to `str`
+ src/integrations/prefect-snowflake/prefect_snowflake/experimental/workers/spcs.py:256:5: error[invalid-assignment] Object of type `None` is not assignable to `str`
+ src/integrations/prefect-snowflake/prefect_snowflake/experimental/workers/spcs.py:287:5: error[invalid-assignment] Object of type `None` is not assignable to `str`
+ src/integrations/prefect-snowflake/prefect_snowflake/experimental/workers/spcs.py:302:5: error[invalid-assignment] Object of type `None` is not assignable to `str`
- Found 3180 diagnostics
+ Found 3187 diagnostics

core (https://github.com/home-assistant/core)
- homeassistant/components/sonos/diagnostics.py:129:20: error[invalid-return-type] Return type does not match returned value: expected `int | float | str | dict[str, Any]`, found `MappingProxyType[str, Any]`
- Found 13733 diagnostics
+ Found 13732 diagnostics

No memory usage changes detected ✅

codspeed-hq · 2025-09-29T11:44:24Z

CodSpeed WallTime Performance Report

Merging #20223 will not alter performance

_{Comparing dhruv/skip-filtering (58d4d9f) with main (8664842)}

Summary

✅ 8 untouched

codspeed-hq · 2025-09-29T11:44:59Z

CodSpeed Instrumentation Performance Report

Merging #20223 will not alter performance

_{Comparing dhruv/skip-filtering (58d4d9f) with main (8664842)}

Summary

✅ 13 untouched
⏩ 30 skipped¹

30 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

dhruvmanila · 2025-09-29T17:15:05Z

~~I plan on looking at the performance regression tomorrow morning but otherwise I think this is ready to get some initial feedback.~~

It seems like it was just noise.

dcreager

Looks good!

* origin/main: [`flake8-bugbear`] Include certain guaranteed-mutable expressions: tuples, generators, and assignment expressions (`B006`) (#20024) [`flake8-comprehensions`] Clarify fix safety documentation (`C413`) (#20640) [ty] improve base conda distinction from child conda (#20675) [`ruff`] Extend FA102 with listed PEP 585-compatible APIs (#20659) [`ruff`] Handle argfile expansion errors gracefully (#20691) [`flynt`] Fix f-string quoting for mixed quote joiners (`FLY002`) (#20662) [ty] Fix file root matching for `/` [ruff,ty] Enable tracing's `log` feature [`flake8-annotations`] Fix return type annotations to handle shadowed builtin symbols (`ANN201`, `ANN202`, `ANN204`, `ANN205`, `ANN206`) (#20612) Bump 0.13.3 (#20685) Update benchmarking CI for cargo-codspeed v4 (#20686) [ty] Support single-starred argument for overload call (#20223) [ty] `~T` should never be assignable to `T` (#20606) [`pylint`] Clarify fix safety to include left-hand hashability (`PLR6201`) (#20518) [ty] No union with `Unknown` for module-global symbols (#20664) [`ty`] Reject renaming files to start with slash in Playground (#20666) [ty] Enums: allow multiple aliases to point to the same member (#20669)

dhruvmanila added the ty Multi-file analysis & type inference label Sep 4, 2025

dhruvmanila added 5 commits September 8, 2025 11:53

[ty] Re-try argument matching for argument type expansion

19f1a44

Revert skipping step 5 filtering

71c92f0

Update comment per review

4184ce9

[ty] Skip overload filtering if there are no participating parameters

d265152

Return directly instead

38f17fc

dhruvmanila force-pushed the dhruv/retry-parameter-matching branch from 63fe1a7 to 4184ce9 Compare September 8, 2025 06:24

Base automatically changed from dhruv/retry-parameter-matching to main September 12, 2025 08:40

dhruvmanila added 2 commits September 19, 2025 14:14

Merge branch 'main' into dhruv/skip-filtering

1771349

Fix merge commit

9902027

dhruvmanila force-pushed the dhruv/skip-filtering branch from e3eec3f to 9902027 Compare September 19, 2025 08:49

dhruvmanila changed the title ~~[ty] Skip overload filtering if there are no participating parameters~~ [ty] Support single-starred argument for overload call Sep 19, 2025

dhruvmanila mentioned this pull request Sep 19, 2025

Support starred/splatted/unpacked arguments in function calls astral-sh/ty#247

Closed

3 tasks

dhruvmanila added 2 commits September 22, 2025 11:24

Initial implementation of single starred arg in overload call

4cd7de1

Merge branch 'main' into dhruv/skip-filtering

5671600

dhruvmanila force-pushed the dhruv/skip-filtering branch from 81667b1 to 5671600 Compare September 25, 2025 08:18

dhruvmanila added 5 commits September 25, 2025 15:55

Fix merge commit

b88f604

Merge branch 'main' into dhruv/skip-filtering

364f401

wip

4e3b958

Merge branch 'main' into dhruv/skip-filtering

7002b86

Final solution

2b2fbe6

Fix test failure

c489ed7

dhruvmanila marked this pull request as ready for review September 29, 2025 17:15

dhruvmanila requested review from AlexWaygood and carljm as code owners September 29, 2025 17:15

dhruvmanila requested review from dcreager and sharkdp as code owners September 29, 2025 17:15

dhruvmanila added 2 commits September 30, 2025 09:17

Materialize preserving the outer context

d759bd3

Revert materialization change

58d4d9f

dcreager approved these changes Oct 2, 2025

View reviewed changes

dcreager merged commit 4e94b22 into main Oct 2, 2025
39 checks passed

dcreager deleted the dhruv/skip-filtering branch October 2, 2025 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[ty] Support single-starred argument for overload call#20223

[ty] Support single-starred argument for overload call#20223
dcreager merged 17 commits intomainfrom
dhruv/skip-filtering

dhruvmanila commented Sep 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 29, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 29, 2025 •

edited

Loading

Uh oh!

dhruvmanila commented Sep 29, 2025 •

edited

Loading

Uh oh!

dcreager left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

dhruvmanila commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

github-actions bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diagnostic diff on typing conformance tests

Uh oh!

github-actions bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

codspeed-hq bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed WallTime Performance Report

Merging #20223 will not alter performance

Summary

Uh oh!

codspeed-hq bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #20223 will not alter performance

Summary

Footnotes

Uh oh!

dhruvmanila commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dcreager left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dhruvmanila commented Sep 4, 2025 •

edited

Loading

github-actions bot commented Sep 4, 2025 •

edited

Loading

github-actions bot commented Sep 4, 2025 •

edited

Loading

`mypy_primer` results

codspeed-hq bot commented Sep 29, 2025 •

edited

Loading

codspeed-hq bot commented Sep 29, 2025 •

edited

Loading

dhruvmanila commented Sep 29, 2025 •

edited

Loading