Use fixed hash width for ty_server diagnostics#19766
Merged
Conversation
Summary -- Fixes a snapshot test failure I saw in #19653 locally and in Windows CI by padding the hex ID to 16 digits to match the regex in `filter_result_id`. https://github.com/astral-sh/ruff/blob/78e5fe0a51fcbb1456d54c65b4632f60c268e389/crates/ty_server/tests/e2e/pull_diagnostics.rs#L380-L384 Test Plan -- I applied this to the branch from #19653 locally and saw that the tests now pass. I couldn't reproduce this failure directly on `main` or this branch, though.
ntBre
requested review from
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a snapshot test failure I saw in #19653 locally and in Windows CI by
padding the hex ID to 16 digits to match the regex in
filter_result_id.ruff/crates/ty_server/tests/e2e/pull_diagnostics.rs
Lines 380 to 384 in 78e5fe0
Test Plan
I applied this to the branch from #19653 locally and saw that the tests now
pass. I couldn't reproduce this failure directly on
mainor this branch,though.