[flake8-blind-except] Fix BLE001 false-positive on raise ... from None#19755
Merged
ntBre merged 1 commit intoastral-sh:mainfrom Aug 13, 2025
Merged
[flake8-blind-except] Fix BLE001 false-positive on raise ... from None#19755ntBre merged 1 commit intoastral-sh:mainfrom
flake8-blind-except] Fix BLE001 false-positive on raise ... from None#19755ntBre merged 1 commit intoastral-sh:mainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| BLE001 | 1 | 0 | 1 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -1 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)
zulip/zulip (+0 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- tools/lib/provision.py:386:20: BLE001 Do not catch blind exception: `BaseException`
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| BLE001 | 1 | 0 | 1 | 0 | 0 |
deliro
force-pushed
the
ble001-enhance
branch
2 times, most recently
from
66c1a31 to
84cead4
Compare
deliro
changed the title
flake8-blind-except] Enhance BLE001: fix docs; light speed-up; improve readabilityflake8-blind-except] Fix BLE001: false-positive trigger with raise ... from None
ntBre
added
bug
ntBre
approved these changes
Aug 12, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Looks good to me, thank you! And the change in the ecosystem report is exactly like the issue.
Contributor
|
I think the conflicts are just from recent changes to our diagnostic format. Could you just rerun the tests locally and accept the new snapshots? That's probably the easiest way to resolve them. |
Contributor
Author
Thank you! Done |
ntBre
changed the title
flake8-blind-except] Fix BLE001: false-positive trigger with raise ... from Noneflake8-blind-except] Fix BLE001 false-positive on raise ... from None
dcreager
added a commit
that referenced
this pull request
Aug 14, 2025
* main: Feature/build riscv64 bin (#19819) [ty] Add caching to `CodeGeneratorKind::matches()` (#19912) [ty] Rename `functionArgumentNames` to `callArgumentNames` inlay hint setting (#19911) [ty] Default `ty.inlayHints.*` server settings to true (#19910) [ty] Remove py-fuzzer skips for seeds that are no longer slow (#19906) [ty] fix deferred name loading in PEP695 generic classes/functions (#19888) [ty] Add some additional type safety to `CycleDetector` (#19903) [`flake8-blind-except`] Fix `BLE001` false-positive on `raise ... from None` (#19755) [ty] resolve docstrings for modules (#19898)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BLE001logic for clarity and minor speed-up.BLE001docs claimed it catches bareexcept:s, but it doesn't).from Nonecause:main branch
this change
cargo run -p ruff -- check somefile.py --no-cache --select=BLE001Test Plan
raise X from Yclauseraise X from Noneclause