[ty] synthesize `__replace__` for dataclasses (>=3.13) by thejchap · Pull Request #19545 · astral-sh/ruff

thejchap · 2025-07-25T01:21:22Z

Summary

astral-sh/ty#111

adds support for the new copy.replace and __replace__ protocol added in 3.13

docs: https://docs.python.org/3/library/copy.html#object.__replace__
some discussion on pyright/mypy implementations: https://discuss.python.org/t/dataclass-transform-and-replace/69067

Burndown

add tests
implement __replace__
- collections.namedtuple()
- dataclasses.dataclass

Test Plan

new mdtests

github-actions · 2025-07-25T01:25:04Z

`mypy_primer` results

No ecosystem changes detected ✅
No memory usage changes detected ✅

AlexWaygood · 2025-07-25T11:00:43Z

Thank you for working on this!!

datetime.datetime, datetime.date, datetime.time

inspect.Signature, inspect.Parameter

types.SimpleNamespace

code objects

Hmm, I'm not sure we need to implement special casing for any of these. Typeshed should already include __replace__ methods for all of these in the stdlib stubs that we vendor, so no additional implementation from us should be required -- it should hopefully "just work"! I think the only cases where we need to add some special casing are named tuples and dataclasses, because for these very special types the methods are synthesized at runtime rather than being present in the source code.

crates/ty_python_semantic/src/types/class.rs

thejchap · 2025-07-26T03:46:21Z

@AlexWaygood ready for some feedback on this one!

crates/ty_python_semantic/resources/mdtest/replace.md

crates/ty_python_semantic/src/types/class.rs

sharkdp

Very nice — thank you. I added a couple of minor inline comments.

github-actions · 2025-07-28T12:10:15Z

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

thejchap · 2025-07-28T13:22:39Z

@sharkdp thanks! addressed most of your comments, and added a wip implementation of special handling of copy.replace here. please let me know if that's on the right track

if so, i'm fine to either merge as-is and complete that in a follow-on pr, or finish as part of this one

crates/ty_python_semantic/resources/mdtest/replace.md

crates/ty_python_semantic/src/types/call/bind.rs

crates/ty_python_semantic/src/types/class.rs

crates/ty_python_semantic/src/types/function.rs

thejchap · 2025-07-29T12:13:01Z

@sharkdp thanks - i pulled out the invalid-argument-type logic for invalid replace(…) calls for now. i might work on this more in another pr

sharkdp

Thank you very much. I made a few minor adjustments.

* main: (24 commits) Add `Checker::context` method, deduplicate Unicode checks (#19609) [`flake8-pyi`] Preserve inline comment in ellipsis removal (`PYI013`) (#19399) [ty] Add flow diagram for import resolution [ty] Add comments to some core resolver functions [ty] Add missing ticks and use consistent quoting [ty] Reflow some long lines [ty] Unexport helper function [ty] Remove offset from `CompletionTargetTokens::Unknown` [`pyupgrade`] Fix `UP030` to avoid modifying double curly braces in format strings (#19378) [ty] fix a typo (#19621) [ty] synthesize `__replace__` for dataclasses (>=3.13) (#19545) [ty] Discard `Definition`s when normalizing `Signature`s (#19615) [ty] Fix empty spans following a line terminator and unprintable character spans in diagnostics (#19535) Add `LinterContext::settings` to avoid passing separate settings (#19608) Support `.pyi` files in ruff analyze graph (#19611) [ty] Sync vendored typeshed stubs (#19607) [ty] Bump docstring-adder pin (#19606) [`perflint`] Ignore rule if target is `global` or `nonlocal` (`PERF401`) (#19539) Add license classifier back to pyproject.toml (#19599) [ty] Add stub mapping support to signature help (#19570) ...

thejchap force-pushed the thejchap/more-dataclasses branch from 4cede2a to 168599f Compare July 25, 2025 01:53

thejchap changed the title ~~[ty] synthesize __replace__ for >=3.13~~ [ty] synthesize __replace__ for dataclasses (>=3.13) Jul 25, 2025

AlexWaygood added the ty Multi-file analysis & type inference label Jul 25, 2025

AlexWaygood mentioned this pull request Jul 25, 2025

Advanced dataclass support astral-sh/ty#111

Closed

19 tasks

thejchap force-pushed the thejchap/more-dataclasses branch from 168599f to 9a743a2 Compare July 26, 2025 03:33

thejchap commented Jul 26, 2025

View reviewed changes

crates/ty_python_semantic/src/types/class.rs Outdated Show resolved Hide resolved

thejchap commented Jul 26, 2025

View reviewed changes

crates/ty_python_semantic/src/types/class.rs Outdated Show resolved Hide resolved

thejchap marked this pull request as ready for review July 26, 2025 03:46

thejchap requested review from AlexWaygood, carljm, dcreager and sharkdp as code owners July 26, 2025 03:46

sharkdp reviewed Jul 28, 2025

View reviewed changes

crates/ty_python_semantic/resources/mdtest/replace.md Outdated Show resolved Hide resolved

sharkdp reviewed Jul 28, 2025

View reviewed changes

crates/ty_python_semantic/resources/mdtest/replace.md Outdated Show resolved Hide resolved

sharkdp reviewed Jul 28, 2025

View reviewed changes

crates/ty_python_semantic/resources/mdtest/replace.md Outdated Show resolved Hide resolved

sharkdp reviewed Jul 28, 2025

View reviewed changes

crates/ty_python_semantic/src/types/class.rs Outdated Show resolved Hide resolved

sharkdp approved these changes Jul 28, 2025

View reviewed changes

thejchap force-pushed the thejchap/more-dataclasses branch from 9a743a2 to 6ed4a25 Compare July 28, 2025 12:08

thejchap force-pushed the thejchap/more-dataclasses branch 2 times, most recently from 36d67e1 to e851706 Compare July 28, 2025 13:19

thejchap force-pushed the thejchap/more-dataclasses branch from e851706 to 2861d0b Compare July 29, 2025 01:47

sharkdp reviewed Jul 29, 2025

View reviewed changes

thejchap force-pushed the thejchap/more-dataclasses branch 3 times, most recently from 6639db6 to 646685c Compare July 29, 2025 12:09

[ty] synthesize __replace__ for >=3.13

e8a283a

thejchap force-pushed the thejchap/more-dataclasses branch from 646685c to e8a283a Compare July 29, 2025 12:10

Minor adjustments

c312396

sharkdp approved these changes Jul 29, 2025

View reviewed changes

sharkdp merged commit 656273b into astral-sh:main Jul 29, 2025
37 checks passed

Comments

Conversation

thejchap commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Burndown

Test Plan

Uh oh!

github-actions bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

AlexWaygood commented Jul 25, 2025

Uh oh!

Uh oh!

Uh oh!

thejchap commented Jul 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sharkdp left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diagnostic diff on typing conformance tests

Uh oh!

thejchap commented Jul 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thejchap commented Jul 29, 2025

Uh oh!

sharkdp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thejchap commented Jul 25, 2025 •

edited

Loading

github-actions bot commented Jul 25, 2025 •

edited

Loading

`mypy_primer` results

github-actions bot commented Jul 28, 2025 •

edited

Loading