[`flake8-use-pathlib`] Add fixes for `PTH102` and `PTH103` by chirizxc · Pull Request #19514 · astral-sh/ruff

chirizxc · 2025-07-23T17:36:22Z

Summary

Part of #2331

Test Plan

cargo nextest run flake8_use_pathlib

chirizxc · 2025-07-23T17:45:27Z

@ntBre It's part of #19213 (check_os_pathlib_single_arg_calls)

github-actions · 2025-07-23T17:50:32Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -0 violations, +212 -0 fixes in 5 projects; 50 projects unchanged)

apache/airflow (+0 -0 violations, +50 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ airflow-core/tests/unit/utils/log/test_file_processor_handler.py:105:9: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- airflow-core/tests/unit/utils/log/test_file_processor_handler.py:105:9: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ airflow-core/tests/unit/utils/log/test_log_reader.py:96:9: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- airflow-core/tests/unit/utils/log/test_log_reader.py:96:9: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ airflow-core/tests/unit/utils/test_file.py:106:9: PTH102 [*] `os.mkdir()` should be replaced by `Path.mkdir()`
- airflow-core/tests/unit/utils/test_file.py:106:9: PTH102 `os.mkdir()` should be replaced by `Path.mkdir()`
+ airflow-core/tests/unit/utils/test_file.py:164:9: PTH102 [*] `os.mkdir()` should be replaced by `Path.mkdir()`
- airflow-core/tests/unit/utils/test_file.py:164:9: PTH102 `os.mkdir()` should be replaced by `Path.mkdir()`
+ airflow-ctl/src/airflowctl/api/client.py:133:9: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- airflow-ctl/src/airflowctl/api/client.py:133:9: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
... 41 additional changes omitted for rule PTH103
... 40 additional changes omitted for project

apache/superset (+0 -0 violations, +6 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ superset/initialization/__init__.py:121:9: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- superset/initialization/__init__.py:121:9: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ superset/initialization/__init__.py:814:17: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- superset/initialization/__init__.py:814:17: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ superset/utils/core.py:1211:9: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- superset/utils/core.py:1211:9: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`

bokeh/bokeh (+0 -0 violations, +14 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ tests/support/defaults.py:114:5: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- tests/support/defaults.py:114:5: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ tests/support/plugins/jupyter_notebook.py:89:9: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- tests/support/plugins/jupyter_notebook.py:89:9: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ tests/support/util/examples.py:243:9: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- tests/support/util/examples.py:243:9: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ tests/support/util/filesystem.py:178:1: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- tests/support/util/filesystem.py:178:1: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ tests/support/util/filesystem.py:87:17: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- tests/support/util/filesystem.py:87:17: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
... 4 additional changes omitted for project

milvus-io/pymilvus (+0 -0 violations, +18 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ examples/bulk_import/example_bulkinsert_csv.py:122:5: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- examples/bulk_import/example_bulkinsert_csv.py:122:5: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ examples/bulk_import/example_bulkinsert_csv.py:127:9: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- examples/bulk_import/example_bulkinsert_csv.py:127:9: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ examples/bulk_import/example_bulkinsert_json.py:166:5: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- examples/bulk_import/example_bulkinsert_json.py:166:5: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ examples/bulk_import/example_bulkinsert_json.py:171:9: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- examples/bulk_import/example_bulkinsert_json.py:171:9: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ examples/bulk_import/example_bulkinsert_numpy.py:124:5: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- examples/bulk_import/example_bulkinsert_numpy.py:124:5: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
... 8 additional changes omitted for project

zulip/zulip (+0 -0 violations, +124 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ scripts/lib/puppet_cache.py:55:5: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- scripts/lib/puppet_cache.py:55:5: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ scripts/lib/zulip_tools.py:213:5: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- scripts/lib/zulip_tools.py:213:5: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ scripts/lib/zulip_tools.py:222:13: PTH102 [*] `os.mkdir()` should be replaced by `Path.mkdir()`
- scripts/lib/zulip_tools.py:222:13: PTH102 `os.mkdir()` should be replaced by `Path.mkdir()`
+ scripts/lib/zulip_tools.py:284:9: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- scripts/lib/zulip_tools.py:284:9: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ scripts/lib/zulip_tools.py:646:5: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- scripts/lib/zulip_tools.py:646:5: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ tools/lib/provision.py:56:5: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- tools/lib/provision.py:56:5: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ tools/lib/provision_inner.py:62:9: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- tools/lib/provision_inner.py:62:9: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ tools/lib/test_script.py:126:5: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
- tools/lib/test_script.py:126:5: PTH103 `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
+ tools/setup/generate_bots_integrations_static_files.py:23:5: PTH103 [*] `os.makedirs()` should be replaced by `Path.mkdir(parents=True)`
... 102 additional changes omitted for rule PTH103
+ tools/setup/generate_landing_page_images.py:26:9: PTH102 [*] `os.mkdir()` should be replaced by `Path.mkdir()`
- tools/setup/generate_landing_page_images.py:26:9: PTH102 `os.mkdir()` should be replaced by `Path.mkdir()`
+ zerver/management/commands/backup.py:41:13: PTH102 [*] `os.mkdir()` should be replaced by `Path.mkdir()`
- zerver/management/commands/backup.py:41:13: PTH102 `os.mkdir()` should be replaced by `Path.mkdir()`
+ zerver/worker/base.py:275:13: PTH102 [*] `os.mkdir()` should be replaced by `Path.mkdir()`
- zerver/worker/base.py:275:13: PTH102 `os.mkdir()` should be replaced by `Path.mkdir()`
... 101 additional changes omitted for project

Changes by rule (2 rules affected)

code	total	+ violation	- violation	+ fix	- fix
PTH103	200	0	0	200	0
PTH102	12	0	0	12	0

chirizxc · 2025-07-23T17:56:59Z

I see I made a mistake somewhere

chirizxc · 2025-07-23T18:01:44Z

Yes, it's because of a condition in check_os_pathlib_single_arg_calls

chirizxc · 2025-07-23T18:39:49Z

now autofixes will be for all possible cases except dir_fd

chirizxc · 2025-07-24T11:33:33Z

I think this PR can also include PTH211, there will be similar autofix

ntBre

Thanks! I have a few suggestions here, but most of them are pretty minor, and this looks good overall. The main question is around adding the parents=True argument.

crates/ruff_linter/src/rules/flake8_use_pathlib/rules/mod.rs

crates/ruff_linter/src/rules/flake8_use_pathlib/rules/os_makedirs.rs

crates/ruff_linter/src/rules/flake8_use_pathlib/rules/os_mkdir.rs

ntBre

Thanks! This looks good except for some more concerns about argument handling, sorry for not catching this earlier.

crates/ruff_linter/src/rules/flake8_use_pathlib/rules/os_makedirs.rs

chirizxc · 2025-07-26T19:59:30Z

in this variant only for the case when all arguments are positional fix will make them named to avoid the problem with TypeError: Path.mkdir() got multiple values for argument ‘parents’

chirizxc · 2025-07-26T20:02:22Z

Maybe there are more cases that I didn't see, I'll try to see more

crates/ruff_linter/src/rules/flake8_use_pathlib/rules/os_makedirs.rs

chirizxc · 2025-08-01T15:45:52Z

We have only two autofix outputs, when all args positional:

already used in the code

os.makedirs("name", 0o777, False) # => 
pathlib.Path("name").mkdir(mode=0o777, exist_ok=False, parents=True)

os.makedirs("name", 0o777, False) # =>
pathlib.Path("name").mkdir(0o777, True, False)

…inal call uses exactly 3 positional arguments and no keywords

chirizxc · 2025-08-06T18:22:34Z

# ruff: noqa: FBT003
import os

os.makedirs("name", True)
os.makedirs("name", 0o777)
os.makedirs("name", 0o777, True)
os.makedirs("name", 0o777, exist_ok=True)
os.makedirs("name", mode=0o777, exist_ok=True)
os.makedirs(name="name", mode=0o777, exist_ok=True)
os.makedirs("name", exist_ok=True, mode=0o777)

os.makedirs("name", idk="123")
os.makedirs("name", mode=0o777, exist_ok=False, x=True)

after fix:

# ruff: noqa: FBT003
import os
from pathlib import Path

Path("name").mkdir(True, parents=True)
Path("name").mkdir(0o777, parents=True)
Path("name").mkdir(0o777, True, True)
Path("name").mkdir(0o777, exist_ok=True, parents=True)
Path("name").mkdir(mode=0o777, exist_ok=True, parents=True)
Path("name").mkdir(mode=0o777, exist_ok=True, parents=True)
Path("name").mkdir(exist_ok=True, mode=0o777, parents=True)

os.makedirs("name", idk="123")
os.makedirs("name", mode=0o777, exist_ok=False, x=True)

chirizxc · 2025-08-12T17:01:35Z

@ntBre can you check this realization please?

ntBre · 2025-08-12T17:21:53Z

Yes, sorry, this has been on my todo list. Do you have a question about the implementation or is this just ready for review again?

And sorry for all the snapshot conflicts, we just updated our diagnostic rendering. I think you should just need to accept the new versions of the snapshots after re-running the tests.

chirizxc · 2025-08-12T17:24:51Z

Yes, sorry, this has been on my todo list. Do you have a question about the implementation or is this just ready for review again?

And sorry for all the snapshot conflicts, we just updated our diagnostic rendering. I think you should just need to accept the new versions of the snapshots after re-running the tests.

it's ready

ntBre

Thank you, this is looking good. I had a couple more, smaller argument validation suggestions and a potential simplification for the parents argument addition. Thanks for handling all of my pedantic feedback here, these are going to be great fixes :)

crates/ruff_linter/src/rules/flake8_use_pathlib/rules/os_makedirs.rs

ntBre

Thank you!

* main: (29 commits) [ty] add docstrings to completions based on type (#20008) [`pyupgrade`] Avoid reporting `__future__` features as unnecessary when they are used (`UP010`) (#19769) [`flake8-use-pathlib`] Add fixes for `PTH102` and `PTH103` (#19514) [ty] correctly ignore field specifiers when not specified (#20002) `Option::unwrap` is now const (#20007) [ty] Re-arrange "list modules" implementation for Salsa caching [ty] Test "list modules" versus "resolve module" in every mdtest [ty] Wire up "list modules" API to make module completions work [ty] Tweak some completion tests [ty] Add "list modules" implementation [ty] Lightly expose `FileModule` and `NamespacePackage` fields [ty] Add some more helper routines to `ModulePath` [ty] Fix a bug when converting `ModulePath` to `ModuleName` [ty] Split out another constructor for `ModuleName` [ty] Add stub-file tests to existing module resolver [ty] Expose some routines in the module resolver [ty] Add more path helper functions [`flake8-annotations`] Remove unused import in example (`ANN401`) (#20000) [ty] distinguish base conda from child conda (#19990) [ty] Fix server hang (#19991) ...

chirizxc added 2 commits July 23, 2025 20:35

[flake8-use-pathlib] Add autofix for PTH102, PTH103

89deb8e

add PR number

9ea899b

ntBre self-requested a review July 23, 2025 17:55

refactor rules

5e93654

chirizxc added 2 commits July 23, 2025 22:37

rename args_str to mkdir_args

07bcaba

fix clippy

38893ef

ntBre added fixes Related to suggested fixes for violations preview Related to preview mode features labels Jul 24, 2025

ntBre reviewed Jul 24, 2025

View reviewed changes

chirizxc added 3 commits July 24, 2025 19:54

apply review feedback (x1)

d19bc5a

simplify replacement

6d26207

add rule code

c25db42

ntBre reviewed Jul 26, 2025

View reviewed changes

crates/ruff_linter/src/rules/flake8_use_pathlib/rules/os_makedirs.rs Show resolved Hide resolved

chirizxc added 2 commits July 26, 2025 22:57

fix autofixes

2f87f5a

fmt

6b6a63b

chirizxc added 5 commits July 26, 2025 23:08

inline mode/exist_ok into format! and remove redundant let

e8f153b

create has_unknown_keywords

4e4a54a

fix clippy

0a86ec7

fmt

a4d37b9

fix python doc link

ea7a78a

chirizxc commented Jul 28, 2025

View reviewed changes

crates/ruff_linter/src/rules/flake8_use_pathlib/rules/os_makedirs.rs Outdated Show resolved Hide resolved

use itertools::join

f1b5b71

chirizxc requested a review from ntBre August 1, 2025 15:38

chirizxc added 2 commits August 6, 2025 20:51

imports formatting

dcf1dfd

Prefer positional argument style in mkdir() replacement when the orig…

29df00f

…inal call uses exactly 3 positional arguments and no keywords

resolve branch conflict

e1a2087

resolve branch conflict (x2)

601aeae

ntBre reviewed Aug 19, 2025

View reviewed changes

crates/ruff_linter/src/rules/flake8_use_pathlib/rules/os_makedirs.rs Outdated Show resolved Hide resolved

crates/ruff_linter/src/rules/flake8_use_pathlib/rules/os_makedirs.rs Outdated Show resolved Hide resolved

chirizxc added 3 commits August 20, 2025 18:41

simplify mkdir_args

a9af19d

use call.arguments.len() instead of arguments.args

2e38da5

not offer autofix if argument is starred expr

9ac08f5

ntBre approved these changes Aug 20, 2025

View reviewed changes

ntBre changed the title ~~[flake8-use-pathlib] Add autofix for PTH102, PTH103~~ [flake8-use-pathlib] Add fixes for PTH102 and PTH103 Aug 20, 2025

ntBre mentioned this pull request Aug 20, 2025

autofix for flake8-use-pathlib (PTH) rules #2331

Open

ntBre merged commit d04dcd9 into astral-sh:main Aug 20, 2025
35 checks passed

BrewTestBot mentioned this pull request Aug 21, 2025

ruff 0.12.10 Homebrew/homebrew-core#234408

Merged

chirizxc deleted the feat/pth-autofixes branch September 18, 2025 14:39

Comments

Conversation

chirizxc commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

chirizxc commented Jul 23, 2025

Uh oh!

github-actions bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

chirizxc commented Jul 23, 2025

Uh oh!

chirizxc commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chirizxc commented Jul 23, 2025

Uh oh!

chirizxc commented Jul 24, 2025

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chirizxc commented Jul 26, 2025

Uh oh!

chirizxc commented Jul 26, 2025

Uh oh!

Uh oh!

chirizxc commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chirizxc commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chirizxc commented Aug 12, 2025

Uh oh!

ntBre commented Aug 12, 2025

Uh oh!

chirizxc commented Aug 12, 2025

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ntBre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chirizxc commented Jul 23, 2025 •

edited

Loading

github-actions bot commented Jul 23, 2025 •

edited

Loading

`ruff-ecosystem` results

chirizxc commented Jul 23, 2025 •

edited

Loading

chirizxc commented Aug 1, 2025 •

edited

Loading

chirizxc commented Aug 6, 2025 •

edited

Loading