Skip to content

Comments

[ty] Apply codemod adding stdlib docstrings#19327

Closed
AlexWaygood wants to merge 1 commit intomainfrom
alex/add-docstrings
Closed

[ty] Apply codemod adding stdlib docstrings#19327
AlexWaygood wants to merge 1 commit intomainfrom
alex/add-docstrings

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jul 14, 2025 •
edited
Loading

Summary

PR that adds the codemod being setup in #19311, to check that it doesn't have a deleterious impact on performance. It's just for testing purposes, since the idea is that this codemod will be autoapplied during every typeshed sync.

Test Plan

CI

@AlexWaygood AlexWaygood added do-not-merge Do not merge this pull request ty Multi-file analysis & type inference labels Jul 14, 2025
@AlexWaygood AlexWaygood changed the title add the docstrings [ty] Apply codemod adding stdlib docstrings Jul 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2025

mypy_primer results

No ecosystem changes detected ✅

Memory usage changes were detected when running on open source projects 
flake8 (https://github.com/pycqa/flake8)
-     memo fields = ~63MB
+     memo fields = ~66MB

trio (https://github.com/python-trio/trio)
-     memo fields = ~152MB
+     memo fields = ~159MB

@AlexWaygood AlexWaygood mentioned this pull request Jul 14, 2025
Merged
@AlexWaygood
Copy link
Member Author

AlexWaygood commented Jul 14, 2025

(the failing tests are just some snapshots that would need to be updated)

@AlexWaygood AlexWaygood deleted the alex/add-docstrings branch July 14, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm Awaiting requested review from carljm carljm will be requested when the pull request is marked ready for review carljm is a code owner

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser will be requested when the pull request is marked ready for review MichaReiser is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp will be requested when the pull request is marked ready for review sharkdp is a code owner

@dcreager dcreager Awaiting requested review from dcreager dcreager will be requested when the pull request is marked ready for review dcreager is a code owner

@ibraheemdev ibraheemdev Awaiting requested review from ibraheemdev ibraheemdev will be requested when the pull request is marked ready for review ibraheemdev is a code owner

Assignees

No one assigned

Labels

do-not-merge Do not merge this pull request ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AlexWaygood