[pyupgrade] Make example error out-of-the-box (UP040)#19296
Merged
AlexWaygood merged 2 commits intoastral-sh:mainfrom Jul 12, 2025
Merged
[pyupgrade] Make example error out-of-the-box (UP040)#19296AlexWaygood merged 2 commits intoastral-sh:mainfrom
pyupgrade] Make example error out-of-the-box (UP040)#19296AlexWaygood merged 2 commits intoastral-sh:mainfrom
Conversation
Contributor
|
AlexWaygood
reviewed
Jul 12, 2025
| /// | ||
| /// ## Example | ||
| /// ```python | ||
| /// from typing import TypeAlias, TypeAliasType |
Member
There was a problem hiding this comment.
Let's add the other missing imports too, even if they're not necessary to trigger UP040 out of the box:
Suggested change
| /// from typing import TypeAlias, TypeAliasType | |
| /// from typing import TypeAlias, TypeAliasType, Annotated | |
| /// from annotated_types import Gt |
And could you also add the missing imports of Annotated and Gt to the Use instead: block below?
AlexWaygood
approved these changes
Jul 12, 2025
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
Jul 18, 2025
…19296) <!-- Thank you for contributing to Ruff/ty! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? (Please prefix with `[ty]` for ty pull requests.) - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> Part of astral-sh#18972 This PR makes [non-pep695-type-alias (UP040)](https://docs.astral.sh/ruff/rules/non-pep695-type-alias/#non-pep695-type-alias-up040)'s example error out-of-the-box. [Old example](https://play.ruff.rs/6beca1be-45cd-4e5a-aafa-6a0584c10d64) ```py ListOfInt: TypeAlias = list[int] PositiveInt = TypeAliasType("PositiveInt", Annotated[int, Gt(0)]) ``` [New example](https://play.ruff.rs/bbad34da-bf07-44e6-9f34-53337e8f57d4) ```py from typing import Annotated, TypeAlias, TypeAliasType from annotated_types import Gt ListOfInt: TypeAlias = list[int] PositiveInt = TypeAliasType("PositiveInt", Annotated[int, Gt(0)]) ``` Imports were also added to the "Use instead" section. ## Test Plan <!-- How was it tested? --> N/A, no functionality/tests affected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #18972
This PR makes non-pep695-type-alias (UP040)'s example error out-of-the-box.
Old example
New example
Imports were also added to the "Use instead" section.
Test Plan
N/A, no functionality/tests affected