Skip to content

Comments

Remove deprecated macOS config file discovery#19210

Merged
ntBre merged 1 commit intoastral-sh:brent/0.13.0from
CodeMan62:code/19145
Sep 5, 2025
Merged

Remove deprecated macOS config file discovery#19210
ntBre merged 1 commit intoastral-sh:brent/0.13.0from
CodeMan62:code/19145

Conversation

@CodeMan62
Copy link
Contributor

@CodeMan62 CodeMan62 commented Jul 8, 2025

Summary

In #11115 we moved from defaulting to $HOME/Library/Application Support to $XDG_HOME on macOS and added a deprecation warning if we find files in the old location. So this PR removes the warning
closes #19145

Test Plan

Ran cargo test

@CodeMan62 CodeMan62 mentioned this pull request Jul 8, 2025
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser added this to the v0.13 milestone Jul 8, 2025
@MichaReiser MichaReiser added do-not-merge Do not merge this pull request breaking Breaking API change configuration Related to settings and configuration and removed do-not-merge Do not merge this pull request labels Jul 8, 2025
@dhruvmanila dhruvmanila marked this pull request as draft July 10, 2025 06:22
ntBre
ntBre approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ntBre ntBre changed the base branch from main to brent/0.13.0 September 5, 2025 13:56
@ntBre ntBre changed the title refactor(ruff_workspace): remove macOS deprecation warning Remove deprecated macOS config file discovery Sep 5, 2025
@ntBre ntBre marked this pull request as ready for review September 5, 2025 13:56
@ntBre ntBre merged commit dc045d5 into astral-sh:brent/0.13.0 Sep 5, 2025
38 checks passed
@ntBre ntBre mentioned this pull request Sep 5, 2025
Merged
2 tasks
ntBre pushed a commit that referenced this pull request Sep 8, 2025
@CodeMan62 @ntBre
Remove deprecated macOS config file discovery (#19210)
6dd7143 
## Summary
In #11115 we moved from defaulting to $HOME/Library/Application Support
to $XDG_HOME on macOS and added a deprecation warning if we find files
in the old location. So this PR removes the warning
closes #19145 

## Test Plan
Ran `cargo test`
ntBre pushed a commit that referenced this pull request Sep 10, 2025
@CodeMan62 @ntBre
Remove deprecated macOS config file discovery (#19210)
a1c64eb 
## Summary
In #11115 we moved from defaulting to $HOME/Library/Application Support
to $XDG_HOME on macOS and added a deprecation warning if we find files
in the old location. So this PR removes the warning
closes #19145 

## Test Plan
Ran `cargo test`
ntBre pushed a commit that referenced this pull request Sep 10, 2025
@CodeMan62 @ntBre
Remove deprecated macOS config file discovery (#19210)
0132248 
## Summary
In #11115 we moved from defaulting to $HOME/Library/Application Support
to $XDG_HOME on macOS and added a deprecation warning if we find files
in the old location. So this PR removes the warning
closes #19145 

## Test Plan
Ran `cargo test`
ntBre pushed a commit that referenced this pull request Sep 10, 2025
@CodeMan62 @ntBre
Remove deprecated macOS config file discovery (#19210)
ee448ea 
## Summary
In #11115 we moved from defaulting to $HOME/Library/Application Support
to $XDG_HOME on macOS and added a deprecation warning if we find files
in the old location. So this PR removes the warning
closes #19145 

## Test Plan
Ran `cargo test`
dcreager added a commit that referenced this pull request Sep 10, 2025
@dcreager
Merge branch 'main' into dcreager/constraint-mdtest
8bded2b 
* main: (26 commits)
  Ignore deprecated rules unless selected by exact code (#20167)
  Stabilize adding future import via config option (#20277)
  [`flake8-errmsg`] Stabilize extending `raw-string-in-exception` (`EM101`) to support byte strings (#20273)
  Stabilize the remaining Airflow rules (#20250)
  [`flake8-bugbear`] Stabilize support for non-context-manager calls in `assert-raises-exception` (`B017`) (#20274)
  [`flake8-commas`] Stabilize support for trailing comma checks in type parameter lists (`COM812`, `COM819`) (#20275)
  [`pygrep_hooks`] Stabilize using`AsyncMock` methods in `invalid-mock-access` (`PGH005`) (#20272)
  Stabilize new strategy for classifying imports as first party (#20268)
  [`pylint`] Stabilize ignoring `__init__.py` for `useless-import-alias` (`PLC0414`) (#20271)
  [`pylint`] Stabilize adding U+061C to `bidirectional-unicode` (`PLE2502`) (#20276)
  [`flake8-simplify`] Stabilize fix safety of `multiple-with-statements` (`SIM117`) (#20270)
  Stabilize `pytest-raises-ambiguous-pattern` (`RUF043`) (#20253)
  Stabilize `f-string-number-format` (`FURB116`) (#20247)
  [`pyupgrade`] Remove `non-pep604-isinstance` (`UP038`) (#19156)
  [`pandas-vet`] Remove `pandas-df-variable-name` (`PD901`) (#19223)
  Remove deprecated macOS config file discovery (#19210)
  Stabilize `redundant-none-literal` (`PYI061`) (#20236)
  Stabilize `generic-not-last-base-class` (`PYI059`) (#20246)
  Stabilize `useless-class-metaclass-type` (`UP050`) (#20230)
  Stabilize `os-symlink` (`PTH211`) (#20229)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntBre ntBre ntBre approved these changes

Assignees

No one assigned

Labels

breaking Breaking API change configuration Related to settings and configuration

Projects

None yet

Milestone

v0.13

Development

Successfully merging this pull request may close these issues.

Consider removing deprecated macOS config file discovery

3 participants

@CodeMan62 @ntBre @MichaReiser