[ty] Add tests for dataclass fields annotated with Final#19202
Merged
Conversation
Contributor
|
AlexWaygood
approved these changes
Jul 8, 2025
sharkdp
force-pushed
the
david/dataclass-final-fields
branch
from
0c7706a to
7d642e6
Compare
AlexWaygood
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds some tests for dataclass fields that are annotated with
Final(see comment here). Turns out that nothing is needed here, everything already works as expected (apart from the fact that we can assign toFinalfields, which is tracked in astral-sh/ty#158Test Plan
New Markdown tests