Skip to content

Comments

Rename to SessionSnapshot, move unwind assertion closer#19177

Merged
dhruvmanila merged 1 commit intomainfrom
dhruv/address-review-comments
Jul 7, 2025
Merged

Rename to SessionSnapshot, move unwind assertion closer#19177
dhruvmanila merged 1 commit intomainfrom
dhruv/address-review-comments

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Jul 7, 2025

This PR addresses the post-merge review comments from #19041, specifically it:

  • Rename WorkspaceSnapshot to SessionSnapshot
  • Rename take_workspace_snapshot to take_session_snapshot
  • Rename take_snapshot to take_document_snapshot
  • Move AssertUnwindSafe closer to the catch_unwind call which requires the assertion

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Jul 7, 2025
@dhruvmanila dhruvmanila mentioned this pull request Jul 7, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

mypy_primer results

Changes were detected when running on open source projects 
parso (https://github.com/davidhalter/parso)
-     memo fields = ~49MB
+     memo fields = ~54MB

bidict (https://github.com/jab/bidict)
-     memo fields = ~17MB
+     memo fields = ~15MB

beartype (https://github.com/beartype/beartype)
- TOTAL MEMORY USAGE: ~97MB
+ TOTAL MEMORY USAGE: ~88MB

ignite (https://github.com/pytorch/ignite)
-     memo fields = ~189MB
+     memo fields = ~171MB

jinja (https://github.com/pallets/jinja)
-     memo fields = ~88MB
+     memo fields = ~80MB

pytest (https://github.com/pytest-dev/pytest)
- TOTAL MEMORY USAGE: ~276MB
+ TOTAL MEMORY USAGE: ~251MB

isort (https://github.com/pycqa/isort)
- TOTAL MEMORY USAGE: ~88MB
+ TOTAL MEMORY USAGE: ~97MB

altair (https://github.com/vega/altair)
-     memo fields = ~251MB
+     memo fields = ~228MB

bokeh (https://github.com/bokeh/bokeh)
- TOTAL MEMORY USAGE: ~251MB
+ TOTAL MEMORY USAGE: ~276MB

openlibrary (https://github.com/internetarchive/openlibrary)
-     memo fields = ~189MB
+     memo fields = ~171MB

manticore (https://github.com/trailofbits/manticore)
-     memo fields = ~652MB
+     memo fields = ~593MB

MichaReiser
MichaReiser approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@dhruvmanila dhruvmanila merged commit 8cf1b87 into main Jul 7, 2025
37 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/address-review-comments branch July 7, 2025 14:14
UnboundVariable pushed a commit to UnboundVariable/ruff that referenced this pull request Jul 7, 2025
Merge branch 'main' of https://github.com/astral-sh/ruff into semanti…
53b6abe 
…c_tokens

* 'main' of https://github.com/astral-sh/ruff: (27 commits)
  [ty] First cut at semantic token provider (astral-sh#19108)
  [`flake8-simplify`] Make example error out-of-the-box (`SIM116`) (astral-sh#19111)
  [`flake8-use-pathlib`] Make example error out-of-the-box (`PTH210`) (astral-sh#19189)
  [`flake8-use-pathlib`] Add autofixes for `PTH203`, `PTH204`, `PTH205` (astral-sh#18922)
  [`flake8-type-checking`] Fix syntax error introduced by fix (`TC008`) (astral-sh#19150)
  [`flake8-pyi`] Make example error out-of-the-box (`PYI007`, `PYI008`) (astral-sh#19103)
  Update Rust crate indicatif to 0.18.0 (astral-sh#19165)
  [ty] Add separate CI job for memory usage stats (astral-sh#19134)
  [ty] Add documentation for server traits (astral-sh#19137)
  Rename to `SessionSnapshot`, move unwind assertion closer (astral-sh#19177)
  [`flake8-type-checking`] Make example error out-of-the-box (`TC001`) (astral-sh#19151)
  [ty] Bare `ClassVar` annotations (astral-sh#15768)
  [ty] Re-enable multithreaded pydantic benchmark (astral-sh#19176)
  [ty] Implement equivalence for protocols with method members (astral-sh#18659)
  [ty] Use RHS inferred type for bare `Final` symbols (astral-sh#19142)
  [ty] Support declaration-only attributes (astral-sh#19048)
  [ty] Sync vendored typeshed stubs (astral-sh#19174)
  Update dependency pyodide to ^0.28.0 (astral-sh#19164)
  Update NPM Development dependencies (astral-sh#19170)
  Update taiki-e/install-action action to v2.56.7 (astral-sh#19169)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees

No one assigned

Labels

internal An internal refactor or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhruvmanila @MichaReiser