Conversation
AlexWaygood
added
performance
AlexWaygood
commented
Jul 4, 2025
Comment on lines
500
to
503
| assert!( | ||
| diagnostics > 1 && diagnostics <= max_diagnostics, | ||
| "Expected between {} and {} diagnostics but got {}", | ||
| 1, | ||
| max_diagnostics, | ||
| diagnostics | ||
| diagnostics <= max_diagnostics, | ||
| "Expected <={max_diagnostics} diagnostics but got {diagnostics}" | ||
| ); |
Member
Author
There was a problem hiding this comment.
we don't emit any diagnostics on this library (it's well-typed!), so this assertion didn't pass as-is as it expects at least 1 diagnostic
Contributor
|
carljm
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
DateTypelibrary has some very large protocols in it. Currently we type-check it quite quickly, but the current version of #18659 makes our execution time on this library pathologically slow. That PR doesn't seem to have a big impact on any of our current benchmarks, however, so it seems we have some missing coverage in this area; I therefore propose that we addDateTypeas a benchmark.Currently the benchmark runs pretty quickly (about half the runtime of attrs, which is our fastest real-world benchmark currently), and the library has 0 third-party dependencies, so the benchmark is quick to setup.
Test Plan
cargo bench -p ruff_benchmark --bench=ty