[ty] Add into_callable method for Type by MatthewMckee4 · Pull Request #19130 · astral-sh/ruff

MatthewMckee4 · 2025-07-03T18:28:40Z

Summary

Was just playing around with this, there's definitely more to do with this function, but it seems like maybe a better option than having so many arms in has_relation_to for (_, Callable).

Not super invested in this but wanting to hear opinions if people have time

github-actions · 2025-07-03T18:32:21Z

`mypy_primer` results

Changes were detected when running on open source projects

mypy_primer (https://github.com/hauntsaninja/mypy_primer)
-     memo fields = ~45MB
+     memo fields = ~41MB

aioredis (https://github.com/aio-libs/aioredis)
-     memo fields = ~54MB
+     memo fields = ~60MB

operator (https://github.com/canonical/operator)
- TOTAL MEMORY USAGE: ~106MB
+ TOTAL MEMORY USAGE: ~97MB
-     memo fields = ~88MB
+     memo fields = ~80MB

pydantic (https://github.com/pydantic/pydantic)
- TOTAL MEMORY USAGE: ~142MB
+ TOTAL MEMORY USAGE: ~156MB

mkdocs (https://github.com/mkdocs/mkdocs)
- TOTAL MEMORY USAGE: ~129MB
+ TOTAL MEMORY USAGE: ~117MB

tornado (https://github.com/tornadoweb/tornado)
- TOTAL MEMORY USAGE: ~156MB
+ TOTAL MEMORY USAGE: ~171MB

werkzeug (https://github.com/pallets/werkzeug)
-     memo fields = ~129MB
+     memo fields = ~142MB

psycopg (https://github.com/psycopg/psycopg)
- TOTAL MEMORY USAGE: ~207MB
+ TOTAL MEMORY USAGE: ~228MB

AlexWaygood

This is great! I think it's exactly the direction we want to head in, as it will make subtyping/assignability between various types and protocols with __call__ methods easier too.

crates/ty_python_semantic/src/types.rs

Co-authored-by: Alex Waygood <[email protected]>

…into into-callable

MatthewMckee4 · 2025-07-03T20:11:05Z

Seems like they're caught in mypy primer, ill make them return None but add a todo comment

carljm

This looks great, thank you!

cc @abhijeetbodas2001, I think my review comments on your returns-Never PR mentioned wanting this method.

crates/ty_python_semantic/src/types.rs

Add into_callable method for Type

68b9ea1

MatthewMckee4 requested review from AlexWaygood, carljm, dcreager and sharkdp as code owners July 3, 2025 18:28

Add todo back

05b25de

MatthewMckee4 changed the title ~~Add into_callable method for Type~~ [ty] Add into_callable method for Type Jul 3, 2025

AlexWaygood added the ty Multi-file analysis & type inference label Jul 3, 2025

MatthewMckee4 mentioned this pull request Jul 3, 2025

dataclass class literal subtyping with callables not working astral-sh/ty#760

Closed

AlexWaygood reviewed Jul 3, 2025

View reviewed changes

crates/ty_python_semantic/src/types.rs Outdated Show resolved Hide resolved

crates/ty_python_semantic/src/types.rs Outdated Show resolved Hide resolved

crates/ty_python_semantic/src/types.rs Outdated Show resolved Hide resolved

AlexWaygood reviewed Jul 3, 2025

View reviewed changes

crates/ty_python_semantic/src/types.rs Outdated Show resolved Hide resolved

MatthewMckee4 and others added 8 commits July 3, 2025 20:51

Update crates/ty_python_semantic/src/types.rs

52e9266

Co-authored-by: Alex Waygood <[email protected]>

Update crates/ty_python_semantic/src/types.rs

0cf6048

Co-authored-by: Alex Waygood <[email protected]>

Update crates/ty_python_semantic/src/types.rs

573dcd6

Co-authored-by: Alex Waygood <[email protected]>

Merge branch 'into-callable' of https://github.com/MatthewMckee4/ruff …

3dd1506

…into into-callable

Fill match arms

d1b500b

Add todo in some arms

c1059e5

group arms

ae21033

Dont panic

b2e0e14

carljm approved these changes Jul 4, 2025

View reviewed changes

crates/ty_python_semantic/src/types.rs Outdated Show resolved Hide resolved

carljm and others added 2 commits July 3, 2025 18:54

Update crates/ty_python_semantic/src/types.rs

43b3804

cargo fmt

8b8f168

carljm merged commit 3be83d3 into astral-sh:main Jul 4, 2025
35 checks passed

abhijeetbodas2001 mentioned this pull request Jul 4, 2025

[ty] Correctly handle calls to functions marked as returning Never / NoReturn #18333

Merged

MatthewMckee4 deleted the into-callable branch July 16, 2025 21:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[ty] Add into_callable method for Type#19130

[ty] Add into_callable method for Type#19130
carljm merged 12 commits intoastral-sh:mainfrom
MatthewMckee4:into-callable

MatthewMckee4 commented Jul 3, 2025

Uh oh!

github-actions bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

AlexWaygood left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MatthewMckee4 commented Jul 3, 2025

Uh oh!

carljm left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

MatthewMckee4 commented Jul 3, 2025

Summary

Uh oh!

github-actions bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MatthewMckee4 commented Jul 3, 2025

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jul 3, 2025 •

edited

Loading

`mypy_primer` results