Conversation
I renamed a field on a `Completion` struct in #18982, and it looks like this caused the playground to fail to build: https://github.com/astral-sh/ruff/actions/runs/15928550050/job/44931734349 Maybe building that playground can be added to CI for pull requests?
Member
It should be part of the CI pipeline... but it's not a required check |
MichaReiser
added
playground
MichaReiser
approved these changes
Jun 27, 2025
Member
Author
Ah it got skipped: https://github.com/astral-sh/ruff/actions/runs/15928120587/job/44930290023?pr=18982 |
Member
|
Uhh, we should fix that. We should probably default to always run that job when any code changes |
dcreager
added a commit
that referenced
this pull request
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I renamed a field on a
Completionstruct in #18982, and it looks likethis caused the playground to fail to build:
https://github.com/astral-sh/ruff/actions/runs/15928550050/job/44931734349
Maybe building that playground can be added to CI for pull requests?