Skip to content

Comments

[flake8-async] Make ASYNC220, ASYNC221, and ASYNC222 examples error out-of-the-box#18978

Merged
ntBre merged 1 commit intoastral-sh:mainfrom
MeGaGiGaGon:patch-3
Jun 30, 2025
Merged

[flake8-async] Make ASYNC220, ASYNC221, and ASYNC222 examples error out-of-the-box#18978
ntBre merged 1 commit intoastral-sh:mainfrom
MeGaGiGaGon:patch-3

Conversation

@MeGaGiGaGon
Copy link
Contributor

Summary

Part of #18972

All three in one PR since they are in the same file.

This PR makes create-subprocess-in-async-function (ASYNC220)'s example error out-of-the-box

Old example

async def foo():
    os.popen(cmd)

New example

import os


async def foo():
    os.popen(cmd)

Imports were also added to the Use instead: section to make it valid code out-of-the-box.

This PR makes run-process-in-async-function (ASYNC221)'s example error out-of-the-box

Old example

async def foo():
    subprocess.run(cmd)

New example

import subprocess


async def foo():
    subprocess.run(cmd)

Imports were also added to the Use instead: section to make it valid code out-of-the-box.

This PR makes wait-for-process-in-async-function (ASYNC222)'s example error out-of-the-box

Old example

async def foo():
    os.waitpid(0)

New example

import os


async def foo():
    os.waitpid(0)

Imports were also added to the Use instead: section to make it valid code out-of-the-box.

Test Plan

N/A, no functionality/tests affected

@github-actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser requested a review from ntBre June 27, 2025 17:36
@ntBre ntBre added the documentation Improvements or additions to documentation label Jun 30, 2025
@ntBre ntBre merged commit b23b407 into astral-sh:main Jun 30, 2025
36 checks passed
iyakushev pushed a commit to iyakushev/ruff that referenced this pull request Jul 1, 2025
… error out-of-the-box (astral-sh#18978)

<!--
Thank you for contributing to Ruff/ty! To help us out with reviewing,
please consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title? (Please prefix
with `[ty]` for ty pull
  requests.)
- Does this pull request include references to any relevant issues?
-->

## Summary

<!-- What's the purpose of the change? What does it do, and why? -->

Part of astral-sh#18972

All three in one PR since they are in the same file.

This PR makes [create-subprocess-in-async-function
(ASYNC220)](https://docs.astral.sh/ruff/rules/create-subprocess-in-async-function/#create-subprocess-in-async-function-async220)'s
example error out-of-the-box

[Old example](https://play.ruff.rs/465036af-d75f-4bda-ba24-e50e8618bf16)
```py
async def foo():
    os.popen(cmd)
```

[New example](https://play.ruff.rs/8cf43d50-f9e1-45d6-b711-968c7135f2e0)
```py
import os


async def foo():
    os.popen(cmd)
```

Imports were also added to the `Use instead:` section to make it valid
code out-of-the-box.

This PR makes [run-process-in-async-function
(ASYNC221)](https://docs.astral.sh/ruff/rules/run-process-in-async-function/#run-process-in-async-function-async221)'s
example error out-of-the-box

[Old example](https://play.ruff.rs/0698aaa1-c722-4f04-b56c-61edec06945c)
```py
async def foo():
    subprocess.run(cmd)
```

[New example](https://play.ruff.rs/e05bfcbc-e681-4a28-8f50-2c0c2537d038)
```py
import subprocess


async def foo():
    subprocess.run(cmd)
```

Imports were also added to the `Use instead:` section to make it valid
code out-of-the-box.

This PR makes [wait-for-process-in-async-function
(ASYNC222)](https://docs.astral.sh/ruff/rules/wait-for-process-in-async-function/#wait-for-process-in-async-function-async222)'s
example error out-of-the-box

[Old example](https://play.ruff.rs/4305d477-8995-462d-83ae-435731d71e67)
```py
async def foo():
    os.waitpid(0)
```

[New example](https://play.ruff.rs/ad10c042-3b18-49ca-8f5c-5ab720516da1)
```py
import os


async def foo():
    os.waitpid(0)
```

Imports were also added to the `Use instead:` section to make it valid
code out-of-the-box.

## Test Plan

<!-- How was it tested? -->

N/A, no functionality/tests affected
@MeGaGiGaGon MeGaGiGaGon deleted the patch-3 branch July 2, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants