[flake8-use-pathlib] Add autofixes for PTH203, PTH204, PTH205#18922
Merged
ntBre merged 17 commits intoastral-sh:mainfrom Jul 7, 2025
Merged
[flake8-use-pathlib] Add autofixes for PTH203, PTH204, PTH205#18922ntBre merged 17 commits intoastral-sh:mainfrom
flake8-use-pathlib] Add autofixes for PTH203, PTH204, PTH205#18922ntBre merged 17 commits intoastral-sh:mainfrom
Conversation
Contributor
Author
|
idk why |
Member
|
You'll need to update the snapshots (they assert the expected output) using |
Contributor
Author
i did, but the problem is that they don't update correctly |
Member
Can you say more about why they don't update correctly? I did and the snapshots were updated correctly |
Contributor
Author
|
Contributor
Author
|
i applied the changes from past snapshots, but for some reason they didn't overwrite now, very strange |
Member
|
Did you add them with |
Contributor
Author
yes |
Member
|
Can you run |
Contributor
Author
❯ git status
On branch feat/autofixes
Your branch is up to date with 'origin/feat/autofixes'.
Changes to be committed:
(use "git restore --staged <file>..." to unstage)
modified: crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH203_PTH203.py.snap
new file: crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__preview__PTH203_PTH203.py.snap
new file: crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__preview__PTH204_PTH204.py.snap
new file: crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__preview__PTH205_PTH205.py.snap
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap
modified: crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH205_PTH205.py.
``` |
Contributor
Author
❯ git diff
diff --git a/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap b/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap
index b137cbd77..6d3b40def 100644
--- a/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap
+++ b/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap
@@ -1,51 +1,357 @@
---
source: crates/ruff_linter/src/rules/flake8_use_pathlib/mod.rs
-snapshot_kind: text
---
-PTH204.py:6:1: PTH204 `os.path.getmtime` should be replaced by `Path.stat().st_mtime`
- |
-6 | os.path.getmtime("filename")
- | ^^^^^^^^^^^^^^^^ PTH204
-7 | os.path.getmtime(b"filename")
-8 | os.path.getmtime(Path("filename"))
- |
+PTH204.py:11:1: PTH202 `os.path.getsize` should be replaced by `Path.stat().st_size`
+ |
+11 | os.path.getmtime("filename")
+ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PTH202
+12 | os.path.getmtime(b"filename")
+13 | os.path.getmtime(Path("filename"))
+ |
:...skipping...
diff --git a/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap b/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap
index b137cbd77..6d3b40def 100644
--- a/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap
+++ b/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap
@@ -1,51 +1,357 @@
---
source: crates/ruff_linter/src/rules/flake8_use_pathlib/mod.rs
-snapshot_kind: text
---
-PTH204.py:6:1: PTH204 `os.path.getmtime` should be replaced by `Path.stat().st_mtime`
- |
-6 | os.path.getmtime("filename")
- | ^^^^^^^^^^^^^^^^ PTH204
-7 | os.path.getmtime(b"filename")
-8 | os.path.getmtime(Path("filename"))
- |
+PTH204.py:11:1: PTH202 `os.path.getsize` should be replaced by `Path.stat().st_size`
+ |
+11 | os.path.getmtime("filename")
+ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PTH202
+12 | os.path.getmtime(b"filename")
+13 | os.path.getmtime(Path("filename"))
+ |
+ = help: Replace with `Path(...).stat().st_size`
+
+PTH204.py:12:1: PTH202 `os.path.getsize` should be replaced by `Path.stat().st_size`
+ |
+11 | os.path.getmtime("filename")
ESCOD
diff --git a/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap b/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap
index b137cbd77..6d3b40def 100644
--- a/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap
+++ b/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap
index b137cbd77..6d3b40def 100644
--- a/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap
+++ b/crates/ruff_linter/src/rules/flake8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH204_PTH204.py.snap
@@ -1,51 +1,357 @@
---
source: crates/ruff_linter/src/rules/flake8_use_pathlib/mod.rs
-snapshot_kind: text
---
-PTH204.py:6:1: PTH204 `os.path.getmtime` should be replaced by `Path.stat().st_mtime`
- |
-6 | os.path.getmtime("filename")
- | ^^^^^^^^^^^^^^^^ PTH204
-7 | os.path.getmtime(b"filename")
-8 | os.path.getmtime(Path("filename"))
- |
+PTH204.py:11:1: PTH202 `os.path.getsize` should be replaced by `Path.stat().st_size`
+ |
+11 | os.path.getmtime("filename")
+ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PTH202
+12 | os.path.getmtime(b"filename")
+13 | os.path.getmtime(Path("filename"))
+ |
+ = help: Replace with `Path(...).stat().st_size`
+
+PTH204.py:12:1: PTH202 `os.path.getsize` should be replaced by `Path.stat().st_size`
+ |
+11 | os.path.getmtime("filename")
+12 | os.path.getmtime(b"filename")
+ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PTH202 |
Member
|
The output suggests that you still have uncommited local changes. You have to stage them using |
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PTH204 | 26 | 0 | 0 | 26 | 0 |
| PTH205 | 2 | 0 | 0 | 2 | 0 |
Contributor
Author
|
tests on github runners also passed, i don't really understand why, maybe it's because i did something wrong in adding the tests |
Contributor
Author
|
oh, sorry, i found my stupid mistake :( |
ntBre
reviewed
Jun 26, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks! I had some suggestions to factor out common code and maybe strip down new test cases a bit.
crates/ruff_linter/src/rules/flake8_use_pathlib/rules/os_path_getatime.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_use_pathlib/rules/os_path_getctime.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_use_pathlib/rules/os_path_getmtime.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_use_pathlib/rules/os_path_getctime.rs
Show resolved
Hide resolved
Contributor
Author
|
looks like windows runner down |
ntBre
reviewed
Jul 2, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks! Just a couple more suggestions, mostly around test organization.
ntBre
reviewed
Jul 4, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks! Just a couple more nits and a larger, but easy to fix, concern about the diagnostic range that I didn't notice before.
...8_use_pathlib/snapshots/ruff_linter__rules__flake8_use_pathlib__tests__PTH203_PTH203.py.snap
Outdated
Show resolved
Hide resolved
crates/ruff_linter/resources/test/fixtures/flake8_use_pathlib/PTH204.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
done! waiting CI |
CodSpeed Instrumentation Performance ReportMerging #18922 will not alter performanceComparing Summary
|
Contributor
|
Uh, I think something very weird just happened with CI. Both the ecosystem report and benchmarks are showing very unreasonable results. I'll try rerunning it. I definitely don't think your changes caused this. |
ntBre
reviewed
Jul 4, 2025
| | | ||
| 10 | os.path.getsize("filename") | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ PTH202 | ||
| | ^^^^^^^^^^^^^^^ PTH202 |
Contributor
There was a problem hiding this comment.
Ahh, I see. I missed this on #18763. The shorter range is how PTH202 used to be too, so this is perfect.
ntBre
approved these changes
Jul 4, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks! We'll get CI to pass somehow and then this is good to go. I may try closing and reopening the PR to fully re-trigger it if re-running through the actions interface doesn't work.
Contributor
|
Hmm, rerunning didn't seem to help. Do you want to try merging |
ntBre
reviewed
Jul 5, 2025
| if checker | ||
| .semantic() | ||
| .resolve_qualified_name(&call.func) | ||
| .is_some_and(|qualified_name| qualified_name.segments() != ["os", "path", fn_name]) |
Contributor
There was a problem hiding this comment.
Well this is a bit embarrassing, but I just realized that my suggestion did break your code, and CI was correct. This should be is_none_or to preserve the original behavior.
Suggested change
| .is_some_and(|qualified_name| qualified_name.segments() != ["os", "path", fn_name]) | |
| .is_none_or(|qualified_name| qualified_name.segments() != ["os", "path", fn_name]) |
Contributor
Author
|
oh, it seems to working, thank you! |
ntBre
approved these changes
Jul 7, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Great, thanks again! And sorry for the bad suggestion
UnboundVariable
pushed a commit
to UnboundVariable/ruff
that referenced
this pull request
Jul 7, 2025
…c_tokens * 'main' of https://github.com/astral-sh/ruff: (27 commits) [ty] First cut at semantic token provider (astral-sh#19108) [`flake8-simplify`] Make example error out-of-the-box (`SIM116`) (astral-sh#19111) [`flake8-use-pathlib`] Make example error out-of-the-box (`PTH210`) (astral-sh#19189) [`flake8-use-pathlib`] Add autofixes for `PTH203`, `PTH204`, `PTH205` (astral-sh#18922) [`flake8-type-checking`] Fix syntax error introduced by fix (`TC008`) (astral-sh#19150) [`flake8-pyi`] Make example error out-of-the-box (`PYI007`, `PYI008`) (astral-sh#19103) Update Rust crate indicatif to 0.18.0 (astral-sh#19165) [ty] Add separate CI job for memory usage stats (astral-sh#19134) [ty] Add documentation for server traits (astral-sh#19137) Rename to `SessionSnapshot`, move unwind assertion closer (astral-sh#19177) [`flake8-type-checking`] Make example error out-of-the-box (`TC001`) (astral-sh#19151) [ty] Bare `ClassVar` annotations (astral-sh#15768) [ty] Re-enable multithreaded pydantic benchmark (astral-sh#19176) [ty] Implement equivalence for protocols with method members (astral-sh#18659) [ty] Use RHS inferred type for bare `Final` symbols (astral-sh#19142) [ty] Support declaration-only attributes (astral-sh#19048) [ty] Sync vendored typeshed stubs (astral-sh#19174) Update dependency pyodide to ^0.28.0 (astral-sh#19164) Update NPM Development dependencies (astral-sh#19170) Update taiki-e/install-action action to v2.56.7 (astral-sh#19169) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2331 | #18763
Test Plan
update snapshots