[ty] add support for mapped union and intersection subscript loads#18846
Merged
carljm merged 7 commits intoastral-sh:mainfrom Jun 23, 2025
Merged
Conversation
…hub.com/suneettipirneni/ruff into feature/mapped-union-intersection-loads
Contributor
|
dcreager
reviewed
Jun 23, 2025
Contributor
|
All the changes mentioned here are pretty minor -- going to just make those changes and land this. Thank you! |
Contributor
Author
Ok thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note this modifies the diagnostics a bit. Previously performing subscript access on something like
NotSubscriptable1 | NotSubscriptable2would report the full type as not being subscriptable:Now each erroneous constituent has a separate error:
Closes astral-sh/ty#625
Test Plan
mdtest