[ty] Rename src.root setting to environment.root#18760
Merged
MichaReiser merged 3 commits intomainfrom Jun 24, 2025
Merged
Conversation
MichaReiser
added
configuration
MichaReiser
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
MichaReiser
force-pushed
the
micha/rename-src-root-to-environment-root
branch
from
9f3e6ec to
cef0ebd
Compare
Contributor
|
Contributor
|
MichaReiser
force-pushed
the
micha/rename-src-root-to-environment-root
branch
from
cef0ebd to
bcb6ec1
Compare
Member
looks like we'll need to update the mypy_primer config for psycopg (and maybe some others too? Haven't checked): https://github.com/hauntsaninja/mypy_primer/blob/7c847cc51ed164d98c0a201539d61c974d418643/mypy_primer/projects.py#L1215 |
Member
|
AlexWaygood
approved these changes
Jun 19, 2025
MichaReiser
force-pushed
the
micha/rename-src-root-to-environment-root
branch
from
bcb6ec1 to
6059dda
Compare
AlexWaygood
reviewed
Jun 24, 2025
Co-authored-by: Alex Waygood <[email protected]>
dcreager
added a commit
that referenced
this pull request
Jun 24, 2025
* main: [ty] Fix false positives when subscripting an object inferred as having an `Intersection` type (#18920) [`flake8-use-pathlib`] Add autofix for `PTH202` (#18763) [ty] Add relative import completion tests [ty] Clarify what "cursor" means [ty] Add a cursor test builder [ty] Enforce sort order of completions (#18917) [formatter] Fix missing blank lines before decorated classes in .pyi files (#18888) Apply fix availability and applicability when adding to `DiagnosticGuard` and remove `NoqaCode::rule` (#18834) py-fuzzer: allow relative executable paths (#18915) [ty] Change `environment.root` to accept multiple paths (#18913) [ty] Rename `src.root` setting to `environment.root` (#18760) Use file path for detecting package root (#18914) Consider virtual path for various server actions (#18910) [ty] Introduce `UnionType::try_from_elements` and `UnionType::try_map` (#18911) [ty] Support narrowing on `isinstance()`/`issubclass()` if the second argument is a dynamic, intersection, union or typevar type (#18900) [ty] Add decorator check for implicit attribute assignments (#18587) [`ruff`] Trigger `RUF037` for empty string and byte strings (#18862) [ty] Avoid duplicate diagnostic in unpacking (#18897) [`pyupgrade`] Extend version detection to include `sys.version_info.major` (`UP036`) (#18633) [`ruff`] Frozen Dataclass default should be valid (`RUF009`) (#18735)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the
src.rootsetting toenvironment.rootbecause it doesn't configure what files to check, it configures the search paths.I'm open to better names. I think
environment.rootworks but I don't love it.I also noticed that there's some overlap between
environment.rootandsrc.include. E.g. if you setinclude = ["src"], then you probably also want to setenvironment.root = "src".Although I think it's more common that people exclude certain directories rather than only including
srcortest.I kept the old setting around for now and added a deprecation warning. If both
src.rootandenvironment.rootare set,environment.rootwins.Test Plan
Added tests