[pylint] De-emphasize __hash__ = Parent.__hash__ (PLW1641)#18613
Merged
Conversation
Summary -- This PR updates the docs for PLW1641 to place less emphasis on the example of inheriting a parent class's `__hash__` implementation by both reducing the length of the example and warning that it may be unsound in general, as @AlexWaygood pointed out on Notion. Test plan -- Existing tests
AlexWaygood
approved these changes
Jun 10, 2025
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Perfect, thank you! Some unrelated wordsmithing that we could also do while we're here:
Contributor
|
Co-authored-by: Alex Waygood <[email protected]>
dcreager
added a commit
that referenced
this pull request
Jun 10, 2025
* main: [`pylint`] De-emphasize `__hash__ = Parent.__hash__` (`PLW1641`) (#18613) [`flake8-pyi`] Avoid syntax error in the case of starred and keyword arguments (`PYI059`) (#18611) [ty] Add support for global __debug__ constant (#18540) [`ruff`] Preserve parentheses around `deque` in fix for `unnecessary-empty-iterable-within-deque-call` (`RUF037`) (#18598) [`refurb`] Parenthesize lambda and ternary expressions in iter (`FURB122`, `FURB142`) (#18592)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the docs for PLW1641 to place less emphasis on the example of inheriting a parent class's
__hash__implementation by both reducing the length of the example and warning that it may be unsound in general, as @AlexWaygood pointed out on Notion.Test plan
Existing tests