Stabilize pytest-parameter-with-default-argument (PT028)#18566
Merged
dylwil3 merged 1 commit intobrent/release-0.12.0from Jun 9, 2025
Merged
Stabilize pytest-parameter-with-default-argument (PT028)#18566dylwil3 merged 1 commit intobrent/release-0.12.0from
pytest-parameter-with-default-argument (PT028)#18566dylwil3 merged 1 commit intobrent/release-0.12.0from
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PT028 | 91 | 91 | 0 | 0 | 0 |
Linter (preview)
✅ ecosystem check detected no linter changes.
ntBre
force-pushed
the
brent/release-0.12.0
branch
from
0370d8a to
040fb6b
Compare
ntBre
force-pushed
the
brent/release-0.12.0
branch
from
040fb6b to
9252447
Compare
ntBre
force-pushed
the
brent/release-0.12.0
branch
from
9252447 to
829acf4
Compare
dylwil3
force-pushed
the
dylan/stabilize-pt028
branch
from
f9e2f7f to
3bc7453
Compare
ntBre
approved these changes
Jun 9, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
I think there are definitely some false positives here because of our is_likely_pytest_test function, which is pretty naive (not to say that we can necessarily do any better), but I think that's okay. It seems like a very useful rule for people actually using pytest.
Collaborator
Author
|
I think generally a way to make these rules more accurate is for the user to only enable them in a |
ntBre
pushed a commit
that referenced
this pull request
Jun 10, 2025
ntBre
pushed a commit
that referenced
this pull request
Jun 11, 2025
ntBre
pushed a commit
that referenced
this pull request
Jun 11, 2025
ntBre
pushed a commit
that referenced
this pull request
Jun 12, 2025
ntBre
pushed a commit
that referenced
this pull request
Jun 16, 2025
ntBre
pushed a commit
that referenced
this pull request
Jun 17, 2025
ntBre
pushed a commit
that referenced
this pull request
Jun 17, 2025
carljm
added a commit
to MatthewMckee4/ruff
that referenced
this pull request
Jun 17, 2025
…ence * main: (71 commits) Bump 0.12.0 (astral-sh#18724) Revert "[ty] Offer "Did you mean...?" suggestions for unresolved `from` imports and unresolved attributes (astral-sh#18705)" (astral-sh#18721) [`flake8-return`] Stabilize only add `return None` at the end when fixing `implicit-return` (`RET503`) (astral-sh#18516) [`pyupgrade`] Stabilize `non-pep695-generic-function` (`UP047`) (astral-sh#18524) [`pyupgrade`] Stabilize `non-pep695-generic-class` (`UP046`) (astral-sh#18519) [`pandas-vet`] Deprecate `pandas-df-variable-name` (`PD901`) (astral-sh#18618) [`flake8-bandit`] Remove `suspicious-xmle-tree-usage` (`S320`) (astral-sh#18617) Stabilize `dataclass-enum` (`RUF049`) (astral-sh#18570) Stabilize `unnecessary-dict-index-lookup` (`PLR1733`) (astral-sh#18571) Remove rust-toolchain.toml from sdist (astral-sh#17925) Stabilize `starmap-zip` (`RUF058`) (astral-sh#18525) [`flake8-logging`] Stabilize `exc-info-outside-except-handler` (`LOG014`) (astral-sh#18517) [`pyupgrade`] Stabilize `non-pep604-annotation-optional` (`UP045`) and preview behavior for `non-pep604-annotation-union` (`UP007`) (astral-sh#18505) Stabilize `pytest-warns-too-broad` (`PT030`) (astral-sh#18568) Stabilize `for-loop-writes` (`FURB122`) (astral-sh#18565) Stabilize `pytest-warns-with-multiple-statements` (`PT031`) (astral-sh#18569) Stabilize `pytest-parameter-with-default-argument` (`PT028`) (astral-sh#18566) Stabilize `nan-comparison` (`PLW0177`) (astral-sh#18559) Stabilize `check-and-remove-from-set` (`FURB132`) (astral-sh#18560) Stabilize `unnecessary-round` (`RUF057`) (astral-sh#18563) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.