Merged
Conversation
AlexWaygood
requested review from
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
AlexWaygood
added
testing
Contributor
|
AlexWaygood
force-pushed
the
alex/more-corpus-tests
branch
from
9aac8be to
c2b3a68
Compare
MichaReiser
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We now no longer panic on any of the files covered by the
linter_stubs_no_panic()test, so we can safely enable that without adding any new files to theKNOWN_FAILURESlist 🎉We still do panic on several files in typeshed when attempting to pull types, but the number is now low enough that we can just list the failing files in
KNOWN_FAILURES. Somewhat concerning is that we appear to have stack overflows when attempting to pull types in any typeshed files where the last segement of the path is "types.pyi". We should look into that -- but I still think it's worth expanding the corpus test to run over most typeshed files for now, to prevent future regressions.Test Plan
cargo test -p ty_project --test check