[refurb] Stabilize fix safety for readlines-in-for (FURB129)#18496
Merged
Conversation
dylwil3
added
rule
dylwil3
commented
Jun 6, 2025
Comment on lines
+129
to
+132
| // https://github.com/astral-sh/ruff/pull/18208 | ||
| pub(crate) const fn is_multiple_with_statements_fix_safe_enabled( | ||
| settings: &LinterSettings, | ||
| ) -> bool { |
Collaborator
Author
There was a problem hiding this comment.
Unrelated to the main change: just noticed this was missing a PR link and the prefix is_. This also accounts for the change in flake8_simplify/rules/ast_with.rs
ntBre
force-pushed
the
brent/release-0.12.0
branch
from
5f1af44 to
11966be
Compare
dylwil3
force-pushed
the
dylan/stabilize-readlines-fix-safe
branch
from
78e13e3 to
2e4e0f7
Compare
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| FURB129 | 10 | 0 | 0 | 10 | 0 |
Linter (preview)
✅ ecosystem check detected no linter changes.
Collaborator
Author
|
Ecosystem check looks good to me! |
ntBre
approved these changes
Jun 6, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Will you add these to the PR summary as you merge them? I'm also a bit paranoid about last time. What do you think about building up a Python code block and ruff invocation in the PR summary that makes sure that everything we stabilized makes it into the release? I'm picturing something like this for this case:
with open("file.txt") as fp:
for line in fp.readlines(): # FURB129
...ruff check example.py --no-cache \
--select FURB129 # room for more \ --select ... later
Collaborator
Author
|
Sounds good! We may need multiple code blocks in the end because for some stabilized behvaiors the file name matters (e.g. one of the behaviors cares whether the file is |
ntBre
added a commit
that referenced
this pull request
Jun 8, 2025
…18496) Note that the preview behavior was not documented (shame on us!) so the documentation was not modified. --------- Co-authored-by: Brent Westbrook <[email protected]>
ntBre
added a commit
that referenced
this pull request
Jun 8, 2025
…18496) Note that the preview behavior was not documented (shame on us!) so the documentation was not modified. --------- Co-authored-by: Brent Westbrook <[email protected]>
ntBre
added a commit
that referenced
this pull request
Jun 9, 2025
…18496) Note that the preview behavior was not documented (shame on us!) so the documentation was not modified. --------- Co-authored-by: Brent Westbrook <[email protected]>
ntBre
added a commit
that referenced
this pull request
Jun 10, 2025
…18496) Note that the preview behavior was not documented (shame on us!) so the documentation was not modified. --------- Co-authored-by: Brent Westbrook <[email protected]>
ntBre
added a commit
that referenced
this pull request
Jun 11, 2025
…18496) Note that the preview behavior was not documented (shame on us!) so the documentation was not modified. --------- Co-authored-by: Brent Westbrook <[email protected]>
ntBre
added a commit
that referenced
this pull request
Jun 17, 2025
…18496) Note that the preview behavior was not documented (shame on us!) so the documentation was not modified. --------- Co-authored-by: Brent Westbrook <[email protected]>
ntBre
added a commit
that referenced
this pull request
Jun 17, 2025
…18496) Note that the preview behavior was not documented (shame on us!) so the documentation was not modified. --------- Co-authored-by: Brent Westbrook <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the preview behavior was not documented (shame on us!) so the documentation was not modified.