[ty] Support ephemeral uv virtual environments by AlexWaygood · Pull Request #18335 · astral-sh/ruff

AlexWaygood · 2025-05-27T16:33:26Z

Summary

This PR implements support for the ephemeral environments uv creates when you use the --with argument with uv run. It will only work with a version of uv that includes astral-sh/uv@7bba3d0 (currently you have to build uv with the main branch; it hasn't been included in a release yet).

Fixes astral-sh/ty#320

Test Plan

I added unit tests. I also manually tested the PR by doing the following:

I first built the main branch of uv using cargo build --release in my local uv clone.

I next checked that ty on the main branch was not able to resolve imports if it was invoked with uv run --with=ty. To do this, I:
a. Applied this diff to the main branch of my local Ruff clone:

diff --git a/pyproject.toml b/pyproject.toml
index 0b983b27a0..1bdf25692f 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -3,7 +3,7 @@ requires = ["maturin>=1.0,<2.0"]
 build-backend = "maturin"

 [project]
-name = "ruff"
+name = "ty"
 version = "0.11.11"
 description = "An extremely fast Python linter and code formatter, written in Rust."
 authors = [{ name = "Astral Software Inc.", email = "[email protected]" }]
@@ -45,8 +45,8 @@ Changelog = "https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md"

 [tool.maturin]
 bindings = "bin"
-manifest-path = "crates/ruff/Cargo.toml"
-module-name = "ruff"
+manifest-path = "crates/ty/Cargo.toml"
+module-name = "ty"
 python-source = "python"
 strip = true
 exclude = [

b. cd'd into the local clone of a Python project with third-party dependencies (https://github.com/AlexWaygood/typeshed-stats)
c. Ran ../uv/target/release/uv run --force-reinstall --with="ty@../ruff" ty check
d. Observed that ty ran on my project, but was not able to resolve any third-party dependencies, and reported 104 diagnostics

I next checked that this PR branch fixed the issue. I:
a. Checked out this PR branch
b. Applied the same pyproject.toml diff to this branch as I applied to the main banch in step (2)
c. cd'd into my typeshed-stats again
d. Again ran ../uv/target/release/uv run --force-reinstall --with="ty@../ruff" ty check
e. Observed that ty was able to resolve all third-party dependencies, and reported only 11 diagnostics

github-actions · 2025-05-27T17:16:29Z

`mypy_primer` results

No ecosystem changes detected ✅

crates/ty_python_semantic/src/module_resolver/resolver.rs

MichaReiser · 2025-05-28T06:40:04Z

crates/ty_python_semantic/src/site_packages.rs

+                Err(err) => {
+                    tracing::warn!(
+                        "Failed to resolve the site-packages directories of this ephemeral uv virtual environment's \
+                        parent environment. Imports will not be resolved correctly if they refer to packages installed \
+                        into the parent environment. Underlying error: {err}"
+                    );
+                }
+            }


Unrelated to your PR but we should make this proper diagnostics and not just tracing warnings (that are easy to miss in the LSP)

I'll open a followup issue for this!

crates/ty_python_semantic/src/site_packages.rs

…ges` directories

* main: [ty] Support ephemeral uv virtual environments (#18335) Add a `ViolationMetadata::rule` method (#18234) Return `DiagnosticGuard` from `Checker::report_diagnostic` (#18232) [flake8_use_pathlib]: Replace os.symlink with Path.symlink_to (PTH211) (#18337) [ty] Support cancellation and retry in the server (#18273) [ty] Synthetic function-like callables (#18242) [ty] Support publishing diagnostics in the server (#18309) Add Autofix for ISC003 (#18256) [`pyupgrade`]: new rule UP050 (`useless-class-metaclass-type`) (#18334) [pycodestyle] Make `E712` suggestion not assume a context (#18328)

* main: (246 commits) [ty] Simplify signature types, use them in `CallableType` (astral-sh#18344) [ty] Support ephemeral uv virtual environments (astral-sh#18335) Add a `ViolationMetadata::rule` method (astral-sh#18234) Return `DiagnosticGuard` from `Checker::report_diagnostic` (astral-sh#18232) [flake8_use_pathlib]: Replace os.symlink with Path.symlink_to (PTH211) (astral-sh#18337) [ty] Support cancellation and retry in the server (astral-sh#18273) [ty] Synthetic function-like callables (astral-sh#18242) [ty] Support publishing diagnostics in the server (astral-sh#18309) Add Autofix for ISC003 (astral-sh#18256) [`pyupgrade`]: new rule UP050 (`useless-class-metaclass-type`) (astral-sh#18334) [pycodestyle] Make `E712` suggestion not assume a context (astral-sh#18328) put similar dunder-call tests next to each other (astral-sh#18343) [ty] Derive `PartialOrd, Ord` for `KnownInstanceType` (astral-sh#18340) [ty] Simplify `Type::try_bool()` (astral-sh#18342) [ty] Simplify `Type::normalized` slightly (astral-sh#18339) [ty] Move arviz off the list of selected primer projects (astral-sh#18336) [ty] Add --config-file CLI arg (astral-sh#18083) [ty] Tell the user why we inferred a certain Python version when reporting version-specific syntax errors (astral-sh#18295) [ty] Implement implicit inheritance from `Generic[]` for PEP-695 generic classes (astral-sh#18283) [ty] Add hint if async context manager is used in non-async with statement (astral-sh#18299) ...

AlexWaygood added the ty Multi-file analysis & type inference label May 27, 2025

AlexWaygood force-pushed the alex/ephemeral-uv-envs branch from d4f926c to 860ae77 Compare May 27, 2025 17:10

[ty] Support ephemeral uv virtual environments

a9d13be

AlexWaygood force-pushed the alex/ephemeral-uv-envs branch from 860ae77 to a9d13be Compare May 27, 2025 17:12

add unit tests

904a6a5

AlexWaygood marked this pull request as ready for review May 27, 2025 17:49

AlexWaygood requested review from carljm, dcreager and sharkdp as code owners May 27, 2025 17:49

MichaReiser reviewed May 27, 2025

View reviewed changes

crates/ty_python_semantic/src/module_resolver/resolver.rs Outdated Show resolved Hide resolved

carljm approved these changes May 27, 2025

View reviewed changes

MichaReiser approved these changes May 28, 2025

View reviewed changes

AlexWaygood added 2 commits May 28, 2025 12:38

encapsulate underlying data structure used for collecting `site-packa…

6c01fca

…ges` directories

make mdtest

536b241

AlexWaygood force-pushed the alex/ephemeral-uv-envs branch from cf0b387 to 536b241 Compare May 28, 2025 14:19

AlexWaygood enabled auto-merge (squash) May 28, 2025 14:21

AlexWaygood merged commit a5ebb3f into main May 28, 2025
35 checks passed

AlexWaygood deleted the alex/ephemeral-uv-envs branch May 28, 2025 14:55

AlexWaygood mentioned this pull request May 29, 2025

Convert tracing warnings during site-packages discovery to diagnostic warnings astral-sh/ty#542

Open

AlexWaygood mentioned this pull request Aug 14, 2025

Respect parent Python interpreter that invoked ty as a candidate Python env astral-sh/ty#989

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[ty] Support ephemeral uv virtual environments#18335

[ty] Support ephemeral uv virtual environments#18335
AlexWaygood merged 4 commits intomainfrom
alex/ephemeral-uv-envs

AlexWaygood commented May 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

MichaReiser May 28, 2025

Uh oh!

AlexWaygood May 28, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

AlexWaygood commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

github-actions bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

Uh oh!

MichaReiser May 28, 2025

Choose a reason for hiding this comment

Uh oh!

AlexWaygood May 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AlexWaygood commented May 27, 2025 •

edited

Loading

github-actions bot commented May 27, 2025 •

edited

Loading

`mypy_primer` results