Skip to content

Comments

[ty] Don't check classes and overloads if the file isn't first-party code#18327

Closed
AlexWaygood wants to merge 1 commit intomainfrom
alex/unnecessary-class-checks
Closed

[ty] Don't check classes and overloads if the file isn't first-party code#18327
AlexWaygood wants to merge 1 commit intomainfrom
alex/unnecessary-class-checks

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented May 26, 2025

No description provided.

@AlexWaygood AlexWaygood added performance Potential performance improvement ty Multi-file analysis & type inference labels May 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2025

mypy_primer results

No ecosystem changes detected ✅

@MichaReiser
Copy link
Member

I'm unsure if we want to do this before resolving astral-sh/ty#114

@AlexWaygood
Copy link
Member Author

I'm not seeing any speedup with this branch using the ty_benchmark script even when running ty on codebases that have large 3rd-party dependencies (e.g. pandas). So I'm fine to leave this for now.

@AlexWaygood AlexWaygood deleted the alex/unnecessary-class-checks branch May 26, 2025 20:01
@AlexWaygood AlexWaygood restored the alex/unnecessary-class-checks branch June 28, 2025 13:42
@AlexWaygood AlexWaygood reopened this Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Potential performance improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants